[mcclim-devel] question about format-graph-from-roots

[rpgoldman at sift.info]

Some time ago, Paolo (IIRC) posted a suggested patch to
format-graph-from-roots to supply a default for the arc-drawer keyword
argument.  Again, IIRC, the CLIM spec requires that there be such a
default.  I was just updating this morning, and noticed that the patch
has never been applied.  Would someone please apply it (unless there's
something wrong with it)?  One possible problem is that it ignores the
arc-drawing-options keyword, but it still seems better than not having
a default at all. 

Here's the patch:



Index: graph-formatting.lisp
===================================================================
RCS file: /project/mcclim/cvsroot/mcclim/graph-formatting.lisp,v
retrieving revision 1.11
diff -u -F^(def -r1.11 graph-formatting.lisp
--- graph-formatting.lisp       5 Dec 2004 19:37:52 -0000       1.11
+++ graph-formatting.lisp       7 Apr 2005 14:18:17 -0000
@@ -120,14 +120,20 @@ (define-graph-type :digraph digraph-grap
 ;;;; Entry

 (defun format-graph-from-roots (root-objects object-printer inferior-producer
-                                &rest graph-options
-                                &key stream orientation cutoff-depth
-                                     merge-duplicates duplicate-key duplicate-test
-                                     generation-separation
-                                     within-generation-separation
-                                     center-nodes arc-drawer arc-drawing-options
-                                     graph-type (move-cursor t)
-                                &allow-other-keys)
+                                            &rest graph-options
+                                            &key stream orientation cutoff-depth
+                                            merge-duplicates duplicate-key duplicate-test
+                                            generation-separation
+                                            within-generation-separation
+                                            center-nodes
+                                            (arc-drawer
+                                             #'(lambda (stream from to from-x from-y to-x to-y)
+                                                 (declare (ignore from to))
+                                                 (draw-line* stream from-x from-y to-x to-y)))
+
+                                            arc-drawing-options
+                                            graph-type (move-cursor t)
+                                            &allow-other-keys)
   (declare (ignore orientation generation-separation within-generation-separation center-nodes))
   ;; Mungle some arguments
   (check-type cutoff-depth (or null integer))