[mcclim-cvs] CVS update: mcclim/Apps/Listener/icons/wild.xpm
Max-Gerd Retzlaff
mretzlaff at common-lisp.net
Wed Aug 31 05:50:42 UTC 2005
Update of /project/mcclim/cvsroot/mcclim/Apps/Listener/icons
In directory common-lisp.net:/tmp/cvs-serv17279/Apps/Listener/icons
Added Files:
wild.xpm
Log Message:
This patch affects the CLIM-Listener.
It adds :
- sort-by for filenames to COM-SHOW-DIRECTORY,
- an icon and a cond-clause in ICON-OF for wild pathnames,
- a wrapper for LIST-DIRECTORY (that NCONCs the direct subdirectories
of the directory to the output of LIST-DIRECTORY if it is called with
a wild pathname),
- and does some minor changes to COM-SHOW-DIRECTORY.
Also it removes the SB-POSIX LIST-DIRECTORY for SBCL as that one
completely ignores the pathname-name and -type, which renders it quite
useless for :wild searches (pune or play on words intended).
There was a short discussion about this patch in #lisp some hourse
ago. As a result the wrapper for LIST-DIRECTORY is now called
LIST-DIRECTORY-WITH-ALL-DIRECT-SUBDIRECTORIES. And it will only used by
COM-SHOW-DIRECTORY if its new keyword parameter
:list-all-direct-subdirectories is specified as t (the default being nil).
The discussion (included because of the removed posix code in the
former SBCL version of LIST-DIRECTORY):
01:18 < mgr> hefner: Did you have a look at my listener patch?
01:19 < hefner> I did, it looked good
01:19 < mgr> hefner: You are not angry because it removes the posix stuff? :)
01:20 < hefner> mgr: did it? :) The posix stuff was horrible, terrible.
01:20 < mgr> hefner: So, you don't object if I commit it to the mcclim repository?
01:20 < hefner> mgr: no, go ahead
01:22 < mgr> hefner: Perhaps there should be a option to COM-SHOW-DIRECTORY to
switch between using LIST-DIRECTORY and LIST-DIRECTORY-WITH-ALL-SUBDIRECTORIES?
Perhaps the latter is not always desired..
01:22 < hefner> mgr: :recursive t ?
01:23 < mgr> hefner: No, it's different. if you list "/tmp/*.list" all direct
subdirectories of "/tmp/" will be listed as well, altough they do not match
"*.lisp".
01:24 < hefner> ah..
01:27 < hefner> mgr: hold on, you're just calling cl:directory? Isn't that going
to explode on broken symlinks?
01:33 < mgr> hefner: Uhm, explode? not really, no. Why? Symlinks are just
"resolved" on sbcl. That is if you select "/foo/bar" that is a symlink to
"/baz/quux", you'll always get the latter even if you select the former one.
01:34 < gilberth> mgr: not so fast. I have major hassle with CMUCL and XEmacs
silly lock symlinks.
01:34 < hefner> mgr: what if /baz/quux doesn't exist? I didn't write the aweful
posix code for my health.
01:35 < gilberth> They point to silly stuff like "gilbert at morganit.local.6092"
01:36 < mgr> gilberth: Well, the listener did always do only #'directory for
cmucl.. So, don't worry this does not affect you. :)
01:36 < gilberth> great.
01:37 < hefner> not only #'directory, but (directory pathname :truenamep nil)
01:39 < gilberth> mgr: It must use the right keyword options to #'directory in
CMUCL or something, since it works with borken symlinks.
01:39 < gilberth> it even shows a particular icon for the broken symlink.
01:39 < hefner> does it? that's a nice touch.
01:40 < gilberth> hefner: I thought you would know?
01:40 < hefner> I guess I forgot.
01:45 < mgr> hefner: there ist no problem with them. they will not be resolved,
that is #p"/foo/bar" will be returned. it will be displayed as an invalid
pathname because probe-file returns nil.
01:46 < hefner> mgr: I guess the behaviour changed. SBCL of 1.5 years ago didn't
do that. Carry on. :)
01:47 < mgr> hefner: Also the posix version completely ignores the pathname-name
and -type, and that's really not nice.
01:47 < hefner> well, pathname-name and pathname-type aren't nice either
01:47 < hefner> pathnames aren't nice
01:47 < mgr> hefner: Well, that's a different problem.
01:48 < mgr> hefner: I'll include this short discussion into the commit message,
okay? :)
01:48 < hefner> okay
Date: Wed Aug 31 07:50:41 2005
Author: mretzlaff
More information about the Mcclim-cvs
mailing list