From jonathlee at gmail.com Sun Jan 3 17:15:30 2010 From: jonathlee at gmail.com (Jonathan Lee) Date: Sun, 03 Jan 2010 11:15:30 -0600 Subject: [local-time-devel] Fix for SBCL conditional compile Message-ID: <4B40D0B2.4080001@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 While ASDF was compiling the version of local-time that I installed using clbuild, I ran into an error. It turns out that the compile time call to PACKAGE-WITH-SYMBOL? was wrapped in an IF statement, even though both results from the call would always evaluate to T, causing a call to an SBCL function that doesn't exist in my version (1.0.23) to be included. I've corrected the problem on my local copy. I tried to submit the patch to the local-time-devel list using "darcs send" as I couldn't determine who else I should send the patch to. However, I haven't seen it in my inbox yet, so I am assuming either my computer didn't send it properly or it got filtered out by the list server. I am including the patch as an attachment to this email, but if it gets filtered, just let me know what email address I should send it to. Jonathan Lee - -=-=- ... "Employ your time in improving yourself by other men's writings, so that you shall gain easily what others have labored hard for." - Socrates -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAktA0LIACgkQ9lVwGqYpXfEjZACfcTfXdWO1fq3qQm7gYlKbFA7g 9QkAn1BlXmTeLvOIUGdoxtpCZPK52vW8 =P/bc -----END PGP SIGNATURE----- -------------- next part -------------- A non-text attachment was scrubbed... Name: local-time-sbcl.patch Type: text/x-patch Size: 6839 bytes Desc: not available URL: From attila.lendvai at gmail.com Tue Jan 12 13:32:59 2010 From: attila.lendvai at gmail.com (Attila Lendvai) Date: Tue, 12 Jan 2010 14:32:59 +0100 Subject: [local-time-devel] Fix for SBCL conditional compile In-Reply-To: <4B40D0B2.4080001@gmail.com> References: <4B40D0B2.4080001@gmail.com> Message-ID: > While ASDF was compiling the version of local-time that I installed > using clbuild, I ran into an error. ?It turns out that the compile time > call to PACKAGE-WITH-SYMBOL? was wrapped in an IF statement, even though > both results from the call would always evaluate to T, causing a call to > an SBCL function that doesn't exist in my version (1.0.23) to be included. pushed (without much testing), thanks! -- attila From attila.lendvai at gmail.com Mon Jan 25 12:35:14 2010 From: attila.lendvai at gmail.com (Attila Lendvai) Date: Mon, 25 Jan 2010 13:35:14 +0100 Subject: [local-time-devel] non-intuitional behavior of adjust-timestamp and timezones Message-ID: hi! recently i've been bit by some of the timezone changes. i've recorded my expectations in the tests adjust-timestamp/bug[1-3] and also some fixes. i'm not entirely sure it's the right way to go with things, so please audit my patches! especially you Mathrick, as you started the original cleanup and i'm not sure my changes are inline with what you planned. -- attila From attila.lendvai at gmail.com Mon Jan 25 12:36:10 2010 From: attila.lendvai at gmail.com (Attila Lendvai) Date: Mon, 25 Jan 2010 13:36:10 +0100 Subject: [local-time-devel] some of my plans Message-ID: the &key offset naming is very much inconsistent among the functions. it's on my TODO to rename all of them to &key utc-timezone-offset and make sure that the offset is processed in seconds (unless already so), because that is the unit of the time scale. in case of disagreement, please do speak up! as stefil is gaining acceptance in the lisp community, it's another TODO of mine to move the test suite to hu.dwim.stefil (http://dwim.hu/project/hu.dwim.stefil with a single alexandria dependency). again, speak up in case of disagreement! -- attila From mathrick at gmail.com Wed Jan 27 01:05:09 2010 From: mathrick at gmail.com (Maciej Katafiasz) Date: Wed, 27 Jan 2010 02:05:09 +0100 Subject: [local-time-devel] non-intuitional behavior of adjust-timestamp and timezones In-Reply-To: References: Message-ID: <50b7e5181001261705i2b556ab6gb21858ef74af24ef@mail.gmail.com> On Mon, Jan 25, 2010 at 13:35, Attila Lendvai wrote: > recently i've been bit by some of the timezone changes. i've recorded > my expectations in the tests adjust-timestamp/bug[1-3] and also some > fixes. > > i'm not entirely sure it's the right way to go with things, so please > audit my patches! especially you Mathrick, as you started the original > cleanup and i'm not sure my changes are inline with what you planned. I'll try to have a look. I'm a bit busy right now, so it might slip my mind; if I don't respond in a reasonable time, please hit me with a stick. Cheers, Maciej From mathrick at gmail.com Wed Jan 27 01:07:54 2010 From: mathrick at gmail.com (Maciej Katafiasz) Date: Wed, 27 Jan 2010 02:07:54 +0100 Subject: [local-time-devel] some of my plans In-Reply-To: References: Message-ID: <50b7e5181001261707r1e9eb9f6sa051e634b37ae8c5@mail.gmail.com> On Mon, Jan 25, 2010 at 13:36, Attila Lendvai wrote: > the &key offset naming is very much inconsistent among the functions. > it's on my TODO to rename all of them to &key utc-timezone-offset and > make sure that the offset is processed in seconds (unless already so), > because that is the unit of the time scale. in case of disagreement, > please do speak up! Sounds reasonable. The API could use some consistency love overall, but that requires time and work investment I don't think I'll be able to afford anytime soon. > as stefil is gaining acceptance in the lisp community, it's another > TODO of mine to move the test suite to hu.dwim.stefil > (http://dwim.hu/project/hu.dwim.stefil with a single alexandria > dependency). again, speak up in case of disagreement! No objections here, I use stefil myself. Cheers, Maciej