[local-time-devel] [PATCH] Make local-time operate correctly with timezones

[Attila Lendvai]

> This is the patch.

i've pushed a patch to the official repo that is non-controversial,
and pushed the rest to my local tree to start testing it locally.

my timezone related knowledge is not enough to review the patch, but
your mail is starred and i'll start using your changes.

after a really short glimpse i didn't like the introduction of the
constant +none-zone+. i'd much prefer seeing assert's all around where
both arguments are available, so that calling a public api function
with both a timezone and an offset results in an error signaled.
something along the line of this as the first line of each such
function:

(defmacro assert-proper-timezone-and-offset ()
  `(assert (or (not timezone-provided?) (not offset))))

and for the internal functions using NIL's for the uninteresting position.

otherwise the patch looks good, thanks for the work!

-- 
 attila