<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8">
</head>
<body>
<div style="font-family:sans-serif"><div style="white-space:normal">
<p dir="auto">Sorry -- I got the markdown all stuffed up in my last message. I think it's readable, though.</p>
<p dir="auto">Best,<br>
r</p>
<p dir="auto">On 24 Jan 2018, at 15:58, Robert Goldman wrote:</p>
<blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px">
<p dir="auto">On 24 Jan 2018, at 15:39, Ilya Perminov wrote:</p>
<blockquote style="border-left:2px solid #777; color:#999; margin:0 0 5px; padding-left:5px; border-left-color:#999">
<p dir="auto">Hi Robert,</p>
<p dir="auto">To "revert" my patch manually just revert this change:</p>
<p dir="auto">--- old-iterate/iterate.lisp 2018-01-15 16:49:24.171636397 -0800<br>
+++ new-iterate/iterate.lisp 2018-01-15 16:49:24.171636397 -0800<br>
@@ -3374,7 +3374,7 @@<br>
(if (not (and (integerp n) (> n 0)))<br>
(clause-error "~a should be a positive integer" n-expr)<br>
;; Here, n is a positive integer.<br>
- (let* ((p-i (intern-previous-info var))<br>
+ (let* ((p-i (intern-previous-info var :next))<br>
(init-val (make-initial-value default default? (var-type var)))<br>
(temp (if (not (duplicable? init-val))<br>
(make-var-and-default-binding</p>
<p dir="auto">i.e. remove :next from (intern-previous-info var :next).<br>
I only tested my patch on SBCL 1.3.0 and it did not break any tests. The BUG<br>
tests failed, but everything else passed.</p>
<p dir="auto">Ilya</p>
</blockquote>
<p dir="auto">On MacOS, with SBCL 1.3.14, I get 5 failures:</p>
<pre style="background-color:#F7F7F7; border-radius:5px 5px 5px 5px; margin-left:15px; margin-right:15px; max-width:90vw; overflow-x:auto; padding:5px" bgcolor="#F7F7F7"><code style="background-color:#F7F7F7; border-radius:3px; margin:0; padding:0" bgcolor="#F7F7F7">5 out of 268 total tests failed: ITERATE.TEST::ALWAYS.FINALLY,
ITERATE.TEST::NEVER.FINALLY, ITERATE.TEST::THEREIS.FINALLY,
ITERATE.TEST::BUG/WALK.2, ITERATE.TEST::BUG/COLLECT-AT-BEGINNING.;
</code></pre>
<p dir="auto">I also see this:<br>
<code style="background-color:#F7F7F7; border-radius:3px; margin:0; padding:0 0.4em" bgcolor="#F7F7F7"><br>
; caught STYLE-WARNING:<br>
; undefined function: ITERATE:MULTIPLYING<br>
;<br>
; compilation unit finished<br>
; Undefined function:<br>
; ITERATE:MULTIPLYING<br>
; caught 1 ERROR condition<br>
; caught 1 WARNING condition<br>
; caught 1 STYLE-WARNING condition<br>
</code></p>
<p dir="auto">This is from loading the test system -- iterate itself loads without problems.</p>
<p dir="auto">I'm not sure why this happens: I see this:<br>
```<br>
iterate.lisp<br>
2872:(defsynonym multiplying multiply)</p>
<pre style="background-color:#F7F7F7; border-radius:5px 5px 5px 5px; margin-left:15px; margin-right:15px; max-width:90vw; overflow-x:auto; padding:5px" bgcolor="#F7F7F7"><code style="background-color:#F7F7F7; border-radius:3px; margin:0; padding:0" bgcolor="#F7F7F7">and `multiplying` seems to be exported from package.lisp.
The error occurs in `bug/macrolet.2`
One thing I don't understand -- the test suite seems to use `:SB-RT` on SBCL, which is *not* the same as the `RT` package. Any idea what's going on here? Definitely caused me some confusion as a not-normally-SBCL user.
</code></pre>
</blockquote>
</div>
</div>
</body>
</html>