[Gsll-devel] Typo/bug in histogram.lisp's grid:copy

Liam Healy lhealy at common-lisp.net
Fri Oct 17 03:01:40 UTC 2014


Thanks. Fixed in dfbc975074, currently on the antik-multiple-systems
branch.

Liam


On Tue, Aug 5, 2014 at 5:47 PM, Mirko Vukovic <mirko.vukovic at gmail.com>
wrote:

> I have been spending enjoyable time with gsll's (and gsl's) histogram
> routines.
>
> A small bug in the code popped up.  In histogram/histogram.lisp the
> grid:copy method calls histo-copy and histo-clone.  The arguments in those
> calls are incorrect.  This is what the method should look like:
>
> (defmethod grid:copy ((source histogram) &key destination
> &allow-other-keys)
>   (if destination
>       (histo-copy source destination)
>       (histo-clone source)))
>
> In the original, source and destination were swapped.
>
> The same fix applies to the method that specializes on histogram2d.
>
> Mirko
>
> _______________________________________________
> Gsll-devel mailing list
> Gsll-devel at common-lisp.net
> http://common-lisp.net/cgi-bin/mailman/listinfo/gsll-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/gsll-devel/attachments/20141016/d9830d17/attachment.html>


More information about the gsll-devel mailing list