[Gsll-devel] Typo/bug in histogram.lisp's grid:copy

[Mirko Vukovic]

I have been spending enjoyable time with gsll's (and gsl's) histogram
routines.

A small bug in the code popped up.  In histogram/histogram.lisp the
grid:copy method calls histo-copy and histo-clone.  The arguments in those
calls are incorrect.  This is what the method should look like:

(defmethod grid:copy ((source histogram) &key destination &allow-other-keys)
  (if destination
      (histo-copy source destination)
      (histo-clone source)))

In the original, source and destination were swapped.

The same fix applies to the method that specializes on histogram2d.

Mirko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/gsll-devel/attachments/20140805/ea55dbdc/attachment.html>