[Gsll-devel] patch: rank-1-update problem

[Liam Healy]

Thanks James.  I have applied your patch.  I have also added the tests
in the file tests/rank-1-update.lisp.  Despite what it says in the
comments about it being automatically generated, there's a fair amount
of manual intervention needed to create the tests, so it's not
surprising you were unable to get the unit test to "define itself" (!)
 And, someday, I hope to replace these "automatically generated" tests
with ports of the GSL tests.

Liam

On Wed, Sep 29, 2010 at 7:58 PM, James Wright <james at chumsley.org> wrote:
> Hi everyone,
>
> I've fixed an apparent argument-ordering issue in the definition of
> `rank-1-update'.  I also made the corresponding change to
> `conjugate-rank-1-update'.  The patch is attached.
>
> I've tested the fix insofar as I can now call `rank-1-update' in my
> code without it signalling an EBADLEN error; however, I haven't been
> able to get the corresponding unit test to define itself, so I haven't
> been able to check whether one of the failing unit tests is fixed by
> this change.
>
> Thanks,
>      James