[gsharp-devel] bugs

[Christophe Rhodes]

Hi,

I fixed a couple of bugs in MAKE-LAYER and its callees, and adding
layers from the gui now works again.

As well as <http://www-jcsu.jesus.cam.ac.uk/~csr21/gsharp-oops.png>,
another casualty of the change of coordinate systems is in multistaff
clusters: the stem calculation is wrong.  Reversing the signs of the
staff-yoffset comparisons in COMPUTE-STEM-LENGTH and
COMPUTE-MAXPOS-MINPOS almost gets it right, but not quite, and
COMPUTE-STEM-DIRECTION seems wrong as well.

Additionally, semibreve (or whole-note) rests hang from the wrong
staff line, and indeed seem to be out by a pixel or two (to reproduce,
type
  , C-r
and observe the disconnect; another
  C-r
shows that the minim (half-note) rest is wrong as well, clashing with
the middle staff line.

(Key signatures almost work properly now; the remaining problems are
generally connected with multiple layers on one staff: a layer
spanning multiple staves interprets key signatures correctly.  Patch
forthcoming in a few days, I hope.)

Cheers,

Christophe