[elephant-devel] Fwd: An Elephant task

[Xiangjun Wu]

片云天共远永夜月同孤


---------- Forwarded message ----------
From: Xiangjun Wu <netawater at gmail.com>
Date: Sun, Aug 16, 2009 at 10:18 PM
Subject: Re: An Elephant task
To: leslie.polzer at gmx.net


I have added the test case with his patch, please note the test data file is
UTF-8 file.

In my test, GET-INSTACES-BY-RANG is OK, but GET-ININSTACE-BY-VALUE and
GET-ININSTACES-BY-VALUE are NG when new code run in old store.

Please check it.

片云天共远永夜月同孤



On Thu, Aug 13, 2009 at 4:44 AM, Leslie P. Polzer
<sky at viridian-project.de>wrote:

>
> Xiangjun Wu wrote:
> > I have studied his patch and here is my conclusion:
> >
> > libberkeley-db.c
> > -    return wcs_cmp((wchar_t*)ad+5+offset, read_int32(ad+offset, 1),
> > (wchar_t*)bd+5+offset, read_int32(bd+offset, 1));
> >
> > +   return wcs_cmp((wchar_t*)(ad+5+offset), read_int32(ad+offset, 1),
> > (wchar_t*)(bd+5+offset), read_int32(bd+offset, 1));
> >>>>> It want to type cast, but I believe the compiler also do it.
>
> I think gcc does, but the compiler is not required to upgrade/cast
> the type of the other arguments. The second form seems more concise
> so I guess it's better.
>
>
> > unicode.lisp
> > he modified serialize-to-utf16le, serialize-to-utf32le and
> > deserialize-string ((type (eql :utf16le)), deserialize-string ((type
> > (eql :utf32le))
> > with respect to serialize and deserialize utf16 or utf32 string. I'm
> > not sure which is big endian or little endian, however he only do a
> > revert operation, It is OK.
>
> What about backwards compatibility? Say I've got a store with
> the old sorting order and load the code that uses the new one.
>
> Will the data sorted in the old way be read correctly?
>
>
> > his test file is OK which based the rightness of string< for utf16 and
> utf32
> > string.
> >
> > BerkeleyDB-tests is OK after I apply his patch in a clean repository.
>
> That's great! However we should also add the test cases he provided
> to the test suite. Can you do that?
>
>  Thanks a lot! :)
>
>    Leslie
>
> --
> http://www.linkedin.com/in/polzer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/elephant-devel/attachments/20090817/63537ce4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unicode.patch
Type: application/octet-stream
Size: 3596 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/elephant-devel/attachments/20090817/63537ce4/attachment.obj>