[eclipse-devel] [PATCH] Remove the start function and use eclipse:eclipse

[Luca Capello]

Hello!

I wanted to use Eclipse without an imagefile, but I got an error (with
CMUCL and SBCL):
=====
luca at gismo:~$ eclipse
; Loading #P"/home/luca/Hacking/cvs/eclipse/load-eclipse.lisp".
;; Loading #P"/home/luca/Hacking/cvs/eclipse/config.lisp".
;; Loading #P"/home/luca/Hacking/cvs/eclipse/system.lisp".
;;; Loading #P"/usr/lib/cmucl/subsystems/clx-library.x86f".
[...]
;; Loading #P"/home/luca/Hacking/cvs/eclipse/eclipse.x86f".

Unknown keyword argument -- :DIE-ON-INIT-ERROR.
   [Condition of type KERNEL:SIMPLE-PROGRAM-ERROR]

Restarts:
  0: [ABORT] Skip remaining initializations.

Debug  (type H for help)

(C::%UNKNOWN-KEYWORD-ARGUMENT-ERROR :DIE-ON-INIT-ERROR)
=====

I dug for the error and I found that in the eclipse bin I have:

    ${exec_prefix}/bin/$lisp \
        --load /home/luca/Hacking/cvs/eclipse/load-eclipse.lisp \
        --eval "(start ${options})"

The problem is that in load-eclipse.lisp.in, the start function is
declared as (start &key display sm-client-id), thus not accepting
the option ":die-on-init-error t", which is the default.

It seems that the start function is used only when you want to start
Eclipse from the fasl files.  For that reason, I think the best thing
to do is to evaluate "(eclipse:eclipse ${options})" instead (exactly
as it's done for the imagefile).

The attached patch against the latest CVS (cvs diff -Nau) does it:

- remove the start function

- evaluate "(eclipse:eclipse ${options})" in the eclipse bin even when
  using the fasl files

- modify the eclipse function to output the error condition (untested,
  I didn't had any error for the moment)

It works with CMUCL and imagefile or fasl files.

In case I am wrong, please disregard this mail ;-)

Thx, bye,
Gismo / Luca

-------------- next part --------------
A non-text attachment was scrubbed...
Name: eclipse_no-start-function_20060102.patch.gz
Type: application/octet-stream
Size: 757 bytes
Desc: Remove the start function and use eclipse:eclipse instead
URL: <https://mailman.common-lisp.net/pipermail/eclipse-devel/attachments/20060102/75a82088/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/eclipse-devel/attachments/20060102/75a82088/attachment.sig>