From christian.lynbech at ericsson.com  Wed Nov  5 08:46:13 2003
From: christian.lynbech at ericsson.com (Christian Lynbech)
Date: Wed, 05 Nov 2003 09:46:13 +0100
Subject: [eclipse-devel] Bug in Makefile.in
Message-ID: <ofr80n6w4q.fsf@situla.ted.dk.eu.ericsson.se>

There seems to be a small bug in the `install' target. At least I get
an error when trying to do an install on an Debian unstable
system. However ether are a few different `install' programs out there
so I am not sure that the problem isn't unique to me.

The following patch fixes the problem for me.

cvs server: Diffing .
Index: Makefile.in
===================================================================
RCS file: /project/eclipse/cvsroot/eclipse/Makefile.in,v
retrieving revision 1.7
diff -u -u -r1.7 Makefile.in
--- Makefile.in	6 Oct 2003 17:57:25 -0000	1.7
+++ Makefile.in	5 Nov 2003 08:45:05 -0000
@@ -101,7 +101,8 @@
 	    for theme in ${themes} ; do				\
 	      test -f "themes/$$theme/theme.o" &&		\
 	      $(install) -d ${themedir}/$$theme &&		\
-	      $(install) ${themedir}/$$theme/theme.o &&		\
+	      $(install) themes/$$theme/theme.o			\
+                         ${themedir}/$$theme/theme.o &&		\
 	      for file in themes/$$theme/*.pnm ; do		\
 		$(install) $$file ${themedir}/$$theme/. ;	\
 	      done ;						\



------------------------+-----------------------------------------------------
Christian Lynbech       | Ericsson Telebit, Skanderborgvej 232, DK-8260 Viby J
Phone: +45 8938 5244    | email: christian.lynbech at ericsson.com
Fax:   +45 8938 5101    | web:   www.ericsson.com
------------------------+-----------------------------------------------------
Hit the philistines three times over the head with the Elisp reference manual.
                                        - petonic at hal.com (Michael A. Petonic)




From hatchond at labri.fr  Tue Nov 11 02:35:55 2003
From: hatchond at labri.fr (Iban Hatchondo)
Date: Tue, 11 Nov 2003 03:35:55 +0100
Subject: [eclipse-devel] [Fwd: .o files of themes]
Message-ID: <3FB04B0B.6000803@labri.fr>



-------- Original Message --------
Subject: .o files of themes
Date: Sun, 9 Nov 2003 10:06:32 +0100
From: Robert STRANDH <strandh at labri.fr>
To: eclipse at lists.unlambda.com

Hello,

After compilation, `make install' fails because the theme.o files are
not in the right place.  It seems like the problem is here :

(defun compile-theme (directory-name)
   (let ((i-filespec (merge-pathnames "theme.lisp" directory-name))
	(o-filespec (merge-pathnames "theme.o")))

which I replaced with :

(defun compile-theme (directory-name)
   (let ((i-filespec (merge-pathnames "theme.lisp" directory-name))
	(o-filespec (merge-pathnames "theme.o" directory-name)))

which seems to work better.

-- 
Robert Strandh

---------------------------------------------------------------------
Greenspun's Tenth Rule of Programming: any sufficiently complicated C
or Fortran program contains an ad hoc informally-specified bug-ridden
slow implementation of half of Common Lisp.
---------------------------------------------------------------------
_______________________________________________
http://lists.unlambda.com/mailman/listinfo/eclipse




From christian.lynbech at ericsson.com  Tue Nov 11 09:56:58 2003
From: christian.lynbech at ericsson.com (Christian Lynbech)
Date: Tue, 11 Nov 2003 10:56:58 +0100
Subject: [eclipse-devel] [Fwd: .o files of themes]
In-Reply-To: <3FB04B0B.6000803@labri.fr> (Iban Hatchondo's message of "Tue,
	11 Nov 2003 03:35:55 +0100")
References: <3FB04B0B.6000803@labri.fr>
Message-ID: <ofu15b449h.fsf@situla.ted.dk.eu.ericsson.se>

I was a bit confused because installation works fine for me, but I
seemed to remember this problem, so I have digged a bit.

The function

    (defun compile-theme (directory-name)
      (let ((i-filespec (merge-pathnames "theme.lisp" directory-name))
            (o-filespec (merge-pathnames "theme.o")))
        (operate-on-system :eclipse :load)
        (load i-filespec)
        (compile-file i-filespec :output-file o-filespec)))

works, at least on CMUCL, because here `compile-file' will resolve the
pathname of :output-file in the directory of `i-filespec'. In fact,
just doing the fix suggested by Robert leads to the build failing on
CMUCL with the error:

    ; Loading #p"/n/knud/export/home/tedchly/init.lisp".
    ; Loading #p"/n/knud/export/home/tedchly/Tools/ANON-CVS/eclipse/system.lisp".
    ; Loading #p"/n/knud/export/home/tedchly/Tools/ANON-CVS/eclipse/themes/microGUI/theme.lisp".


    Error in function OPEN:
       Error creating #p"themes/microGUI/themes/microGUI/theme.o", path does not exist.


So I guess we need something like this:

    (defun compile-theme (directory-name)
      (let ((i-filespec (merge-pathnames "theme.lisp" directory-name))
            (o-filespec (merge-pathnames "theme.o" #-CMU directory-name)))
        (operate-on-system :eclipse :load)
        (load i-filespec)
        (compile-file i-filespec :output-file o-filespec)))



------------------------+-----------------------------------------------------
Christian Lynbech       | christian #\@ defun #\. dk
------------------------+-----------------------------------------------------
Hit the philistines three times over the head with the Elisp reference manual.
                                        - petonic at hal.com (Michael A. Petonic)



From hatchond at labri.fr  Tue Nov 11 11:44:27 2003
From: hatchond at labri.fr (Iban Hatchondo)
Date: Tue, 11 Nov 2003 12:44:27 +0100
Subject: [eclipse-devel] [Fwd: .o files of themes]
In-Reply-To: <ofu15b449h.fsf@situla.ted.dk.eu.ericsson.se>
References: <3FB04B0B.6000803@labri.fr>
	<ofu15b449h.fsf@situla.ted.dk.eu.ericsson.se>
Message-ID: <3FB0CB9B.1060003@labri.fr>

Christian Lynbech wrote:
> I was a bit confused because installation works fine for me, but I
> seemed to remember this problem, so I have digged a bit.
> 
> The function
> 
>     (defun compile-theme (directory-name)
>       (let ((i-filespec (merge-pathnames "theme.lisp" directory-name))
>             (o-filespec (merge-pathnames "theme.o")))
>         (operate-on-system :eclipse :load)
>         (load i-filespec)
>         (compile-file i-filespec :output-file o-filespec)))
> 
> works, at least on CMUCL, because here `compile-file' will resolve the
> pathname of :output-file in the directory of `i-filespec'. In fact,
> just doing the fix suggested by Robert leads to the build failing on
> CMUCL with the error:
> 
>     ; Loading #p"/n/knud/export/home/tedchly/init.lisp".
>     ; Loading #p"/n/knud/export/home/tedchly/Tools/ANON-CVS/eclipse/system.lisp".
>     ; Loading #p"/n/knud/export/home/tedchly/Tools/ANON-CVS/eclipse/themes/microGUI/theme.lisp".
> 
> 
>     Error in function OPEN:
>        Error creating #p"themes/microGUI/themes/microGUI/theme.o", path does not exist.
> 
> 
> So I guess we need something like this:
> 
>     (defun compile-theme (directory-name)
>       (let ((i-filespec (merge-pathnames "theme.lisp" directory-name))
>             (o-filespec (merge-pathnames "theme.o" #-CMU directory-name)))
>         (operate-on-system :eclipse :load)
>         (load i-filespec)
>         (compile-file i-filespec :output-file o-filespec)))

Yes I though to that but I think that if cmucl had that bug will find it 
another day. I propose:

(defun compile-theme (directory-name)
   (let* ((i-filespec (merge-pathnames "theme.lisp" directory-name))
	 (directory-truename (directory-namestring (truename i-filespec)))
  	 (o-filespec (merge-pathnames "theme.o" directory-truename)))
     (operate-on-system :eclipse :load)
     (load i-filespec)
     (compile-file i-filespec :output-file o-filespec)))

Any sugestions ?

Cheers,
Iban.




From christian.lynbech at ericsson.com  Tue Nov 11 12:45:47 2003
From: christian.lynbech at ericsson.com (Christian Lynbech)
Date: Tue, 11 Nov 2003 13:45:47 +0100
Subject: [eclipse-devel] [Fwd: .o files of themes]
In-Reply-To: <3FB0CB9B.1060003@labri.fr> (Iban Hatchondo's message of "Tue,
	11 Nov 2003 12:44:27 +0100")
References: <3FB04B0B.6000803@labri.fr>
	<ofu15b449h.fsf@situla.ted.dk.eu.ericsson.se>
	<3FB0CB9B.1060003@labri.fr>
Message-ID: <ofd6bz3wg4.fsf@situla.ted.dk.eu.ericsson.se>

>>>>> "Iban" == Iban Hatchondo <hatchond at labri.fr> writes:

Iban> (defun compile-theme (directory-name)
Iban>    (let* ((i-filespec (merge-pathnames "theme.lisp" directory-name))
Iban> 	 (directory-truename (directory-namestring (truename i-filespec)))
Iban>   	 (o-filespec (merge-pathnames "theme.o" directory-truename)))
Iban>      (operate-on-system :eclipse :load)
Iban>      (load i-filespec)
Iban>      (compile-file i-filespec :output-file o-filespec)))

I just tried it and it seems to work fine for me.

                             -- Christian