<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 2 Dec 2012, at 22:48, Juan Jose Garcia-Ripoll <<a href="mailto:juanjose.garciaripoll@gmail.com">juanjose.garciaripoll@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_extra">On Sun, Dec 2, 2012 at 9:11 PM, Pascal Costanza <span dir="ltr"><<a href="mailto:pc@p-cos.net" target="_blank">pc@p-cos.net</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>4) DEFMETHOD doesn't call MAKE-METHOD-LAMBDA to determine the method function body. [My guess is that this is not easy to change due to the deviation from the MOP specification in how method functions are called.]</div>
<div></div></blockquote></div><br>I will look into the other issues, but this is definitely not true. In ecl/src/clos/method.lsp, line 82, </div><div class="gmail_extra">...</div><div class="gmail_extra"><div class="gmail_extra">
<span class="" style="white-space:pre"> </span> (multiple-value-bind (fn-form options)</div><div class="gmail_extra"><span class="" style="white-space:pre"> </span> (make-method-lambda generic-function method lambda-form env)</div>
<div><span class="" style="white-space:pre"> </span> (when documentation</div><div><span class="" style="white-space:pre"> </span> (setf options (list* :documentation documentation options)))</div><div><span class="" style="white-space:pre"> </span> (multiple-value-bind (wrapped-lambda wrapped-p)</div>
<div><span class="" style="white-space:pre"> </span>(simplify-lambda name fn-form)</div><div>...</div><div><br></div><div>ECL calls make-method lambda and then looks at the output to see whether it can be transformed into the C-optimized dispatch that we use.</div>
<div><br></div><div>It would be important to have a test case that shows when make-method-lambda is not working. What in particular made you think so?</div></div><div class="gmail_extra"><br></div></blockquote></div><div><br></div><div><br></div><div>Here is a test case:</div><div><br></div><div><div>> (use-package :clos)</div><div><br></div><div>T</div><div>> (defclass my-generic-function (standard-generic-function) () (:metaclass funcallable-standard-class))</div><div><br></div><div>#<The CLOS:FUNCALLABLE-STANDARD-CLASS COMMON-LISP-USER::MY-GENERIC-FUNCTION></div><div>> (defgeneric f (x) (:generic-function-class my-generic-function))</div><div><br></div><div>#<my-generic-function F></div><div>> (defmethod make-method-lambda :after ((gf my-generic-function) (method standard-method) (lambda-expression t) (enviroment t)) (print :foo))</div><div><br></div><div>#<standard-method MAKE-METHOD-LAMBDA (#<The CLOS:FUNCALLABLE-STANDARD-CLASS COMMON-LISP-USER::MY-GENERIC-FUNCTION></div><div> #<The STANDARD-CLASS STANDARD-METHOD></div><div> #<The BUILT-IN-CLASS T></div><div> #<The BUILT-IN-CLASS T>)></div><div>> (defmethod f ((x integer)) (+ x x))</div><div><br></div><div>#<standard-method F (#<The BUILT-IN-CLASS INTEGER>)></div><div><br></div><div><br></div><div><br></div><div>Pascal</div></div><div><br></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px; "><div>--</div><div>Pascal Costanza</div><div><br></div></span><br class="Apple-interchange-newline">
</div>
<br></body></html>