[Ecls-list] Bug in configure/config.h.in?

Juan Jose Garcia-Ripoll juanjose.garciaripoll at googlemail.com
Wed Sep 9 07:34:38 UTC 2009


On Wed, Sep 9, 2009 at 2:58 AM, Raymond Toy<toy.raymond at gmail.com> wrote:
> When converted to config.h (on Solaris 8), we get:
>
> #   ifdef HAVE_COPYSIGN
> #    define signbit(x) (copysign(1.0,(x)) < 0)
> #   else
>     /* Fall back to no signed zero */
> #    define ECL_SIGNED_ZERO 1
> #    define signbit(x) ((x) < 0)
> #   endif
>
> Note that ECL_SIGNED_ZERO is set to 1.  This is inconsistent with the
> comment and with what appears to be the intent of config.h.in.  Perhaps
> it doesn't matter if you don't have HAVE_COPYSIGN, but defining
> ECL_SIGNED_ZERO with that signbit macro seems unlikely to work as desired.

You are right. Autoconf is trashing a perfectly fine #undef statement
that we set up. There are tricks to avoid this and I just committed
one. Hope it works.

But I am worried that current configure does not detect copysign, when
I added explicit tests for it :-/

Juanjo

-- 
Instituto de Física Fundamental, CSIC
c/ Serrano, 113b, Madrid 28006 (Spain)
http://juanjose.garciaripoll.googlepages.com




More information about the ecl-devel mailing list