From edi at agharta.de Sat Jul 10 10:06:11 2010 From: edi at agharta.de (Edi Weitz) Date: Sat, 10 Jul 2010 12:06:11 +0200 Subject: [drakma-devel] New Drakma release 1.2.2 Message-ID: There's a new release of Drakma out at weitz.de. This is a bugfix release. ChangeLog: http://weitz.de/drakma/CHANGELOG.txt From waltergr at aol.com Sun Jul 11 23:29:36 2010 From: waltergr at aol.com (Walter GR) Date: Sun, 11 Jul 2010 16:29:36 -0700 Subject: [drakma-devel] Patch: Unclosed node in doc/index.html Message-ID: <4C3A53E0.6030100@aol.com> Patch attached. An unclosed node in doc/index.html causes all text after the documentation for *allow-dotless-cookie-domains-p* to render in a monospaced font. This is my first patch ever, so let me know if I did it wrong. Thanks, Walter -- The Online Slang Dictionary - Now a wiki! http://onlineslangdictionary.com/ -------------- next part -------------- A non-text attachment was scrubbed... Name: drakma-doc.patch Type: text/x-patch Size: 617 bytes Desc: not available URL: From edi at agharta.de Mon Jul 12 20:46:54 2010 From: edi at agharta.de (Edi Weitz) Date: Mon, 12 Jul 2010 22:46:54 +0200 Subject: [drakma-devel] Patch: Unclosed node in doc/index.html In-Reply-To: <4C3A53E0.6030100@aol.com> References: <4C3A53E0.6030100@aol.com> Message-ID: Thanks for the patch, I've fixed this in the repository and on the website. Will be in the next release. (It seems, Firefox doesn't have a problem with this glitch, though.) On Mon, Jul 12, 2010 at 1:29 AM, Walter GR wrote: > Patch attached. > > An unclosed node in doc/index.html causes all text after the > documentation for *allow-dotless-cookie-domains-p* to render in a monospaced > font. > > This is my first patch ever, so let me know if I did it wrong. > > Thanks, > > Walter > > > -- > The Online Slang Dictionary - Now a wiki! > http://onlineslangdictionary.com/ > > _______________________________________________ > drakma-devel mailing list > drakma-devel at common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel > > From waltergr at aol.com Wed Jul 14 06:42:28 2010 From: waltergr at aol.com (Walter GR) Date: Tue, 13 Jul 2010 23:42:28 -0700 Subject: [drakma-devel] Patch: Unclosed node in doc/index.html In-Reply-To: References: <4C3A53E0.6030100@aol.com> Message-ID: <4C3D5C54.5000302@aol.com> > (It seems, Firefox doesn't have a problem with this glitch, though.) I was remiss in not mentioning: I'm using Chrome 5 on XP. Apple Safari uses the same rendering engine, but I don't have an installation handy to test on. Walter On 7/12/2010 1:46 PM, Edi Weitz wrote: > Thanks for the patch, I've fixed this in the repository and on the > website. Will be in the next release. > > (It seems, Firefox doesn't have a problem with this glitch, though.) > > On Mon, Jul 12, 2010 at 1:29 AM, Walter GR wrote: >> Patch attached. >> >> An unclosed node in doc/index.html causes all text after the >> documentation for *allow-dotless-cookie-domains-p* to render in a monospaced >> font. >> >> This is my first patch ever, so let me know if I did it wrong. >> >> Thanks, >> >> Walter >> >> >> -- >> The Online Slang Dictionary - Now a wiki! >> http://onlineslangdictionary.com/ From methanal at gmail.com Wed Jul 21 13:28:42 2010 From: methanal at gmail.com (Herbert Snorrason) Date: Wed, 21 Jul 2010 13:28:42 +0000 Subject: [drakma-devel] Regarding URL encoding... Message-ID: Although I understand why it's not done by default, it seems slightly odd to me that Drakma doesn't provide a URL-ENCODE function whereas Hunchentoot does. I would've thought the need was considerably more immediate in Drakma... With greetings, Herbert Snorrason From methanal at gmail.com Wed Jul 21 15:46:46 2010 From: methanal at gmail.com (Herbert Snorrason) Date: Wed, 21 Jul 2010 15:46:46 +0000 Subject: [drakma-devel] Regarding URL encoding... In-Reply-To: References: Message-ID: On 21 July 2010 13:28, Herbert Snorrason wrote: > [...] Drakma doesn't provide a URL-ENCODE function [...] And after thinking about it, turns out it _does_, just doesn't expose it. The thinking is, I presume, that all URL-encoded data should pass through another interface that handles the cleaning? In any case, the attached patch updates url-encode to RFC3986 (or at least only passes that standard's "unreserved characters" through) and exposes it. With greetings, Herbert Snorrason -------------- next part -------------- A non-text attachment was scrubbed... Name: url-encode.diff Type: text/x-diff Size: 2946 bytes Desc: not available URL: From tayloj at cs.rpi.edu Wed Jul 21 16:24:41 2010 From: tayloj at cs.rpi.edu (Joshua TAYLOR) Date: Wed, 21 Jul 2010 12:24:41 -0400 Subject: [drakma-devel] Regarding URL encoding... In-Reply-To: References: Message-ID: On Wed, Jul 21, 2010 at 11:46 AM, Herbert Snorrason wrote: > In any case, the attached patch updates url-encode to RFC3986 (or at > least only passes that standard's "unreserved characters" through) and > exposes it. I suspect that the original portions of - (find char "$-_.!*'()," :test #'char=)) + (find char "-_.~" :test #'char=)) (write-char char out)) - ((char= char #\Space) - (write-char #\+ out)) are based on RFC 1738's more restricted list of characters: Thus, only alphanumerics, the special characters "$-_.+!*'(),", and reserved characters used for their reserved purposes may be used unencoded within a URL. [1] Since request parameters (which could include URIs) might appear in the HTTP request's URL, the parameters need to be URL encoded, not just composed of valid URI characters. [1] http://www.rfc-editor.org/rfc/rfc1738.txt //JT -- Joshua Taylor, http://www.cs.rpi.edu/~tayloj/ From vseloved at gmail.com Thu Jul 29 09:22:55 2010 From: vseloved at gmail.com (Vsevolod Dyomkin) Date: Thu, 29 Jul 2010 12:22:55 +0300 Subject: [drakma-devel] duplicate cookies problem with proposed patch Message-ID: Hi, I want to re-raise the topic of duplicate cookies. I've had this issue with the older version of Drakma (1.1.0) and was unaware of the patch with *remove-duplicate-cookies-p*. But investigating the problem (before I've read the discussion in the mailing list), I've encountered it's cause in the source code, that is highlighted in the attached diff. The problem is, that SET-DIFFERENCE and UNION are not supplied COOKIE= tests in UPDATE-COOKIES. It still remains in the current version (1.2.2) and can be tested like this: CL-USER> (defvar *cookies* (make-instance 'drakma:cookie-jar)) *COOKIES* CL-USER> (drakma::update-cookies (list (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/") (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/")) *cookies*) # I think, that this is a bug, because without the TEST argument, for example, SET-DIFFERENCE in this case will constantly return the first set (see below), so either the code should be simplified or the test argument should be added. CL-USER> (set-difference (list (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/") (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/")) (list (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/") (make-instance 'drakma:cookie :name "lang" :value "en" :domain "site.com" :path "/"))) (# #) So, I believe, that this part should also be fixed, especially, since UPDATE-COOKIES is called alongside with GET-COOKIES. Best regards, Vsevolod -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: cookies.diff Type: text/x-patch Size: 563 bytes Desc: not available URL: