[cxml-devel] Patch: Add XMLS support for including the namespace URI in the element and attribute names.

[Douglas Crosher]

David Lichteblau wrote:
> Quoting Douglas Crosher (dtc at scieneer.com):
>> o Add support for including the namespace URI in the element and
>>   attribute names.

Thank you committing these changes and for enhancing it further.

...
>> +              when (and (or (sax:attribute-specified-p attr)
>> +			    include-default-values)
>> +			(or (not include-namespace-uri)
>> +			    (not attr-namespace-uri)
>> +			    attr-local-name))
> 
> What is the (or ..) test for?  IIUC, it currently removes declarations
> for the default namespace (xmlns="a") but not declarations for other
> namespaces (xmlns:b="a").  If removal of namespace declarations was the
> idea of this test, it should probably affect all of them, but only if
> *include-xmlns-attributes* is false.
> 
> Applied without the OR.

Yes this was intended to just remove the default namespace attribute, with an attribute
local-name of 'nil.  Dropping this test does look like the right thing to do
as the attribute will be needed when serializing, and *include-xmlns-attributes*
can be set to false to avoid them.  Cleanup patch attached.

Regards
Douglas Crosher

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch-xmls2
URL: <https://mailman.common-lisp.net/pipermail/cxml-devel/attachments/20070617/501ddfca/attachment.ksh>