<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Raymond Toy pushed to branch master
at <a href="https://gitlab.common-lisp.net/cmucl/cmucl">cmucl / cmucl</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/755f7a806f5fb5369563985e5ca00d934f885822">755f7a80</a></strong>
<div>
<span>by Raymond Toy</span>
<i>at 2021-01-11T20:05:32-08:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix #98: Use FSTP instruction with appropriate size
Instead of printing `FSTP` and `FSTPD`, print `FSTP DWORD PTR` and
`FSTP QWORD PTR` to store a single-float and double-float value to
memory.
Clang likes this form better than the original, but gcc accepts both.
</pre>
</li>
<li>
<strong><a href="https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9c0c857dd10067e1cf90ec577a79eb79593c3250">9c0c857d</a></strong>
<div>
<span>by Raymond Toy</span>
<i>at 2021-01-12T04:27:13+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Merge branch 'issue-98-fstpd-formatting' into 'master'
Fix #98: Use FSTP instruction with appropriate size
Closes #98
See merge request cmucl/cmucl!65</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class="file-stats">
<a href="#2a6bca7a142015890af48e53d45089058f833609">
src/compiler/x86/insts.lisp
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id="2a6bca7a142015890af48e53d45089058f833609">
<a href="https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5e87a39ad45b1dde4d565a4aa4273d5fb9c4e113...9c0c857dd10067e1cf90ec577a79eb79593c3250#2a6bca7a142015890af48e53d45089058f833609"><strong>src/compiler/x86/insts.lisp</strong></a>
<hr>
<table class="code white" style="font-family: monospace; font-size: 90%;" bgcolor="#fff" width="100%" cellpadding="0" cellspacing="0">
<tr class="line_holder match" id="" style="line-height: 1.6;">
<td class="diff-line-num unfold js-unfold old_line" data-linenumber="2636" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="diff-line-num unfold js-unfold new_line" data-linenumber="2636" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="line_content match " style="padding-left: 0.5em; padding-right: 0.5em; color: rgba(0,0,0,0.3);" bgcolor="#fafafa">@@ -2636,7 +2636,8 @@</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2636" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2636
</td>
<td class="diff-line-num new_line" data-linenumber="2636" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2636
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2636" class="line" lang="common_lisp"><span class="c1" style="color: #998; font-style: italic;">;;; store single from st(0) and pop</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2637" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2637
</td>
<td class="diff-line-num new_line" data-linenumber="2637" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2637
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2637" class="line" lang="common_lisp"><span class="c1" style="color: #998; font-style: italic;">;;;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2638" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2638
</td>
<td class="diff-line-num new_line" data-linenumber="2638" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2638
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2638" class="line" lang="common_lisp"><span class="p">(</span><span class="nv" style="color: #008080;">define-instruction</span> <span class="nv" style="color: #008080;">fstp</span> <span class="p">(</span><span class="nv" style="color: #008080;">segment</span> <span class="nv" style="color: #008080;">dest</span><span class="p">)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="" style="line-height: 1.6;">
<td class="diff-line-num old old_line" data-linenumber="2639" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
2639
</td>
<td class="diff-line-num new_line old" data-linenumber="2639" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC2639" class="line" lang="common_lisp"> <span class="p">(</span><span class="ss" style="color: #990073;">:printer</span> <span class="nv" style="color: #008080;">floating-point</span> <span class="p">((</span><span class="nv" style="color: #008080;">op</span> <span class="o" style="font-weight: 600;">'</span><span class="p">(</span><span class="m" style="color: #099;">#b001</span> <span class="m" style="color: #099;">#b011</span><span class="p">))))</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="2640" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="2639" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
2639
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC2639" class="line" lang="common_lisp"> <span class="p">(</span><span class="ss" style="color: #990073;">:printer</span> <span class="nv" style="color: #008080;">floating-point</span> <span class="p">((</span><span class="nv" style="color: #008080;">op</span> <span class="o" style="font-weight: 600;">'</span><span class="p">(</span><span class="m" style="color: #099;">#b001</span> <span class="m" style="color: #099;">#b011</span><span class="p">)))</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="2640" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="2640" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
2640
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC2640" class="line" lang="common_lisp"> <span class="o" style="font-weight: 600;">'</span><span class="p">(</span><span class="ss" style="color: #990073;">'fstp</span> <span class="ss" style="color: #990073;">:tab</span> <span class="ss" style="color: #990073;">'dword</span> <span class="s" style="color: #d14;">" "</span> <span class="ss" style="color: #990073;">'ptr</span> <span class="s" style="color: #d14;">" "</span> <span class="nv" style="color: #008080;">reg/mem</span><span class="p">))</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2640" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2640
</td>
<td class="diff-line-num new_line" data-linenumber="2641" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2641
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2641" class="line" lang="common_lisp"> <span class="p">(</span><span class="ss" style="color: #990073;">:emitter</span> </span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2641" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2641
</td>
<td class="diff-line-num new_line" data-linenumber="2642" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2642
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2642" class="line" lang="common_lisp"> <span class="p">(</span><span class="nb" style="color: #0086b3;">cond</span> <span class="p">((</span><span class="nv" style="color: #008080;">fp-reg-tn-p</span> <span class="nv" style="color: #008080;">dest</span><span class="p">)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2642" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2642
</td>
<td class="diff-line-num new_line" data-linenumber="2643" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2643
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2643" class="line" lang="common_lisp"> <span class="p">(</span><span class="nv" style="color: #008080;">emit-byte</span> <span class="nv" style="color: #008080;">segment</span> <span class="m" style="color: #099;">#b11011101</span><span class="p">)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder match" id="" style="line-height: 1.6;">
<td class="diff-line-num unfold js-unfold old_line" data-linenumber="2648" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="diff-line-num unfold js-unfold new_line" data-linenumber="2649" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="line_content match " style="padding-left: 0.5em; padding-right: 0.5em; color: rgba(0,0,0,0.3);" bgcolor="#fafafa">@@ -2648,7 +2649,8 @@</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2648" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2648
</td>
<td class="diff-line-num new_line" data-linenumber="2649" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2649
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2649" class="line" lang="common_lisp"><span class="c1" style="color: #998; font-style: italic;">;;; store double from st(0) and pop</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2649" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2649
</td>
<td class="diff-line-num new_line" data-linenumber="2650" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2650
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2650" class="line" lang="common_lisp"><span class="c1" style="color: #998; font-style: italic;">;;;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2650" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2650
</td>
<td class="diff-line-num new_line" data-linenumber="2651" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2651
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2651" class="line" lang="common_lisp"><span class="p">(</span><span class="nv" style="color: #008080;">define-instruction</span> <span class="nv" style="color: #008080;">fstpd</span> <span class="p">(</span><span class="nv" style="color: #008080;">segment</span> <span class="nv" style="color: #008080;">dest</span><span class="p">)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="" style="line-height: 1.6;">
<td class="diff-line-num old old_line" data-linenumber="2651" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
2651
</td>
<td class="diff-line-num new_line old" data-linenumber="2652" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC2651" class="line" lang="common_lisp"> <span class="p">(</span><span class="ss" style="color: #990073;">:printer</span> <span class="nv" style="color: #008080;">floating-point</span> <span class="p">((</span><span class="nv" style="color: #008080;">op</span> <span class="o" style="font-weight: 600;">'</span><span class="p">(</span><span class="m" style="color: #099;">#b101</span> <span class="m" style="color: #099;">#b011</span><span class="p">))))</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="2652" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="2652" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
2652
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC2652" class="line" lang="common_lisp"> <span class="p">(</span><span class="ss" style="color: #990073;">:printer</span> <span class="nv" style="color: #008080;">floating-point</span> <span class="p">((</span><span class="nv" style="color: #008080;">op</span> <span class="o" style="font-weight: 600;">'</span><span class="p">(</span><span class="m" style="color: #099;">#b101</span> <span class="m" style="color: #099;">#b011</span><span class="p">)))</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="2652" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="2653" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
2653
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC2653" class="line" lang="common_lisp"> <span class="o" style="font-weight: 600;">'</span><span class="p">(</span><span class="ss" style="color: #990073;">'fstp</span> <span class="ss" style="color: #990073;">:tab</span> <span class="ss" style="color: #990073;">'qword</span> <span class="s" style="color: #d14;">" "</span> <span class="ss" style="color: #990073;">'ptr</span> <span class="s" style="color: #d14;">" "</span> <span class="nv" style="color: #008080;">reg/mem</span><span class="p">))</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2652" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2652
</td>
<td class="diff-line-num new_line" data-linenumber="2654" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2654
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2654" class="line" lang="common_lisp"> <span class="p">(</span><span class="ss" style="color: #990073;">:printer</span> <span class="nv" style="color: #008080;">floating-point-fp</span> <span class="p">((</span><span class="nv" style="color: #008080;">op</span> <span class="o" style="font-weight: 600;">'</span><span class="p">(</span><span class="m" style="color: #099;">#b101</span> <span class="m" style="color: #099;">#b011</span><span class="p">))))</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2653" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2653
</td>
<td class="diff-line-num new_line" data-linenumber="2655" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2655
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2655" class="line" lang="common_lisp"> <span class="p">(</span><span class="ss" style="color: #990073;">:emitter</span> </span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="2654" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2654
</td>
<td class="diff-line-num new_line" data-linenumber="2656" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
2656
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC2656" class="line" lang="common_lisp"> <span class="p">(</span><span class="nb" style="color: #0086b3;">cond</span> <span class="p">((</span><span class="nv" style="color: #008080;">fp-reg-tn-p</span> <span class="nv" style="color: #008080;">dest</span><span class="p">)</span></span>
</pre>
</td>
</tr>
</table>
<br>
</li>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
<a href="https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5e87a39ad45b1dde4d565a4aa4273d5fb9c4e113...9c0c857dd10067e1cf90ec577a79eb79593c3250">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.common-lisp.net.
If you'd like to receive fewer emails, you can
adjust your notification settings.
</p>
</div>
</body>
</html>