<html lang='en'>
<head>
<meta content='text/html; charset=utf-8' http-equiv='Content-Type'>
<title>
GitLab
</title>
</meta>
</head>
<style>
img {
max-width: 100%;
height: auto;
}
p.details {
font-style:italic;
color:#777
}
.footer p {
font-size:small;
color:#777
}
pre.commit-message {
white-space: pre-wrap;
}
.file-stats a {
text-decoration: none;
}
.file-stats .new-file {
color: #090;
}
.file-stats .deleted-file {
color: #B00;
}
</style>
<body>
<div class='content'>
<h3>
Raymond Toy pushed to branch master
at <a href="https://gitlab.common-lisp.net/cmucl/cmucl">cmucl / cmucl</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/351351dfc04be5578dc76650c82f501ae704db28">351351df</a></strong>
<div>
<span>by Raymond Toy</span>
<i>at 2016-01-17T23:53:43Z</i>
</div>
<pre class='commit-message'>Simplify bignum-shld and bignum-shrd vops.
One temp variable for bignum-shld can be removed and the only temp
variable for bignum-shld-c can be removed. Base this on the
digit-ashr vops. This makes the vops simpler and faster.</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class='file-stats'>
<a href='#diff-0'>
src/compiler/x86/arith.lisp
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id='diff-0'>
<a href='https://gitlab.common-lisp.net/cmucl/cmucl/commit/351351dfc04be5578dc76650c82f501ae704db28#diff-0'>
<strong>
src/compiler/x86/arith.lisp
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/src/compiler/x86/arith.lisp
</span><span style="color: #000000;background-color: #ddffdd">+++ b/src/compiler/x86/arith.lisp
</span><span style="color: #aaaaaa">@@ -1583,80 +1583,48 @@
</span> (define-vop (bignum-shld)
(:policy :fast-safe)
(:translate bignum::%shld)
<span style="color: #000000;background-color: #ffdddd">- (:args (x :scs (unsigned-reg) :target r)
- (shift-in :scs (unsigned-reg))
</span><span style="color: #000000;background-color: #ddffdd">+ (:args (x :scs (unsigned-reg unsigned-stack) :target r)
+ (shift-in :scs (unsigned-reg) :to :result)
</span> (amount :scs (unsigned-reg) :target cl))
(:arg-types unsigned-num unsigned-num unsigned-num)
<span style="color: #000000;background-color: #ffdddd">- (:results (r :scs (unsigned-reg)))
</span><span style="color: #000000;background-color: #ddffdd">+ (:results (r :scs (unsigned-reg)
+ :load-if (not (and (sc-is r unsigned-stack)
+ (location= x r)))))
</span> (:result-types unsigned-num)
<span style="color: #000000;background-color: #ffdddd">- (:temporary (:sc unsigned-reg :from (:argument 0) :to (:result 0)) temp)
</span> (:temporary (:sc unsigned-reg :offset ecx-offset
<span style="color: #000000;background-color: #ffdddd">- :from (:argument 2) :to (:result 0)) cl)
- (:generator 4
</span><span style="color: #000000;background-color: #ddffdd">+ :from (:argument 2)) cl)
+ (:generator 3
</span> (move cl amount)
<span style="color: #000000;background-color: #ffdddd">- (cond ((location= x r)
- (inst shld x shift-in :cl))
- (t
- (move temp x)
- (inst shld temp shift-in :cl)
- (move r temp)))))
</span><span style="color: #000000;background-color: #ddffdd">+ (move r x)
+ (inst shld r shift-in :cl)))
</span>
(define-vop (bignum-shld-c)
(:policy :fast-safe)
(:translate bignum::%shld)
<span style="color: #000000;background-color: #ffdddd">- (:args (x :scs (unsigned-reg) :target r)
- (shift-in :scs (unsigned-reg)))
</span><span style="color: #000000;background-color: #ddffdd">+ (:args (x :scs (unsigned-reg unsigned-stack) :target r)
+ (shift-in :scs (unsigned-reg) :to :save))
</span> (:info shift)
(:arg-types unsigned-num unsigned-num (:constant (unsigned-byte 5)))
<span style="color: #000000;background-color: #ffdddd">- (:results (r :scs (unsigned-reg)))
</span><span style="color: #000000;background-color: #ddffdd">+ (:results (r :scs (unsigned-reg)
+ :load-if (not (and (sc-is r unsigned-stack)
+ (location= x r)))))
</span> (:result-types unsigned-num)
<span style="color: #000000;background-color: #ffdddd">- (:temporary (:sc unsigned-reg :from (:argument 0) :to (:result 0)) temp)
- (:generator 3
- (cond ((location= x r)
- (inst shld x shift-in shift))
- (t
- (move temp x)
- (inst shld temp shift-in shift)
- (move r temp)))))
</span><span style="color: #000000;background-color: #ddffdd">+ (:generator 2
+ (move r x)
+ (inst shld r shift-in shift)))
</span>
<span style="color: #000000;background-color: #ffdddd">-(define-vop (bignum-shrd)
- (:policy :fast-safe)
</span><span style="color: #000000;background-color: #ddffdd">+(define-vop (bignum-shrd bignum-shld)
</span> (:translate bignum::%shrd)
<span style="color: #000000;background-color: #ffdddd">- (:args (x :scs (unsigned-reg) :target r)
- (shift-in :scs (unsigned-reg))
- (amount :scs (unsigned-reg) :target cl))
- (:arg-types unsigned-num unsigned-num unsigned-num)
- (:results (r :scs (unsigned-reg)))
- (:result-types unsigned-num)
- (:temporary (:sc unsigned-reg :from (:argument 0) :to (:result 0)) temp)
- (:temporary (:sc unsigned-reg :offset ecx-offset
- :from (:argument 2) :to (:result 0)) cl)
- (:generator 4
</span><span style="color: #000000;background-color: #ddffdd">+ (:generator 3
</span> (move cl amount)
<span style="color: #000000;background-color: #ffdddd">- (cond ((location= x r)
- (inst shrd x shift-in :cl))
- (t
- (move temp x)
- (inst shrd temp shift-in :cl)
- (move r temp)))))
</span><span style="color: #000000;background-color: #ddffdd">+ (move r x)
+ (inst shrd r shift-in :cl)))
</span>
<span style="color: #000000;background-color: #ffdddd">-(define-vop (bignum-shrd-c)
- (:policy :fast-safe)
</span><span style="color: #000000;background-color: #ddffdd">+(define-vop (bignum-shrd-c bignum-shld-c)
</span> (:translate bignum::%shrd)
<span style="color: #000000;background-color: #ffdddd">- (:args (x :scs (unsigned-reg))
- (shift-in :scs (unsigned-reg)))
- (:info shift)
- (:arg-types unsigned-num unsigned-num (:constant (unsigned-byte 5)))
- (:results (r :scs (unsigned-reg)))
- (:result-types unsigned-num)
- (:temporary (:sc unsigned-reg :from (:argument 0) :to (:result 0)) temp)
- (:generator 3
- (cond ((location= x r)
- (inst shrd x shift-in shift))
- (t
- (move temp x)
- (inst shrd temp shift-in shift)
- (move r temp)))))
</span><span style="color: #000000;background-color: #ddffdd">+ (:generator 2
+ (move r x)
+ (inst shrd r shift-in shift)))
</span>
</code></pre>
<br>
</li>
</div>
<div class='footer' style='margin-top: 10px;'>
<p>
—
<br>
<a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/351351dfc04be5578dc76650c82f501ae704db28">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.common-lisp.net.
If you'd like to receive fewer emails, you can adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://gitlab.common-lisp.net/cmucl/cmucl/commit/351351dfc04be5578dc76650c82f501ae704db28"}}</script>
</p>
</div>
</body>
</html>