<html lang='en'>
<head>
<meta content='text/html; charset=utf-8' http-equiv='Content-Type'>
<title>
GitLab
</title>
</meta>
</head>
<style>
img {
max-width: 100%;
height: auto;
}
p.details {
font-style:italic;
color:#777
}
.footer p {
font-size:small;
color:#777
}
pre.commit-message {
white-space: pre-wrap;
}
.file-stats a {
text-decoration: none;
}
.file-stats .new-file {
color: #090;
}
.file-stats .deleted-file {
color: #B00;
}
</style>
<body>
<div class='content'>
<h3>
Raymond Toy pushed to branch master
at <a href="https://gitlab.common-lisp.net/cmucl/cmucl">cmucl / cmucl</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/8058d410e86a77a6839d4c4228e03aae9cb70d2f">8058d410</a></strong>
<div>
<span>by Raymond Toy</span>
<i>at 2016-01-16T13:01:37Z</i>
</div>
<pre class='commit-message'>Fix up shld/shrd instructions.
o Need to define a new instruction format for these double shifts;
they look like ext-reg-reg/mem but there's no width field.
o Clean up emit-double-shift slightly.
o Update double-shift-inst-printer-list to support both immediate
shift or shifts in CL.</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class='file-stats'>
<a href='#diff-0'>
src/compiler/x86/insts.lisp
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id='diff-0'>
<a href='https://gitlab.common-lisp.net/cmucl/cmucl/commit/8058d410e86a77a6839d4c4228e03aae9cb70d2f#diff-0'>
<strong>
src/compiler/x86/insts.lisp
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/src/compiler/x86/insts.lisp
</span><span style="color: #000000;background-color: #ddffdd">+++ b/src/compiler/x86/insts.lisp
</span><span style="color: #aaaaaa">@@ -859,6 +859,18 @@
</span> ;; optional fields
(imm))
<span style="color: #000000;background-color: #ddffdd">+;; Double shift instructions. Like ext-reg-reg/mem but there's no
+;; width field.
+(disassem:define-instruction-format (ext-reg-reg/mem-shift 24)
+ (prefix :field (byte 8 0) :value #b00001111)
+ (op :field (byte 8 8))
+ (reg/mem :fields (list (byte 2 22) (byte 3 16))
+ :type 'reg/mem)
+ (reg :field (byte 3 19) :type 'reg)
+ ;; optional fields
+ (imm))
+
+
</span> ;;; ----------------------------------------------------------------
;;; this section added by jrd, for fp instructions.
<span style="color: #aaaaaa">@@ -1535,24 +1547,22 @@
</span> (defun emit-double-shift (segment opcode dst src amt)
(let ((size (matching-operand-size dst src)))
(when (eq size :byte)
<span style="color: #000000;background-color: #ffdddd">- (error "Double shifts can only be used with words."))
</span><span style="color: #000000;background-color: #ddffdd">+ (error "Double shifts cannot be used with byte registers."))
</span> (maybe-emit-operand-size-prefix segment size)
(emit-byte segment #b00001111)
(emit-byte segment (dpb opcode (byte 1 3)
(if (eq amt :cl) #b10100101 #b10100100)))
<span style="color: #000000;background-color: #ffdddd">- #+nil
- (emit-ea segment dst src)
- (emit-ea segment dst (reg-tn-encoding src)) ; pw tries this
</span><span style="color: #000000;background-color: #ddffdd">+ (emit-ea segment dst (reg-tn-encoding src))
</span> (unless (eq amt :cl)
(emit-byte segment amt))))
(eval-when (compile eval)
(defun double-shift-inst-printer-list (op)
<span style="color: #000000;background-color: #ffdddd">- `(#+nil
- (ext-reg-reg/mem-imm ((op ,(logior op #b100))
- (imm nil :type signed-imm-byte)))
- (ext-reg-reg/mem ((op ,(logior op #b101)))
- (:name :tab reg/mem ", " 'cl)))))
</span><span style="color: #000000;background-color: #ddffdd">+ `((ext-reg-reg/mem-shift ((op ,(logior op #b100))
+ (imm nil :type signed-imm-byte))
+ (:name :tab reg/mem ", " reg ", " imm))
+ (ext-reg-reg/mem-shift ((op ,(logior op #b101)))
+ (:name :tab reg/mem ", " reg ", " 'cl)))))
</span>
(define-instruction shld (segment dst src amt)
(:declare (type (or (member :cl) (mod 32)) amt))
</code></pre>
<br>
</li>
</div>
<div class='footer' style='margin-top: 10px;'>
<p>
—
<br>
<a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/8058d410e86a77a6839d4c4228e03aae9cb70d2f">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.common-lisp.net.
If you'd like to receive fewer emails, you can adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://gitlab.common-lisp.net/cmucl/cmucl/commit/8058d410e86a77a6839d4c4228e03aae9cb70d2f"}}</script>
</p>
</div>
</body>
</html>