<html lang='en'>
<head>
<meta content='text/html; charset=utf-8' http-equiv='Content-Type'>
<title>
GitLab
</title>
</meta>
</head>
<style>
  img {
    max-width: 100%;
    height: auto;
  }
  p.details {
    font-style:italic;
    color:#777
  }
  .footer p {
    font-size:small;
    color:#777
  }
  pre.commit-message {
    white-space: pre-wrap;
  }
  .file-stats a {
    text-decoration: none;
  }
  .file-stats .new-file {
    color: #090;
  }
  .file-stats .deleted-file {
    color: #B00;
  }
</style>
<body>
<div class='content'>
<h3>Raymond Toy pushed to branch rtoy-setexception-inexact at <a href="https://gitlab.common-lisp.net/cmucl/cmucl">cmucl / cmucl</a></h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/38e8ce5c1084e1c55f90028829c7491a47909835">38e8ce5c</a></strong>
<div>
<span>by Raymond Toy</span>
<i>at 2015-12-26T09:09:56Z</i>
</div>
<pre class='commit-message'>Fix bug on sparc and clean up.

On sparc and ppc (setf vm:floating-point-modes) takes an
(unsigned-byte 32) arg, so adjust the ldb byte appopriately. 

Clean up code by putting the docstring into the macro.</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class='file-stats'>
<a href='#diff-0'>
src/code/float-trap.lisp
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id='diff-0'>
<a href='https://gitlab.common-lisp.net/cmucl/cmucl/commit/38e8ce5c1084e1c55f90028829c7491a47909835#diff-0'>
<strong>
src/code/float-trap.lisp
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/src/code/float-trap.lisp
</span><span style="color: #000000;background-color: #ddffdd">+++ b/src/code/float-trap.lisp
</span><span style="color: #aaaaaa">@@ -374,6 +374,7 @@
</span>        (let ((macro-name (symbolicate "WITH-FLOAT-TRAPS-" name)))
         `(progn
            (defmacro ,macro-name (traps &body body)
<span style="color: #000000;background-color: #ddffdd">+              ,docstring
</span>         (let ((traps (dpb (float-trap-mask traps) float-traps-byte 0))
                    (exceptions (dpb (float-trap-mask traps) float-sticky-bits 0))
                    (trap-mask (dpb (lognot (float-trap-mask traps))
<span style="color: #aaaaaa">@@ -397,7 +398,9 @@
</span>              (unwind-protect
                        (progn
                          (setf (floating-point-modes)
<span style="color: #000000;background-color: #ffdddd">-                                (ldb (byte 24 0)
</span><span style="color: #000000;background-color: #ddffdd">+                           (ldb (byte #+x86 24
+                                          #-x86 32
+                                          0)
</span>                                (,',logical-op ,orig-modes ,(logand trap-mask exception-mask))))
                          ,@body)
                     ;; Restore the original traps and exceptions.
<span style="color: #aaaaaa">@@ -407,25 +410,22 @@
</span>                                      ,(logand trap-mask exception-mask)
                                           #+ppc
                                           ,invalid-mask
<span style="color: #000000;background-color: #ffdddd">-                                           #+mips ,(dpb 0 float-exceptions-byte #xffffffff))))))))
-           ;; Set the docstring appropriately 
-           (setf (c::info function documentation ',macro-name)
-                 ,docstring)))))
</span><span style="color: #000000;background-color: #ddffdd">+                                      #+mips ,(dpb 0 float-exceptions-byte #xffffffff))))))))))))
</span>   ;; Masked and Enabled only differ whether we AND in the bits or OR
   ;; them.
   (with-float-traps masked logand
<span style="color: #000000;background-color: #ffdddd">-              "Execute BODY with the floating point exceptions listed in TRAPS
-  disabled.  TRAPS should be a list of possible exceptions which
-  includes :UNDERFLOW, :OVERFLOW, :INEXACT, :INVALID and
</span><span style="color: #000000;background-color: #ddffdd">+    _N"Execute BODY with the floating point exceptions listed in TRAPS
+  masked (disabled).  TRAPS should be a list of possible exceptions
+  which includes :UNDERFLOW, :OVERFLOW, :INEXACT, :INVALID and
</span>   :DIVIDE-BY-ZERO and on the X86 :DENORMALIZED-OPERAND. The respective
   accrued exceptions are cleared at the start of the body to support
   their testing within, and restored on exit.")
<span style="color: #000000;background-color: #ddffdd">+
</span>   (with-float-traps enabled logorc2
<span style="color: #000000;background-color: #ffdddd">-              "Execute BODY with the floating point exceptions listed in TRAPS
</span><span style="color: #000000;background-color: #ddffdd">+    _N"Execute BODY with the floating point exceptions listed in TRAPS
</span>   enabled.  TRAPS should be a list of possible exceptions which
   includes :UNDERFLOW, :OVERFLOW, :INEXACT, :INVALID and
   :DIVIDE-BY-ZERO and on the X86 :DENORMALIZED-OPERAND. The respective
   accrued exceptions are cleared at the start of the body to support
   their testing within, and restored on exit."))
<span style="color: #000000;background-color: #ffdddd">-;; Set up the appropriate documentation for these macros
</span> 
</code></pre>

<br>
</li>

</div>
<div class='footer' style='margin-top: 10px;'>
<p>

<br>
<a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/38e8ce5c1084e1c55f90028829c7491a47909835">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.common-lisp.net.
If you'd like to receive fewer emails, you can adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://gitlab.common-lisp.net/cmucl/cmucl/commit/38e8ce5c1084e1c55f90028829c7491a47909835"}}</script>
</p>
</div>
</body>
</html>