<html lang='en'>
<head>
<meta content='text/html; charset=utf-8' http-equiv='Content-Type'>
<title>
GitLab
</title>
</meta>
</head>
<style>
img {
max-width: 100%;
height: auto;
}
p.details {
font-style:italic;
color:#777
}
.footer p {
font-size:small;
color:#777
}
pre.commit-message {
white-space: pre-wrap;
}
.file-stats a {
text-decoration: none;
}
.file-stats .new-file {
color: #090;
}
.file-stats .deleted-file {
color: #B00;
}
</style>
<body>
<div class='content'>
<h3>Raymond Toy pushed to branch rtoy-mmap-anon-control-and-binding-stacks at <a href="https://gitlab.common-lisp.net/cmucl/cmucl">cmucl / cmucl</a></h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/57a7df1370263128a2dc17c914ac4016e632de74">57a7df13</a></strong>
<div>
<span>by Raymond Toy</span>
<i>at 2015-10-03T14:10:24Z</i>
</div>
<pre class='commit-message'>Replace CONTROL_STACK_START with control_stack.
Cast to appropriate pointer types too.</pre>
</li>
<li>
<strong><a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/e0ae3367a22d62843408f370160770b66bb38f78">e0ae3367</a></strong>
<div>
<span>by Raymond Toy</span>
<i>at 2015-10-03T14:11:08Z</i>
</div>
<pre class='commit-message'>Replace CONTROL_STACK_START with control_stack and BINDING_STACK_START
with binding_stack.</pre>
</li>
<li>
<strong><a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/748991e2930768ddc28e468a647b8dcbdf8f7341">748991e2</a></strong>
<div>
<span>by Raymond Toy</span>
<i>at 2015-10-03T14:11:33Z</i>
</div>
<pre class='commit-message'>Cast os_validate to the appropriate type to get rid of warning.</pre>
</li>
<li>
<strong><a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/e4897224933bfcdaf64888f51c0f3e03fd074748">e4897224</a></strong>
<div>
<span>by Raymond Toy</span>
<i>at 2015-10-03T14:11:43Z</i>
</div>
<pre class='commit-message'>Declare validate_stacks().</pre>
</li>
</ul>
<h4>4 changed files:</h4>
<ul>
<li class='file-stats'>
<a href='#diff-0'>
src/lisp/backtrace.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-1'>
src/lisp/solaris-os.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-2'>
src/lisp/validate.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-3'>
src/lisp/validate.h
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id='diff-0'>
<a href='https://gitlab.common-lisp.net/cmucl/cmucl/compare/65b5ed7715ded275fd4d360eab85df7c5357769d...e4897224933bfcdaf64888f51c0f3e03fd074748#diff-0'>
<strong>
src/lisp/backtrace.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/src/lisp/backtrace.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/src/lisp/backtrace.c
</span><span style="color: #aaaaaa">@@ -252,7 +252,7 @@ backtrace(int nframes)
</span> static int
stack_pointer_p(unsigned long p)
{
<span style="color: #000000;background-color: #ffdddd">- return (p < CONTROL_STACK_START + control_stack_size
</span><span style="color: #000000;background-color: #ddffdd">+ return ((void *)p < (void *)control_stack + control_stack_size
</span> && p > (unsigned long) &p && (p & 3) == 0);
}
</code></pre>
<br>
</li>
<li id='diff-1'>
<a href='https://gitlab.common-lisp.net/cmucl/cmucl/compare/65b5ed7715ded275fd4d360eab85df7c5357769d...e4897224933bfcdaf64888f51c0f3e03fd074748#diff-1'>
<strong>
src/lisp/solaris-os.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/src/lisp/solaris-os.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/src/lisp/solaris-os.c
</span><span style="color: #aaaaaa">@@ -199,8 +199,8 @@ boolean valid_addr(os_vm_address_t addr)
</span> #ifndef GENCGC
|| in_range_p(addr, DYNAMIC_1_SPACE_START, dynamic_space_size)
#endif
<span style="color: #000000;background-color: #ffdddd">- || in_range_p(addr, CONTROL_STACK_START, control_stack_size)
- || in_range_p(addr, BINDING_STACK_START, binding_stack_size));
</span><span style="color: #000000;background-color: #ddffdd">+ || in_range_p(addr, control_stack, control_stack_size)
+ || in_range_p(addr, binding_stack, binding_stack_size));
</span> }
/* ---------------------------------------------------------------- */
<span style="color: #aaaaaa">@@ -412,8 +412,7 @@ os_vm_address_t round_up_sparse_size(os_vm_address_t addr)
</span> * of the dynamic space can be controlled from the command line.
*/
static os_vm_address_t spaces[] = {
<span style="color: #000000;background-color: #ffdddd">- READ_ONLY_SPACE_START, STATIC_SPACE_START,
- BINDING_STACK_START, CONTROL_STACK_START
</span><span style="color: #000000;background-color: #ddffdd">+ READ_ONLY_SPACE_START, STATIC_SPACE_START
</span> };
/*
</code></pre>
<br>
</li>
<li id='diff-2'>
<a href='https://gitlab.common-lisp.net/cmucl/cmucl/compare/65b5ed7715ded275fd4d360eab85df7c5357769d...e4897224933bfcdaf64888f51c0f3e03fd074748#diff-2'>
<strong>
src/lisp/validate.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/src/lisp/validate.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/src/lisp/validate.c
</span><span style="color: #aaaaaa">@@ -116,14 +116,14 @@ validate_stacks()
</span> {
/* Control Stack */
/* Map the conrol stack wherever we have space */
<span style="color: #000000;background-color: #ffdddd">- control_stack = os_validate(NULL, control_stack_size);
</span><span style="color: #000000;background-color: #ddffdd">+ control_stack = (lispobj*) os_validate(NULL, control_stack_size);
</span>
#if (defined(i386) || defined(__x86_64))
control_stack_end = (void*)control_stack + control_stack_size;
#endif
/* Binding Stack */
<span style="color: #000000;background-color: #ffdddd">- binding_stack = os_validate(NULL, binding_stack_size);
</span><span style="color: #000000;background-color: #ddffdd">+ binding_stack = (lispobj*) os_validate(NULL, binding_stack_size);
</span>
#ifdef sparc
make_stack_holes();
</code></pre>
<br>
</li>
<li id='diff-3'>
<a href='https://gitlab.common-lisp.net/cmucl/cmucl/compare/65b5ed7715ded275fd4d360eab85df7c5357769d...e4897224933bfcdaf64888f51c0f3e03fd074748#diff-3'>
<strong>
src/lisp/validate.h
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/src/lisp/validate.h
</span><span style="color: #000000;background-color: #ddffdd">+++ b/src/lisp/validate.h
</span><span style="color: #aaaaaa">@@ -37,5 +37,6 @@
</span> #endif
extern void validate(void);
<span style="color: #000000;background-color: #ddffdd">+extern void validate_stacks(void);
</span>
#endif /* _VALIDATE_H_ */
</code></pre>
<br>
</li>
</div>
<div class='footer' style='margin-top: 10px;'>
<p>
—
<br>
<a href="https://gitlab.common-lisp.net/cmucl/cmucl/compare/65b5ed7715ded275fd4d360eab85df7c5357769d...e4897224933bfcdaf64888f51c0f3e03fd074748">View it on GitLab</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":["merge_requests","issues","commit"],"url":"https://gitlab.common-lisp.net/cmucl/cmucl/compare/65b5ed7715ded275fd4d360eab85df7c5357769d...e4897224933bfcdaf64888f51c0f3e03fd074748"}}</script>
</p>
</div>
</body>
</html>