<html lang='en'>
<head>
<meta content='text/html; charset=utf-8' http-equiv='Content-Type'>
<title>
GitLab
</title>
</meta>
</head>
<style>
img {
max-width: 100%;
height: auto;
}
p.details {
font-style:italic;
color:#777
}
.footer p {
font-size:small;
color:#777
}
pre.commit-message {
white-space: pre-wrap;
}
.file-stats a {
text-decoration: none;
}
.file-stats .new-file {
color: #090;
}
.file-stats .deleted-file {
color: #B00;
}
</style>
<body>
<div class='content'>
<h3>Raymond Toy pushed to branch master at <a href="https://gitlab.common-lisp.net/cmucl/cmucl">cmucl / cmucl</a></h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/89074ab386b5ce7d2283261949b120e9a6713dfd">89074ab3</a></strong>
<div>
<span>by Raymond Toy</span>
<i>at 2015-06-24T06:50:04Z</i>
</div>
<pre class='commit-message'>Check for function names correctly
Fix #7
The change to use extended names like (flet frob) broke the detection
of local names for get-setf-expansion. Fix it. This reverts behavior
back to what 18a used to do.
A test for this is also added.</pre>
</li>
</ul>
<h4>2 changed files:</h4>
<ul>
<li class='file-stats'>
<a href='#diff-0'>
src/code/macros.lisp
</a>
</li>
<li class='file-stats'>
<a href='#diff-1'>
tests/issues.lisp
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id='diff-0'>
<a href='https://gitlab.common-lisp.net/cmucl/cmucl/commit/89074ab386b5ce7d2283261949b120e9a6713dfd#diff-0'>
<strong>
src/code/macros.lisp
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/src/code/macros.lisp
</span><span style="color: #000000;background-color: #ddffdd">+++ b/src/code/macros.lisp
</span><span style="color: #aaaaaa">@@ -667,7 +667,7 @@
</span> ((and environment
(let ((name (car form)))
(dolist (x (c::lexenv-functions environment) nil)
- (when (and (eq (car x) name)
<span style="color: #000000;background-color: #ddffdd">+ (when (and (eq (nth-value 1 (valid-function-name-p (car x))) name)
</span> (not (c::defined-function-p (cdr x))))
(return t)))))
(expand-or-get-setf-inverse form environment))
</code></pre>
<br>
</li>
<li id='diff-1'>
<a href='https://gitlab.common-lisp.net/cmucl/cmucl/commit/89074ab386b5ce7d2283261949b120e9a6713dfd#diff-1'>
<strong>
tests/issues.lisp
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/tests/issues.lisp
</span><span style="color: #000000;background-color: #ddffdd">+++ b/tests/issues.lisp
</span><span style="color: #aaaaaa">@@ -73,4 +73,23 @@
</span> (assert-prints "SQUARE compiler macro present: No.
8"
- (test/present)))
\ No newline at end of file
<span style="color: #000000;background-color: #ddffdd">+ (test/present)))
+
+(defmacro xpop (place &environment env)
+ (multiple-value-bind (dummies vals new setter getter)
+ (get-setf-expansion place env)
+ `(let* (,@(mapcar #'list dummies vals) (,(car new) ,getter))
+ (if ,(cdr new) (error "Can't expand this."))
+ (prog1 (car ,(car new))
+ (setq ,(car new) (cdr ,(car new)))
+ ,setter))))
+
+(defsetf frob (x) (value)
+ `(setf (car ,x) ,value))
+
+(define-test issue.7
+ (:tag :issues)
+ (assert-error 'error
+ (let ((z (list 1 2)))
+ (flet ((frob (x) (cdr x)))
+ (xpop (frob z))))))
</span></code></pre>
<br>
</li>
</div>
<div class='footer' style='margin-top: 10px;'>
<p>
—
<br>
<a href="https://gitlab.common-lisp.net/cmucl/cmucl/commit/89074ab386b5ce7d2283261949b120e9a6713dfd">View it on GitLab</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://gitlab.common-lisp.net/cmucl/cmucl/commit/89074ab386b5ce7d2283261949b120e9a6713dfd"}}</script>
</p>
</div>
</body>
</html>