[Git][cmucl/cmucl][issue-139-set-filename-encoding-to-utf8] Address review comments

[Raymond Toy (@rtoy)]

Raymond Toy pushed to branch issue-139-set-filename-encoding-to-utf8 at cmucl / cmucl


Commits:
1ee83644 by Raymond Toy at 2022-12-21T09:57:10-08:00
Address review comments

Remove `-nositeinit` and undo some indentation as requested.

- - - - -


3 changed files:

- bin/run-tests.sh
- src/code/extfmts.lisp
- src/code/save.lisp


Changes:

=====================================
bin/run-tests.sh
=====================================
@@ -49,7 +49,7 @@ trap cleanup EXIT
 
 if [ $# -eq 0 ]; then
     # No args so run all the tests
-    $LISP -noinit -nositeinit -load tests/run-tests.lisp -eval '(cmucl-test-runner:run-all-tests)'
+    $LISP -noinit -load tests/run-tests.lisp -eval '(cmucl-test-runner:run-all-tests)'
 else
     # Run selected files.  Convert each file name to uppercase and append "-TESTS"
     result=""
@@ -58,6 +58,6 @@ else
 	new=`echo $f | tr '[a-z]' '[A-Z]'`
         result="$result "\"$new-TESTS\"
     done
-    $LISP -noinit -nositeinit -load tests/run-tests.lisp -eval "(progn (cmucl-test-runner:load-test-files) (cmucl-test-runner:run-test $result))"
+    $LISP -noinit -load tests/run-tests.lisp -eval "(progn (cmucl-test-runner:load-test-files) (cmucl-test-runner:run-test $result))"
 fi
 


=====================================
src/code/extfmts.lisp
=====================================
@@ -371,7 +371,7 @@
 
 (defun load-external-format-aliases ()
   ;; Set filename encoding to NIL to bypass any encoding; it's not
-  ;; needed to open the aliases file.
+  ;; needed to open the aliases file.  NIL means the pathname string is passed as is where only the low 8 bits of the 
   (let ((*package* (find-package "KEYWORD"))
 	(unix::*filename-encoding* nil))
     (with-open-file (stm "ext-formats:aliases" :if-does-not-exist nil


=====================================
src/code/save.lisp
=====================================
@@ -194,18 +194,18 @@
 	  (stream:string-decode *unidata-path* file-locale))))
 
 (defun save-lisp (core-file-name &key
-				   (purify t)
-				   (root-structures ())
-				   (environment-name "Auxiliary")
-				   (init-function #'%top-level)
-				   (load-init-file t)
-				   (site-init "library:site-init")
-				   (print-herald t)
-				   (process-command-line t)
-		                   #+:executable
-		                   (executable nil)
-				   (batch-mode nil)
-				   (quiet nil))
+				 (purify t)
+				 (root-structures ())
+				 (environment-name "Auxiliary")
+				 (init-function #'%top-level)
+				 (load-init-file t)
+				 (site-init "library:site-init")
+				 (print-herald t)
+				 (process-command-line t)
+		                 #+:executable
+		                 (executable nil)
+				 (batch-mode nil)
+				 (quiet nil))
   "Saves a CMU Common Lisp core image in the file of the specified name.  The
   following keywords are defined:
   
@@ -390,7 +390,7 @@
     (let ((initial-function (get-lisp-obj-address #'restart-lisp))
 	  (core-name (unix-namestring core-file-name nil)))
       (without-gcing
-	#+:executable
+	  #+:executable
 	(if executable
 	    (save-executable core-name initial-function)
 	    (save core-name initial-function #+sse2 1 #-sse2 0))



View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/1ee836448664a215b534c3ebf7d63ffdcc2d29e6

-- 
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/1ee836448664a215b534c3ebf7d63ffdcc2d29e6
You're receiving this email because of your account on gitlab.common-lisp.net.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/cmucl-cvs/attachments/20221221/716cc8d7/attachment-0001.html>