[cldoc-devel] unsafe format string passed to write-html in make-summary

[Iban HATCHONDO]

Hi, 
I think you're right. Since the html-write macro is made to be used without control-string when a proper string is given. Or in the present case it is obvious that a descriptor name is not a safe string for format, and is used everywhere else with a "~a" control string.

So, unless one wants to report some potential glitch or side effect of this patch I'll apply it asap.

Kind regards,
Iban.

----- Message d'origine ----
De : "Taylor, Joshua" <tayloj at rpi.edu>
À : cldoc-devel at common-lisp.net
Envoyé le : Mardi, 28 Août 2007, 17h00mn 34s
Objet : [cldoc-devel] unsafe format string passed to write-html in make-summary

Hello all,

I was just writing some functions for character dispatch macros, and
some of these had some interesting names. Particularly,

(defun |#~-reader| (...)
   ...)

In make-summary, in html.lisp, there's a form

(html-write (purge-string-for-html (name desc)))

which chokes because (purge-string-for-html (name desc)) becomes
"|#~-reader|", and (html-write "|#~-reader|") expands to (Format
*Html-Output-Stream* "|#~-reader|"), but that ~- is problematic. I
found the simple fix by adding a format string, "~a.", i.e.,

611c611
<                    (html-write "~a" (purge-string-for-html (name desc)))))
---
>                    (html-write (purge-string-for-html (name desc)))))

which seems to agree with the usage in line 614.

-- 
=====================
Joshua Taylor
tayloj at rpi.edu

"A lot of good things went down one time,
     back in the goodle days."
               John Hartford
_______________________________________________
cldoc-devel mailing list
cldoc-devel at common-lisp.net
http://common-lisp.net/cgi-bin/mailman/listinfo/cldoc-devel





      _____________________________________________________________________________ 
Ne gardez plus qu'une seule adresse mail ! Copiez vos mails vers Yahoo! Mail