[cl-xmpp-devel] Re: problems getting started

[Jason S. Cornez]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Lichteblau wrote:
> As his second reply explains, this is a bug in CL-XMPP's SASL support.
> 
> The client is supposed to reset the stream by throwing away the previous
> XML parser source and creating a new one.
> 
> Here's a patch fixing CL-XMPP accordingly.
> 
> 
> Thanks,
> David

Many thanks, David.  You've been a big help.

I'm looking at this patch and I think it might not be done in the best
way.  For example, there is already a method
(if-successful-restart-stream ...) which seems to do nearly what we
want.  The only thing that it doesn't do is

  (setf (server-source connection) nil)

Note, there is no need to set this to a new source because a new source
will automatically be created by (read-stanza ...) when there is no
source.  So setting to nil should be fine.

So, I think that if the above setf is added to
(if-successful-restart-stream ...) then that is all that is required.
Specifically, there is no need to change (handle-challenge-response ...)
since as written it will just propogate the result of (receive-stanza
...) up and the test for :authentication-successful will happen anyway.

Note also that (convert-to-tls-stream ...) does exactly this.  We've
tested our suggestion here and it works.

- -Jason and Kevin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHXltiQlm6HDTMLyMRAjfQAKD0JWOOVjCzZF9DB2TqjEhcjdRWKQCcCmoW
lYfawyJE/7uFIGgyyh6jojk=
=8eZ2
-----END PGP SIGNATURE-----