From jcornez at alum.mit.edu  Mon Dec 10 12:31:32 2007
From: jcornez at alum.mit.edu (Jason S. Cornez)
Date: Mon, 10 Dec 2007 13:31:32 +0100
Subject: [cl-xmpp-devel] Re: problems getting started
In-Reply-To: <4715C5E1.2020602@alum.mit.edu>
References: <470CC87B.5080507@alum.mit.edu>
	<470CE533.8060803@alum.mit.edu>	<47135C85.4040908@alum.mit.edu>
	<4714DF6D.3000901@alum.mit.edu>	<20071016175603.GA5163@radon>
	<4715C5E1.2020602@alum.mit.edu>
Message-ID: <475D31A4.9030505@alum.mit.edu>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I've taken the liberty of reporting this bug to the ejabberd folks.
https://support.process-one.net/browse/EJAB-455

Thanks again,
- -Jason

Jason S. Cornez wrote:
> David Lichteblau wrote:
>> I realize this answer is unsatisfactory, but this is a bug in ejabberd.
>> The XML declaration is not a processing instruction, and must only
>> appear at the beginning of the document (here: TCP connection), not in
>> the middle of the content (here: in front of every opening <stream>
>> tag).
> 
>> This ejabberd patch fixes the bug for me:
> 
> Thank you so much.  This was very helpful.  In this case, I do have
> control over the jabber server.  I can now successfully send messages.
> I was very close to switching to IRC...
> 
> Have you already filed this as a bug with the ejabberd folks?
> 
> -Jason

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHXTGjQlm6HDTMLyMRAlnJAKDhtE8eNNxxOdNJzOer31rN7JdaLgCfdZHX
JW6ckZI8LCRGajiBH6Ya+T0=
=OS3a
-----END PGP SIGNATURE-----


From jcornez at alum.mit.edu  Mon Dec 10 14:16:51 2007
From: jcornez at alum.mit.edu (Jason S. Cornez)
Date: Mon, 10 Dec 2007 15:16:51 +0100
Subject: [cl-xmpp-devel] Re: problems getting started
In-Reply-To: <4715C5E1.2020602@alum.mit.edu>
References: <470CC87B.5080507@alum.mit.edu>
	<470CE533.8060803@alum.mit.edu>	<47135C85.4040908@alum.mit.edu>
	<4714DF6D.3000901@alum.mit.edu>	<20071016175603.GA5163@radon>
	<4715C5E1.2020602@alum.mit.edu>
Message-ID: <475D4A53.1050102@alum.mit.edu>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> I've taken the liberty of reporting this bug to the ejabberd folks.
> https://support.process-one.net/browse/EJAB-455

And what follows is the reply...  I'm not (yet) an expert on any of
this.  But if there is some document (ie a spec) that explains how the
XML declaration really isn't valid, then please point me to it and I'll
press the issue with the ejabberd folks.  Otherwise, this seems to
indicate a bug in cxml which ought to be fixed.

Again, I volunteer to help however I can, but I need a few expert
opinions first.  Thanks,

- -Jason

Micka?l R?mond closed EJAB-455.
- -------------------------------

    Resolution: Won't Fix

Sorry but the change you suggest is not compliant with XMPP RFC.

See example stream in: http://www.xmpp.org/rfcs/rfc3920.html#rfc.section.4.8

You should fix your client to support the XML version declaration.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHXUpTQlm6HDTMLyMRAk5CAJ4zL/OU87LzhgQQnd4UWwP819pGwQCeOBfk
b2KBGzsFW/QbdmUuYkuIoDA=
=1Amc
-----END PGP SIGNATURE-----


From david at lichteblau.com  Mon Dec 10 19:57:29 2007
From: david at lichteblau.com (David Lichteblau)
Date: Mon, 10 Dec 2007 20:57:29 +0100
Subject: [cl-xmpp-devel] Re: problems getting started
In-Reply-To: <475D4A53.1050102@alum.mit.edu>
References: <470CC87B.5080507@alum.mit.edu> <470CE533.8060803@alum.mit.edu>
	<47135C85.4040908@alum.mit.edu> <4714DF6D.3000901@alum.mit.edu>
	<20071016175603.GA5163@radon> <4715C5E1.2020602@alum.mit.edu>
	<475D4A53.1050102@alum.mit.edu>
Message-ID: <20071210195729.GA21736@radon>

Quoting Jason S. Cornez (jcornez at alum.mit.edu):
> And what follows is the reply...  I'm not (yet) an expert on any of
> this.  But if there is some document (ie a spec) that explains how the
> XML declaration really isn't valid, then please point me to it and I'll
> press the issue with the ejabberd folks.  Otherwise, this seems to
> indicate a bug in cxml which ought to be fixed.

As his second reply explains, this is a bug in CL-XMPP's SASL support.

The client is supposed to reset the stream by throwing away the previous
XML parser source and creating a new one.

Here's a patch fixing CL-XMPP accordingly.


Thanks,
David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sasl-stream-reset.diff
Type: text/x-diff
Size: 1038 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/cl-xmpp-devel/attachments/20071210/c76b0b37/attachment.diff>

From david at lichteblau.com  Mon Dec 10 20:42:49 2007
From: david at lichteblau.com (David Lichteblau)
Date: Mon, 10 Dec 2007 21:42:49 +0100
Subject: [cl-xmpp-devel] git repository
Message-ID: <20071210204249.GA22681@radon>

Hi,

since I don't have commit access to cl-xmpp CVS, I have put up my
current patches at http://www.lichteblau.com/git/cl-xmpp.git/


d.


From erik.enge at gmail.com  Tue Dec 11 01:41:28 2007
From: erik.enge at gmail.com (Erik Enge)
Date: Mon, 10 Dec 2007 20:41:28 -0500
Subject: [cl-xmpp-devel] git repository
In-Reply-To: <20071210204249.GA22681@radon>
References: <20071210204249.GA22681@radon>
Message-ID: <58f839b70712101741v3f6755b9r9b87a85942ec0c38@mail.gmail.com>

Drew,

please give David commit access to cl-xmpp.  He has supported it over
the years (and I have not) so in fact I hereby authorize him to do as
he wishes with the project.

Thanks,
Erik.

On Dec 10, 2007 3:42 PM, David Lichteblau <david at lichteblau.com> wrote:
> Hi,
>
> since I don't have commit access to cl-xmpp CVS, I have put up my
> current patches at http://www.lichteblau.com/git/cl-xmpp.git/
>
>
> d.
> _______________________________________________
> cl-xmpp-devel mailing list
> cl-xmpp-devel at common-lisp.net
> http://common-lisp.net/cgi-bin/mailman/listinfo/cl-xmpp-devel
>


From jcornez at alum.mit.edu  Tue Dec 11 09:41:54 2007
From: jcornez at alum.mit.edu (Jason S. Cornez)
Date: Tue, 11 Dec 2007 10:41:54 +0100
Subject: [cl-xmpp-devel] Re: problems getting started
In-Reply-To: <20071210195729.GA21736@radon>
References: <470CC87B.5080507@alum.mit.edu> <470CE533.8060803@alum.mit.edu>
	<47135C85.4040908@alum.mit.edu> <4714DF6D.3000901@alum.mit.edu>
	<20071016175603.GA5163@radon> <4715C5E1.2020602@alum.mit.edu>
	<475D4A53.1050102@alum.mit.edu> <20071210195729.GA21736@radon>
Message-ID: <475E5B62.6090200@alum.mit.edu>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Lichteblau wrote:
> As his second reply explains, this is a bug in CL-XMPP's SASL support.
> 
> The client is supposed to reset the stream by throwing away the previous
> XML parser source and creating a new one.
> 
> Here's a patch fixing CL-XMPP accordingly.
> 
> 
> Thanks,
> David

Many thanks, David.  You've been a big help.

I'm looking at this patch and I think it might not be done in the best
way.  For example, there is already a method
(if-successful-restart-stream ...) which seems to do nearly what we
want.  The only thing that it doesn't do is

  (setf (server-source connection) nil)

Note, there is no need to set this to a new source because a new source
will automatically be created by (read-stanza ...) when there is no
source.  So setting to nil should be fine.

So, I think that if the above setf is added to
(if-successful-restart-stream ...) then that is all that is required.
Specifically, there is no need to change (handle-challenge-response ...)
since as written it will just propogate the result of (receive-stanza
...) up and the test for :authentication-successful will happen anyway.

Note also that (convert-to-tls-stream ...) does exactly this.  We've
tested our suggestion here and it works.

- -Jason and Kevin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHXltiQlm6HDTMLyMRAjfQAKD0JWOOVjCzZF9DB2TqjEhcjdRWKQCcCmoW
lYfawyJE/7uFIGgyyh6jojk=
=8eZ2
-----END PGP SIGNATURE-----


From kcrosbie at ravenpack.com  Wed Dec 19 12:55:56 2007
From: kcrosbie at ravenpack.com (Kevin Crosbie)
Date: Wed, 19 Dec 2007 13:55:56 +0100
Subject: [cl-xmpp-devel] Code Contribution
Message-ID: <476914DC.6050404@ravenpack.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 
Hi,

Here is a patch that provides all of the functionality that Jason
Cornez and I in Ravenpack International been adding to cl-xmpp over
the past few weeks.

It can be downloaded from: http://paste.lisp.org/display/52785

Included are:
  * Some bug fixes regarding error handling, authentication and error
propagation from cxml.
  * Implementation of some new result types: invitations,
simple-results along with some minor modifications to helper functions.
  * Implementation of an API for multi-user-chat.
  * Implementation of some administrative functions.
  * Ability to set a stanza-callback as a member of the connection
class, but still override it when calling receive-stanza.
  * Ability to stop the receive-stanza-loop gracefully by having it
depend on a connection class member being set.

Testing was done using Franz Allegro 8.1 against ejabberd 1.1.4
(although the administrative function end-user-session is not provided
in that version.   2.0 Beta will include it though).
Of course I volunteer myself to apply the patch to CVS if everybody
agrees and nobody else volunteers (I'll need access).

Best Regards,

Kevin Crosbie
Software Developer
Ravenpack International S.L.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
 
iD8DBQFHaRTcEdUcNFP15iMRAjx/AJ92wfv4+YDj7hzQ+7j2SVzWXRFO9ACg2Km0
3CFdmZP0EljDlTcwS6qe1MU=
=fmeS
-----END PGP SIGNATURE-----