[cl-who-devel] declarations placement issue

[Ala'a Mohammad]

Thanks for taking the time to reply.

I've already forked the github version and got the patch approved by Hans.

Best wishes,

Ala'a.

On Sat, May 5, 2012 at 1:26 AM, Edi Weitz <edi at agharta.de> wrote:
> Sorry for the late reply... :(
>
> Yeah, look like you're right.  I think the documentation is to blame
> in that it talks about declarations although I think CL-WHO never took
> care of them.  I'd suggest to just remove this from the docs unless
> you have a patch.  (I myself am too busy with other things to work on
> the code.)
>
> Thanks,
> Edi.
>
>
> On Thu, Apr 19, 2012 at 10:42 PM, Ala'a Mohammad <amalawi at gmail.com> wrote:
>> Hi,
>>
>> Please, correct me If I'm wrong.
>>
>> in the expansion of the following (using cl-who from quicklisp)
>>
>> (with-html-output (var)
>>  (declare (special var)))
>> ;=>
>> (LET ((VAR VAR))
>>   (PROGN
>>      (DECLARE (SPECIAL VAR))))
>>
>> I think that the declaration is placed in the wrong place. CLHS does
>> not specify any declarations for PROGN entry. and in this declaration
>> provides information about the bindings of LET, thus I thought the
>> correct expansion should be:
>>
>> (with-html-output (var)
>>  (declare (special var)))
>> ;=>
>> (LET ((VAR VAR))
>>   (DECLARE (SPECIAL VAR))
>>   (PROGN))
>>
>> the fix should should only affect with-html-output (since
>> with-html-output-to-string passes the declarations to the former
>> macro)
>>
>> Regards,
>>
>> Ala'a
>>
>> _______________________________________________
>> cl-who-devel site list
>> cl-who-devel at common-lisp.net
>> http://common-lisp.net/mailman/listinfo/cl-who-devel
>>
>
> _______________________________________________
> cl-who-devel site list
> cl-who-devel at common-lisp.net
> http://common-lisp.net/mailman/listinfo/cl-who-devel