From erik.enge at gmail.com  Thu Jul 27 20:37:02 2006
From: erik.enge at gmail.com (Erik Enge)
Date: Thu, 27 Jul 2006 16:37:02 -0400
Subject: [cl-who-devel] CL-WHO:STR behavior and package nicknames.
Message-ID: <58f839b70607271337y2e0dec65s975d7d2ab020795d@mail.gmail.com>

(cl-who 0.6.0, linux, sbcl 0.9.13)

Hi!

In the documentation I find the following example:

(:table :border (+ 1 2)) => (write-string "<table border='" s)
                                             (princ (+ 1 2) s)
                                               (write-string "' />" s)

However, in my implementation I see the following:

CL-USER> (cl-who:with-html-output-to-string (*standard-output*)
                    (:table :border (+ 1 2)))
"<table border='(+ 1 2)' />"

This makes sense because CONSTANTP returns T for that form in SBCL and
NIL in CMUCL.  In which case I think I'm supposed to use the STR
operator:

CL-USER> (cl-who:with-html-output-to-string (*standard-output*)
                   (:table :border (cl-who:str (+ 1 2))))
"<table3 border='3' />"

ESC does pretty much the same thing.  So does FMT I guess except it
doesn't print the border attribute since the format call returns nil,
which I think makes sense.  Is this the expected behavior?  Is there
another way of having (:table :border (+ 1 2)) do what I want (output
<table border='3' />)?

Separately, would you consider adding the nickname "who" (or whatever
you like, just shorter than "cl-who") to the package?

Thanks,
Erik.


From edi at agharta.de  Thu Jul 27 21:51:41 2006
From: edi at agharta.de (Edi Weitz)
Date: Thu, 27 Jul 2006 23:51:41 +0200
Subject: [cl-who-devel] New release 0.6.1 (Was: CL-WHO:STR behavior and
	package nicknames.)
In-Reply-To: <58f839b70607271337y2e0dec65s975d7d2ab020795d@mail.gmail.com>
	(Erik Enge's message of "Thu, 27 Jul 2006 16:37:02 -0400")
References: <58f839b70607271337y2e0dec65s975d7d2ab020795d@mail.gmail.com>
Message-ID: <u7j1yemxe.fsf@agharta.de>

Hi Erik!

On Thu, 27 Jul 2006 16:37:02 -0400, "Erik Enge" <erik.enge at gmail.com> wrote:

> In the documentation I find the following example:
>
> (:table :border (+ 1 2)) => (write-string "<table border='" s)
>                                              (princ (+ 1 2) s)
>                                                (write-string "' />" s)
>
> However, in my implementation I see the following:
>
> CL-USER> (cl-who:with-html-output-to-string (*standard-output*)
>                     (:table :border (+ 1 2)))
> "<table border='(+ 1 2)' />"
>
> This makes sense because CONSTANTP returns T for that form in SBCL
> and NIL in CMUCL.

Right, I didn't think of that.  What I actually /meant/ in this case
was that this form should be evaluated and I think because it is
CONSTANTP this is one of the few occasions where usage of EVAL is OK.
Anyway, I've uploaded a new version which does exactly that.

> In which case I think I'm supposed to use the STR operator:

No, STR, ESC, and FMT aren't really meaningful in attribute positions.
They are supposed to occur in the body of a tag.

> Separately, would you consider adding the nickname "who" (or
> whatever you like, just shorter than "cl-who") to the package?

Done in 0.6.1.

Thanks for the report,
Edi.