[cl-store-devel] CREATE-FLOAT-VALUE defined twice.

[Nikolaus Demmel]

Thanks!

Am 16.02.2010 um 11:57 schrieb Sean Ross:

> Thanks,
> I've applied the patch to the repository.
> 
> - sean
> On 16 Feb 2010, at 10:07, Nikolaus Demmel wrote:
> 
>> Hi Sean,
>> 
>> thanks for your reply.
>> 
>> Attached a patch that works for me. It is quite simple. I hope this is acceptable.
>> 
>> From the patch description:
>> 
>>> Remove warning about CREATE-FLOAT-VALUES being defined twice.
>>> 
>>> * I went for the simple fix and just conditionally read the default
>>>   version of CREATE-FLOAT-VALUES, which is defined in
>>>   default-backend.lisp. For the implementations that provide their
>>>   own version of CREATE-FLOAT-VALUE in the according custom.lisp file
>>>   this should remove a warning about the function being redefined,
>>>   while all other implementations are unaffected by this patch.
>> 
>> Best regards,
>> Niko
>> 
>> <create-float-values-warning.patch>
>> 
>> 
>> Am 16.02.2010 um 10:32 schrieb Sean Ross:
>> 
>>> Hi Nikolaus,
>>> A patch which removes the warning would be appreciated.
>>> 
>>> Glad you are finding the library useful.
>>> 
>>> Cheers,
>>> Sean.
>>> 
>>> 
>>> On 14 Feb 2010, at 19:30, Nikolaus Demmel wrote:
>>> 
>>>> Hi,
>>>> 
>>>> the function CREATE-FLOAT-VALUE is defined once in "default-backend.lisp" and once in the implementation specific files. This results in a warning about redefining said function when loading the system. Is there a reason the default definition is there (it does nothing) and would it be possible to remove it and just leave the note saying that each implementation must provide it? I'd be happy to provide a patch.
>>>> 
>>>> Btw thanks for this great library! I found it to be very usefull (especially the extensibility and the circularity handling).
>>>> 
>>>> Regards,
>>>> Niko_______________________________________________
>>>> cl-store-devel mailing list
>>>> cl-store-devel at common-lisp.net
>>>> http://common-lisp.net/cgi-bin/mailman/listinfo/cl-store-devel
>>> 
>> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4623 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/cl-store-devel/attachments/20100216/5e84cad0/attachment.bin>