From lisp.linux at gmail.com Sat Dec 11 17:33:36 2010 From: lisp.linux at gmail.com (Antony) Date: Sat, 11 Dec 2010 09:33:36 -0800 Subject: [cl-sqlite-devel] trivial patch to remove warning Message-ID: <4D03B5F0.5070806@gmail.com> Hi Would you mind applying the following patch if it's ok. Thanks, -Antony --- /home/antony/cl-sqlite/cache.lisp 2010-12-11 09:14:58.129838000 -0800 +++ cl-sqlite/cache.lisp 2010-12-11 09:26:02.172819100 -0800 @@ -53,6 +53,7 @@ (defun purge-cache (cache) (iter (for (id items) in-hashtable (objects-table cache)) + (declare (ignorable id)) (when items (iter (for item in-vector (the vector items)) (funcall (destructor cache) item))))) \ No newline at end of file From lisp.linux at gmail.com Sun Dec 12 07:58:50 2010 From: lisp.linux at gmail.com (Antony) Date: Sat, 11 Dec 2010 23:58:50 -0800 Subject: [cl-sqlite-devel] sqlite test failing Message-ID: <4D0480BA.70606@gmail.com> Hi I just tried the sqlite tests (mostly out of curiosity) and I got the results below. I was wondering if this is expected or not. My current environment is Windows 7 and Clozure Common Lisp Version 1.6-r14468M (WindowsX8664) -Antony CL-USER> (fiveam:run! 'sqlite-tests::sqlite-suite) ......f............ Did 19 checks. Pass: 18 (94%) Skip: 0 ( 0%) Fail: 1 ( 5%) Failure Details: -------------------------------- TEST-CONCURRENT-INSERTS []: One of inserter threads encountered a SQLITE_BUSY error. -------------------------------- NIL CL-USER> From kalyanov.dmitry at gmail.com Wed Dec 15 18:32:49 2010 From: kalyanov.dmitry at gmail.com (Kalyanov Dmitry) Date: Wed, 15 Dec 2010 21:32:49 +0300 Subject: [cl-sqlite-devel] trivial patch to remove warning In-Reply-To: <4D03B5F0.5070806@gmail.com> References: <4D03B5F0.5070806@gmail.com> Message-ID: <1292437969.3267.1.camel@dvk-laptop> On Sat, 2010-12-11 at 09:33 -0800, Antony wrote: > Hi > > Would you mind applying the following patch if it's ok. Thanks, I've applied this. By the way, which Lisp compiler produces a warning on this code? (SBCL did not issue a warning) -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part URL: From kalyanov.dmitry at gmail.com Wed Dec 15 18:37:10 2010 From: kalyanov.dmitry at gmail.com (Kalyanov Dmitry) Date: Wed, 15 Dec 2010 21:37:10 +0300 Subject: [cl-sqlite-devel] sqlite test failing In-Reply-To: <4D0480BA.70606@gmail.com> References: <4D0480BA.70606@gmail.com> Message-ID: <1292438230.3267.6.camel@dvk-laptop> On Sat, 2010-12-11 at 23:58 -0800, Antony wrote: > Hi > > I just tried the sqlite tests (mostly out of curiosity) > and I got the results below. > I was wondering if this is expected or not. > My current environment is Windows 7 and > Clozure Common Lisp Version 1.6-r14468M (WindowsX8664) This test actually depends on the load of your system - if the load is high, the failure on this test is possible because this test involves many threads and timeouts and so is non-deterministic. If you reduce the numbers in "test-concurrent-inserts" test and it will still fail then there is an error. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part URL: From lisp.linux at gmail.com Sun Dec 19 19:28:10 2010 From: lisp.linux at gmail.com (Antony) Date: Sun, 19 Dec 2010 11:28:10 -0800 Subject: [cl-sqlite-devel] sqlite test failing In-Reply-To: <1292438230.3267.6.camel@dvk-laptop> References: <4D0480BA.70606@gmail.com> <1292438230.3267.6.camel@dvk-laptop> Message-ID: <4D0E5CCA.7090907@gmail.com> On 12/15/2010 10:37 AM, Kalyanov Dmitry wrote: > On Sat, 2010-12-11 at 23:58 -0800, Antony wrote: >> Hi >> >> I just tried the sqlite tests (mostly out of curiosity) >> and I got the results below. >> I was wondering if this is expected or not. >> My current environment is Windows 7 and >> Clozure Common Lisp Version 1.6-r14468M (WindowsX8664) Mystery solved. Things are good. Here's what happened. The test code uses (defparameter *db-file* "/tmp/test.sqlite") which does not work for windows. The tests when run as is give the error "Could not open sqlite3 database /tmp/test.sqlite" I tried to run it as (let ((sqlite-tests::*db-file* "c:/D/temp/tests.tmp.sqlite")) (fiveam:run! 'sqlite-tests::sqlite-suite)) this gives the error "One of inserter threads encountered a SQLITE_BUSY error" This is misleading. What is happening is that the main thread code that does file checks now finds the new binding for *db-file* and stops showing the previous error. But the thread function still sees the global binding (since i have not done any thread specials setup) Long story short, I just changed the variable to a windows kind of path just to make sure the tests run ok, and they did. They still fail sometime, but I can see why. Thanks for the library, -Antony From kalyanov.dmitry at gmail.com Sun Dec 19 20:00:34 2010 From: kalyanov.dmitry at gmail.com (Kalyanov Dmitry) Date: Sun, 19 Dec 2010 23:00:34 +0300 Subject: [cl-sqlite-devel] sqlite test failing In-Reply-To: <4D0E5CCA.7090907@gmail.com> References: <4D0480BA.70606@gmail.com> <1292438230.3267.6.camel@dvk-laptop> <4D0E5CCA.7090907@gmail.com> Message-ID: <1292788834.6482.1.camel@dvk-laptop> On Sun, 2010-12-19 at 11:28 -0800, Antony wrote: > On 12/15/2010 10:37 AM, Kalyanov Dmitry wrote: > > On Sat, 2010-12-11 at 23:58 -0800, Antony wrote: > >> Hi > >> > >> I just tried the sqlite tests (mostly out of curiosity) > >> and I got the results below. > >> I was wondering if this is expected or not. > >> My current environment is Windows 7 and > >> Clozure Common Lisp Version 1.6-r14468M (WindowsX8664) > Mystery solved. Things are good. Here's what happened. Thanks for the analysis. I'll have to modify the test suite to use platform-specific paths to temp directory. From lisp.linux at gmail.com Mon Dec 20 06:05:26 2010 From: lisp.linux at gmail.com (Antony) Date: Sun, 19 Dec 2010 22:05:26 -0800 Subject: [cl-sqlite-devel] trivial patch to remove warning In-Reply-To: <1292437969.3267.1.camel@dvk-laptop> References: <4D03B5F0.5070806@gmail.com> <1292437969.3267.1.camel@dvk-laptop> Message-ID: <4D0EF226.1020507@gmail.com> On 12/15/2010 10:32 AM, Kalyanov Dmitry wrote: > On Sat, 2010-12-11 at 09:33 -0800, Antony wrote: >> Would you mind applying the following patch if it's ok. > Thanks, I've applied this. By the way, which Lisp compiler produces a > warning on this code? (SBCL did not issue a warning) > Clozure Common Lisp Version 1.6-r14468M (WindowsX8664) That is CCL on Windows 7 64 bit -Antony