From mail at chaitanyagupta.com Sat May 17 23:33:57 2008 From: mail at chaitanyagupta.com (Chaitanya Gupta) Date: Sun, 18 May 2008 05:03:57 +0530 Subject: [cl-selenium-devel] Returned values not handled correctly Message-ID: <482F6B65.5060805@chaitanyagupta.com> Hi, I just checked out cl-selenium and I must say I am very happy to see such a library for CL. However, there is a problem with cl-selenium in the way it handles values returned by the Selenium server in respone to "Actions" or "Accessors". Specifically, 1. Return types aren't really taken care of. e.g. DO-GET-ALL-FIELDS should return a list (or an array) of strings, as is returned by getAllFields (from the Selenium API); however, it returns only one string. iedoc.xml specifies the return types of all the functions. 2. DO-GET-HTML-SOURCE fails to return the complete source if the page source contains any commas. This is because EXECUTE splits the the HTTP response on the comma (using split-sequence), and returns only the second value of this list. Is there any patch on the way for these bugs? If not, I'll be happy to contribute. cheers, Chaitanya From mail at chaitanyagupta.com Sun May 18 14:39:24 2008 From: mail at chaitanyagupta.com (Chaitanya Gupta) Date: Sun, 18 May 2008 20:09:24 +0530 Subject: [cl-selenium-devel] Re: Returned values not handled correctly In-Reply-To: <482F6B65.5060805@chaitanyagupta.com> References: <482F6B65.5060805@chaitanyagupta.com> Message-ID: <48303F9C.4030102@chaitanyagupta.com> Chaitanya Gupta wrote: > 1. Return types aren't really taken care of. e.g. DO-GET-ALL-FIELDS > should return a list (or an array) of strings, as is returned by > getAllFields (from the Selenium API); however, it returns only one > string. iedoc.xml specifies the return types of all the functions. > 2. DO-GET-HTML-SOURCE fails to return the complete source if the page > source contains any commas. This is because EXECUTE splits the the > HTTP response on the comma (using split-sequence), and returns only > the second value of this list. > > Is there any patch on the way for these bugs? If not, I'll be happy to > contribute. > I have attached a patch file (output of csv diff) which fixes these problems. In a nutshell, the changes I have made are: * The class IEDOC-FUNCTION now has an additional slot, RETURN-TYPE. Its value is based on the return type specified for a function in iedoc.xml. EXECUTE has also been modified to take an optional argument, RETURN-TYPE, in addition to the required argument URL. This converts the response appropriately before returning it. e.g. if the RETURN-TYPE is LIST (corresponding to "string[]" return type in iedoc.xml), the result is a list of strings. * EXECUTE no longer splits the entire HTTP reply on a comma -- this prevents the second bug described above. I hope the patch is good enough. If there are any issues with it, I'll gladly fix them. Chaitanya -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: selenium.patch URL: From mkennedy at common-lisp.net Sun May 18 17:39:24 2008 From: mkennedy at common-lisp.net (Matthew Kennedy) Date: Sun, 18 May 2008 12:39:24 -0500 Subject: [cl-selenium-devel] Re: Returned values not handled correctly In-Reply-To: <48303F9C.4030102@chaitanyagupta.com> References: <482F6B65.5060805@chaitanyagupta.com> <48303F9C.4030102@chaitanyagupta.com> Message-ID: <9c1134b50805181039o66e67e60w86d29399f9fef9c9@mail.gmail.com> Hi Chaitanya, I agree, the return values needed improvement. Thanks for going to the trouble to create a patch to fix that. I would like to apply it but patch format is causing problems. Could you resend the patch using unified output format? ie. cvs diff -u >selenium.patch Thanks, Matt From mail at chaitanyagupta.com Mon May 19 04:13:43 2008 From: mail at chaitanyagupta.com (Chaitanya Gupta) Date: Mon, 19 May 2008 09:43:43 +0530 Subject: [cl-selenium-devel] Re: Returned values not handled correctly In-Reply-To: <9c1134b50805181039o66e67e60w86d29399f9fef9c9@mail.gmail.com> References: <482F6B65.5060805@chaitanyagupta.com> <48303F9C.4030102@chaitanyagupta.com> <9c1134b50805181039o66e67e60w86d29399f9fef9c9@mail.gmail.com> Message-ID: <4830FE77.7070207@chaitanyagupta.com> Hi, I have attached the patch in unified diff format. Chaitanya Matthew Kennedy wrote: > Hi Chaitanya, > > I agree, the return values needed improvement. Thanks for going to > the trouble to create a patch to fix that. I would like to apply it > but patch format is causing problems. Could you resend the patch > using unified output format? ie. cvs diff -u >selenium.patch > > Thanks, > Matt > _______________________________________________ > cl-selenium-devel mailing list > cl-selenium-devel at common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/cl-selenium-devel > -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: selenium.patch URL: From mkennedy at common-lisp.net Mon May 19 05:22:02 2008 From: mkennedy at common-lisp.net (Matthew Kennedy) Date: Mon, 19 May 2008 00:22:02 -0500 Subject: [cl-selenium-devel] Re: Returned values not handled correctly In-Reply-To: <4830FE77.7070207@chaitanyagupta.com> References: <482F6B65.5060805@chaitanyagupta.com> <48303F9C.4030102@chaitanyagupta.com> <9c1134b50805181039o66e67e60w86d29399f9fef9c9@mail.gmail.com> <4830FE77.7070207@chaitanyagupta.com> Message-ID: <9c1134b50805182222q7306daacv8193b3b7be8ec47@mail.gmail.com> Thanks, I've committed that patch to CVS and created a new cl-selenium-0.2 release archive. Matt On Sun, May 18, 2008 at 11:13 PM, Chaitanya Gupta wrote: > Hi, > > I have attached the patch in unified diff format. > > Chaitanya From mail at chaitanyagupta.com Mon May 19 05:42:37 2008 From: mail at chaitanyagupta.com (Chaitanya Gupta) Date: Mon, 19 May 2008 11:12:37 +0530 Subject: [cl-selenium-devel] Re: Returned values not handled correctly In-Reply-To: <9c1134b50805182222q7306daacv8193b3b7be8ec47@mail.gmail.com> References: <482F6B65.5060805@chaitanyagupta.com> <48303F9C.4030102@chaitanyagupta.com> <9c1134b50805181039o66e67e60w86d29399f9fef9c9@mail.gmail.com> <4830FE77.7070207@chaitanyagupta.com> <9c1134b50805182222q7306daacv8193b3b7be8ec47@mail.gmail.com> Message-ID: <4831134D.3080308@chaitanyagupta.com> Matthew Kennedy wrote: > Thanks, I've committed that patch to CVS and created a new > cl-selenium-0.2 release archive. > > I didn't see the new changes with cvs update. I had checked out the source using the following command: cvs -d :pserver:anonymous:anonymous at common-lisp.net:/project/cl-selenium/cvsroot co cl-selenium Is this correct? Chaitanya From mkennedy at common-lisp.net Mon May 19 06:38:15 2008 From: mkennedy at common-lisp.net (Matthew Kennedy) Date: Mon, 19 May 2008 01:38:15 -0500 Subject: [cl-selenium-devel] Re: Returned values not handled correctly In-Reply-To: <4831134D.3080308@chaitanyagupta.com> References: <482F6B65.5060805@chaitanyagupta.com> <48303F9C.4030102@chaitanyagupta.com> <9c1134b50805181039o66e67e60w86d29399f9fef9c9@mail.gmail.com> <4830FE77.7070207@chaitanyagupta.com> <9c1134b50805182222q7306daacv8193b3b7be8ec47@mail.gmail.com> <4831134D.3080308@chaitanyagupta.com> Message-ID: <9c1134b50805182338l583c5c94q826d437128ed56f2@mail.gmail.com> Oops. Try now. Matt On Mon, May 19, 2008 at 12:42 AM, Chaitanya Gupta wrote: > I didn't see the new changes with cvs update. I had checked out the source > using the following command: > > cvs -d > :pserver:anonymous:anonymous at common-lisp.net:/project/cl-selenium/cvsroot co > cl-selenium > > Is this correct? > > Chaitanya > > From mail at chaitanyagupta.com Mon May 19 08:30:00 2008 From: mail at chaitanyagupta.com (Chaitanya Gupta) Date: Mon, 19 May 2008 14:00:00 +0530 Subject: [cl-selenium-devel] Re: Returned values not handled correctly In-Reply-To: <9c1134b50805182338l583c5c94q826d437128ed56f2@mail.gmail.com> References: <482F6B65.5060805@chaitanyagupta.com> <48303F9C.4030102@chaitanyagupta.com> <9c1134b50805181039o66e67e60w86d29399f9fef9c9@mail.gmail.com> <4830FE77.7070207@chaitanyagupta.com> <9c1134b50805182222q7306daacv8193b3b7be8ec47@mail.gmail.com> <4831134D.3080308@chaitanyagupta.com> <9c1134b50805182338l583c5c94q826d437128ed56f2@mail.gmail.com> Message-ID: <48313A88.2040809@chaitanyagupta.com> Checked again, doesn't seem to be working. Matthew Kennedy wrote: > Oops. Try now. > > Matt > > On Mon, May 19, 2008 at 12:42 AM, Chaitanya Gupta > wrote: > > >> I didn't see the new changes with cvs update. I had checked out the source >> using the following command: >> >> cvs -d >> :pserver:anonymous:anonymous at common-lisp.net:/project/cl-selenium/cvsroot co >> cl-selenium >> >> Is this correct? >> >> Chaitanya >> >> >> > _______________________________________________ > cl-selenium-devel mailing list > cl-selenium-devel at common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/cl-selenium-devel > From mail at chaitanyagupta.com Mon May 19 12:02:51 2008 From: mail at chaitanyagupta.com (Chaitanya Gupta) Date: Mon, 19 May 2008 17:32:51 +0530 Subject: [cl-selenium-devel] Re: Returned values not handled correctly In-Reply-To: <9c1134b50805182338l583c5c94q826d437128ed56f2@mail.gmail.com> References: <482F6B65.5060805@chaitanyagupta.com> <48303F9C.4030102@chaitanyagupta.com> <9c1134b50805181039o66e67e60w86d29399f9fef9c9@mail.gmail.com> <4830FE77.7070207@chaitanyagupta.com> <9c1134b50805182222q7306daacv8193b3b7be8ec47@mail.gmail.com> <4831134D.3080308@chaitanyagupta.com> <9c1134b50805182338l583c5c94q826d437128ed56f2@mail.gmail.com> Message-ID: <48316C6B.6050402@chaitanyagupta.com> I can now see my changes in the repository through ViewCVS (http://common-lisp.net/cgi-bin/viewcvs.cgi/cl-selenium/?root=cl-selenium), but when I run cvs update on my machine I can't see them. Any reason why that would happen? Matthew Kennedy wrote: > Oops. Try now. > > Matt > > On Mon, May 19, 2008 at 12:42 AM, Chaitanya Gupta > wrote: > > >> I didn't see the new changes with cvs update. I had checked out the source >> using the following command: >> >> cvs -d >> :pserver:anonymous:anonymous at common-lisp.net:/project/cl-selenium/cvsroot co >> cl-selenium >> >> Is this correct? >> >> Chaitanya >> >> >> > _______________________________________________ > cl-selenium-devel mailing list > cl-selenium-devel at common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/cl-selenium-devel > From mkennedy at common-lisp.net Mon May 19 22:14:56 2008 From: mkennedy at common-lisp.net (Matthew Kennedy) Date: Mon, 19 May 2008 17:14:56 -0500 Subject: [cl-selenium-devel] Re: Returned values not handled correctly In-Reply-To: <48316C6B.6050402@chaitanyagupta.com> References: <482F6B65.5060805@chaitanyagupta.com> <48303F9C.4030102@chaitanyagupta.com> <9c1134b50805181039o66e67e60w86d29399f9fef9c9@mail.gmail.com> <4830FE77.7070207@chaitanyagupta.com> <9c1134b50805182222q7306daacv8193b3b7be8ec47@mail.gmail.com> <4831134D.3080308@chaitanyagupta.com> <9c1134b50805182338l583c5c94q826d437128ed56f2@mail.gmail.com> <48316C6B.6050402@chaitanyagupta.com> Message-ID: <9c1134b50805191514i5c48a752wc00b23ab839ecae8@mail.gmail.com> On Mon, May 19, 2008 at 7:02 AM, Chaitanya Gupta wrote: > I can now see my changes in the repository through ViewCVS > (http://common-lisp.net/cgi-bin/viewcvs.cgi/cl-selenium/?root=cl-selenium), > but when I run cvs update on my machine I can't see them. Any reason why > that would happen? I'm not sure why that would be. I tried an anonymous checkout just now and don't see the changes either. Perhaps there is considerable delay between a check-in and when it is mirrored to anonymous CVS. The cl-selenium-0.2.tar.gz has the latest CVS now though. Matt