[cl-plus-ssl-devel] patch to clean up error handling a bit

[Anton Vodonosov]

Hello Attila.

I don't see this fix:

> - fix: error queue was read at condition report time; cache it in the condition

What do you mean? That the error queue was only read when 
the condition :report function was called? 

But in the version prior to your commit error queue was read by ssl-signal-error
immediately, and stored in a condition slot (i.e. cached, the same as in your 
commit with the only difference it was cached as as string of user-readable messages,
instead of list of error codes as you did).

Strange thing is that I remember I previously had impression the code has
the bug you mention, but now I don't see it in the code...

Could you point me to the key change regarding this fix?

Best regards,
- Anton

05.09.2011, 03:03, "Attila Lendvai" <attila.lendvai at gmail.com>:
> dear list,
>
> please take a look a the following patch and consider inclusion:
>
> http://dwim.hu/gitweb/gitweb.cgi?p=cl-plus-ssl;a=summary
>
> - clean up error handling a bit
> - fix: error queue was read at condition report time; cache it in the condition
> - make the ssl error queue available for error handlers (i need this
> to exclude from the log stuff like http hello's and unknown
> certificates).
>
>  conditions.lisp |   64 ++++++++++++++++++++++++++++++++++--------------------
>  random.lisp     |    2 +-
>  2 files changed, 41 insertions(+), 25 deletions(-)
>
> --
>  attila
>
> Notice the erosion of your (digital) freedom, and do something about it!
>
> PGP: 2FA1 A9DC 9C1E BA25 A59C  963F 5D5F 45C7 DFCD 0A39
> OTR XMPP: 8647EEAC EA30FEEF E1B55146 573E52EE 21B1FF06
>
> _______________________________________________
> cl-plus-ssl-devel mailing list
> cl-plus-ssl-devel at common-lisp.net
> http://lists.common-lisp.net/cgi-bin/mailman/listinfo/cl-plus-ssl-devel