From avodonosov at yandex.ru  Mon Nov 28 04:10:48 2011
From: avodonosov at yandex.ru (Anton Vodonosov)
Date: Mon, 28 Nov 2011 08:10:48 +0400
Subject: [cl-json-devel] asdf:load-op for tests (cl-json.test) not only
	loads test code, but tries to run it (with errors)
Message-ID: <747581322453448@web59.yandex.ru>

Hello.

I want to integrate cl-json tests into a bigger test suite.

There is a small problem in cl-json.test system definition.

I expect that I load the tests code by 

(asdf:operate 'asdf:load-op :cl-json.test)

And the call FiveAM test runner (I can not just use asdf:test-op because it doesn't
return any test status).

But (asdf:operate 'asdf:load-op :cl-json.test) tries to not only load, but also to to execute the 
tests code, because file testjson.lisp is included into the cl-json.test system. The file 
contains just 

        (in-package :json-test)
        (run! 'json)

It is obviously a mistake, moreover running the tests require *json-test-files-path*
to be initialized, but this happens only in the :after method of load-op.

Best regards,
- Anton 



From rpgoldman at sift.info  Mon Nov 28 14:22:28 2011
From: rpgoldman at sift.info (Robert Goldman)
Date: Mon, 28 Nov 2011 08:22:28 -0600
Subject: [cl-json-devel] asdf:load-op for tests (cl-json.test) not only
 loads test code, but tries to run it (with errors)
In-Reply-To: <747581322453448@web59.yandex.ru>
References: <747581322453448@web59.yandex.ru>
Message-ID: <4ED39924.20704@sift.info>

On 11/27/11 Nov 27 -10:10 PM, Anton Vodonosov wrote:
> Hello.
> 
> I want to integrate cl-json tests into a bigger test suite.
> 
> There is a small problem in cl-json.test system definition.
> 
> I expect that I load the tests code by 
> 
> (asdf:operate 'asdf:load-op :cl-json.test)
> 
> And the call FiveAM test runner (I can not just use asdf:test-op because it doesn't
> return any test status).
> 
> But (asdf:operate 'asdf:load-op :cl-json.test) tries to not only load, but also to to execute the 
> tests code, because file testjson.lisp is included into the cl-json.test system. The file 
> contains just 
> 
>         (in-package :json-test)
>         (run! 'json)
> 
> It is obviously a mistake, moreover running the tests require *json-test-files-path*
> to be initialized, but this happens only in the :after method of load-op.

Yes, you should be able to simply remove that file from the build system.

This line from the test system definition:

  :in-order-to ((test-op (load-op "cl-json.test")))

can also go, as this dependency (in order to do a test-op you need to do
the load-op first) is now imposed by asdf.'

I have not been able pull from the project darcs repo this morning.  Is
anyone else having this problem?

cheers,
r



From avodonosov at yandex.ru  Mon Nov 28 23:37:06 2011
From: avodonosov at yandex.ru (Anton Vodonosov)
Date: Tue, 29 Nov 2011 03:37:06 +0400
Subject: [cl-json-devel] test failure: JSON-BIND-IN-BIND-BUG
Message-ID: <356171322523426@web1.yandex.ru>

Hello. 

After running the tests I have one failure. Is it a known issure?

.............
 Did 170 checks.
    Pass: 169 (99%)
    Skip: 0 ( 0%)
    Fail: 1 ( 0%)

 Failure Details:
 --------------------------------
 JSON-BIND-IN-BIND-BUG []: 
      RESULT2 evaluated to "(0 ((ID . pingId) (NAME . ping)) NIL
            (((NAME . tableTennisGroupName) (ID . tableTennisGroupId))))", which is not STRING= to "(0 NIL NIL (NIL))"..
 --------------------------------



From henrik at evahjelte.com  Tue Nov 29 08:09:28 2011
From: henrik at evahjelte.com (Henrik Hjelte)
Date: Tue, 29 Nov 2011 09:09:28 +0100
Subject: [cl-json-devel] test failure: JSON-BIND-IN-BIND-BUG
In-Reply-To: <356171322523426@web1.yandex.ru>
References: <356171322523426@web1.yandex.ru>
Message-ID: <CACfvCrjLdcg7+4CfEL5eVDaf_QfCxMmJ26c8OeFVUKUaNpW4FA@mail.gmail.com>

On Tue, Nov 29, 2011 at 12:37 AM, Anton Vodonosov <avodonosov at yandex.ru> wrote:
> Hello.
>
> After running the tests I have one failure. Is it a known issure?

Yes this is known, waiting for a solution.