[cl-json-devel] One more test patch

Robert Goldman rpgoldman at sift.info
Sat Jan 2 22:49:29 UTC 2010


On 1/2/10 Jan 2 -4:42 PM, Robert Goldman wrote:
> I have found that there are some problems with allegro like CMU's
> limitation on not having keywords naming slots, and on MacOSX (even
> 64-bit) some problems with very large numbers.
> 

> 
> The other three all seem to have to do with numeric overflows like the
> ones I commented out in the attached patch.  Since these are baked into
> the files, I wasn't sure how to fix this.
> 
> The problem seems to be that Allegro blows up with numeric overflows in
> the read-from-string call in parse-number and, unfortunately, the error
> isn't one of the two that cl-json tests for: (or reader-error #+ecl
> arithmetic-error).  Yet more unfortunately, there is no nice error class
> here hoisted by ACL for CL-JSON to detect; ACL just raises a
> simple-error.....
> 
> I have a kludgy patch for this, but I can't say I'm really happy with it.
> 
> Also, the code in the tests seems to assume that there will be an error
> of condition class floating-point-overflow raised, but alas, that isn't
> what's raised here.
> 

OK, this actually seems like it is an allegro bug.  I don't seem to be
able to persuade allegro to raise a floating-point-overflow error.

I will contact Franz and see what they say.

best,
r




More information about the cl-json-devel mailing list