[PATCH 2/2] Fix iteration of brokers at path /

Kambiz Darabi darabi at m-creations.com
Wed Jul 1 10:41:19 UTC 2015


Hi Attila,

On 2015-06-30 19:06 CEST, Attila Lendvai <attila at lendvai.name> wrote:

> hi Kami,
>
> i've rolled back the session-count defgeneric stuff, but that patch
> contains all kinds of unrelated (and not really convincing) changes.
> although, one could argue that any accidentally recorded change
> automatically smells fishy... :)

yes, sorry.

> i've rolled back this one:
> ...
>
> note that recording these random changes into an unrelated patch now
> makes it impossible for me to pull a fix of the .asd without also
> pulling all the entry-point related changes. they may potentially
> break the service and thus i wanted to leave them in HEAD and not pull
> them to LIVE. please pay attention to this!

Will do in future.

> also note that adding two new dependencies to the .asd is a big
> change. the websocket stuff should have gone into a separate asd
> system, and i've done that.

Thanks.

> please don't use such generic names like READ-HANDLE-LOOP in the
> web-server package. either set up a separate package for the
> subsystem, or avoid using potentially confusing names. i've recorded
> separate patches that you can look at for more details.

Yes, some of the names are indeed too generic. I wasn't paying attention
to the namespace pollution.

> the rest in the patches and on IRC,

Thanks


Kami



More information about the cl-dwim-devel mailing list