From edi at agharta.de Thu Aug 5 19:32:48 2010 From: edi at agharta.de (Edi Weitz) Date: Thu, 5 Aug 2010 21:32:48 +0200 Subject: [cl-debian] [ann] [drakma-announce] New release 1.2.3 [Was: duplicate cookies problem with proposed patch] Message-ID: Thanks for the patch. I'm back from vacation now and I've just released 1.2.3 which fixes this. Edi. On Thu, Jul 29, 2010 at 11:22 AM, Vsevolod Dyomkin wrote: > Hi, > > I want to re-raise the topic of duplicate cookies.? I've had this issue with > the older version of Drakma (1.1.0) and was unaware of the patch with > *remove-duplicate-cookies-p*. > But investigating the problem (before I've read the discussion in the > mailing list), I've encountered it's cause in the source code, that is > highlighted in the attached diff.? The problem is, that SET-DIFFERENCE and > UNION are not supplied COOKIE= tests in UPDATE-COOKIES. > > It still remains in the current version (1.2.2) and can be tested like this: > > CL-USER> (defvar *cookies* (make-instance 'drakma:cookie-jar)) > *COOKIES* > CL-USER> (drakma::update-cookies (list (make-instance 'drakma:cookie :name > "lang" :value "en" :domain "site.com" :path "/") > ????????????????????????????????????? (make-instance 'drakma:cookie :name > "lang" :value "en" :domain "site.com" :path "/")) > ??????????????????????????????? *cookies*) > # > > I think, that this is a bug, because without the TEST argument, for example, > SET-DIFFERENCE in this case will constantly return the first set (see > below), so either the code should be simplified or the test argument should > be added. > > CL-USER> (set-difference (list (make-instance 'drakma:cookie :name "lang" > :value "en" :domain "site.com" :path "/") > ????????????????????????????? (make-instance 'drakma:cookie :name "lang" > :value "en" :domain "site.com" :path "/")) > ??????????????????????? (list (make-instance 'drakma:cookie :name "lang" > :value "en" :domain "site.com" :path "/") > ????????????????????????????? (make-instance 'drakma:cookie :name "lang" > :value "en" :domain "site.com" :path "/"))) > (# > ?#) > > So, I believe, that this part should also be fixed, especially, since > UPDATE-COOKIES is called alongside with GET-COOKIES. > > Best regards, > Vsevolod > > _______________________________________________ > drakma-devel mailing list > drakma-devel at common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel > > _______________________________________________ drakma-announce mailing list drakma-announce at common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-announce _______________________________________________ announcements site list announcements at common-lisp.net http://common-lisp.net/mailman/listinfo/announcements From edi at agharta.de Tue Aug 24 07:26:06 2010 From: edi at agharta.de (Edi Weitz) Date: Tue, 24 Aug 2010 09:26:06 +0200 Subject: [cl-debian] [ann] [hunchentoot-announce] New release 1.1.1 [Was: usocket:timeout-errors and *catch-errors-p*] Message-ID: On Tue, Aug 24, 2010 at 8:48 AM, Edi Weitz wrote: > I was meaning to make a new release but didn't get around to actually > doing it. ?Maybe I should just do it now... Version 1.1.1 of Hunchentoot is now available from http://weitz.de/. Edi. _______________________________________________ tbnl-announce site list tbnl-announce at common-lisp.net http://common-lisp.net/mailman/listinfo/tbnl-announce _______________________________________________ announcements site list announcements at common-lisp.net http://common-lisp.net/mailman/listinfo/announcements