[cl-debian] Bug#349980: cl-gd: links to libfreetype6, which is going away

[Steve Langasek]

Package: cl-gd
Version: 0.4.2-3
Severity: grave
Tags: patch

Hi Peter,

The cl-gd package currently depends on libfreetype6, but it doesn't use
it.  This dependency is being pulled in because you're using a custom linker
line in debian/rules that pulls in libraries that aren't used in your code.

Since the only lib used by your library is libgd, I've attached a patch
which discards all of the other libs from the line, uses gcc instead of ld
for linking (strongly recommended upstream unless you know there's a
specific reason to bypass gcc's logic here), and adds -Wl,-zdefs as an extra
safeguard to ensure that no other libraries are missing.

The patch changes the binary package dependencies from this:

 Depends: common-lisp-controller (>= 4.2), cl-uffi (>= 1.3.4), libc6 (>= 2.3.5-1), libfreetype6 (>= 2.1.5-1), libgd2-xpm (>= 2.0.33), libjpeg62, libpng12-0 (>= 1.2.8rel), zlib1g (>= 1:1.2.1)

to this:

 Depends: common-lisp-controller (>= 4.23), cl-uffi (>= 1.3.4), libc6 (>= 2.3.5-1), libgd2-xpm (>= 2.0.33)

with, indeed, no loss of functionality AFAICT.

Although libfreetype6 is currently available in unstable, due to bug #314385
it is very likely that this package will have to go through a library
transition in the near future.  Since cl-gd doesn't use freetype, I'm filing
this bug at "grave" severity pre-emptively, to encourage you to get your
package free of the transition before it starts.  Please fix this bug at
your earliest convenience.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon at debian.org                                   http://www.debian.org/
-------------- next part --------------
diff -u cl-gd-0.4.2/debian/changelog cl-gd-0.4.2/debian/changelog
--- cl-gd-0.4.2/debian/changelog
+++ cl-gd-0.4.2/debian/changelog
@@ -1,3 +1,11 @@
+cl-gd (0.4.2-3.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Use gcc for linking in debian/rules, and don't link to a bunch of
+    libs not needed by the code!
+
+ -- Steve Langasek <vorlon at debian.org>  Thu, 26 Jan 2006 04:03:36 -0800
+
 cl-gd (0.4.2-3) unstable; urgency=low
 
   * Peter Van Eynde
diff -u cl-gd-0.4.2/debian/rules cl-gd-0.4.2/debian/rules
--- cl-gd-0.4.2/debian/rules
+++ cl-gd-0.4.2/debian/rules
@@ -25,7 +25,7 @@
 	dh_testdir
 	# Add here commands to compile the package.
 	gcc -fPIC -c $(lib-base).c
-	ld -lgd -lz -lpng -ljpeg -lfreetype -lm -lc -shared $(lib-base).o -o $(lib-base).so
+	gcc -Wl,-zdefs -shared -o $(lib-base).so $(lib-base).o -lgd
 	touch build-stamp
 
 clean:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <https://mailman.common-lisp.net/pipermail/cl-debian/attachments/20060126/c6906ff2/attachment.sig>