From kai.kaminski at gmx.de Sun Sep 24 20:04:24 2006 From: kai.kaminski at gmx.de (Kai Kaminski) Date: Sun, 24 Sep 2006 22:04:24 +0200 Subject: [cl-containers-devel] Bug in PREDECESSOR? Message-ID: Hi Gary, first of all I'd like to thank you for your amazing work. I'm just blown away by the scope and quality. The potential bug I'm referring to manifests itself when calling PREDECESSOR for an item that can't be found in the container (say a binary search tree). In that case the method for (PREDECESSOR CONTAINER-USES-NODES-MIXIN T) is called (that's ok), which in turn calls SEARCH-FOR-NODE. That call returns NIL, since the item can't be found, which leads to another call to (PREDECESSOR CONTAINER-USES-NODES-MIXIN T). Calling PREDECESSOR for an item that's not in the container might not make much sense, but I believe that it shouldn't hang. I would have sent you a patch, but I'm not sure how to fix this, because I'm not sure what PREDECESSOR should do: signal a condition or return NIL. The same behaviour affects SUCCESSOR. I tried to write a LIFT testcase, but my LIFT doesn't seem to understand the :TIMEOUT clause. Thanks again, Kai From gwking at metabang.com Mon Sep 25 11:10:14 2006 From: gwking at metabang.com (Gary King) Date: Mon, 25 Sep 2006 07:10:14 -0400 Subject: [cl-containers-devel] Bug in PREDECESSOR? In-Reply-To: References: Message-ID: <1CCF966E-6078-421D-82A0-D7D4F35678F1@metabang.com> Hi Kai, Thanks for the bug report; > first of all I'd like to thank you for your amazing work. I'm just > blown away by the scope and quality. Thanks for the kind words; I'm glad you find it useful. > The potential bug I'm referring to manifests itself when calling > PREDECESSOR for an item that can't be found in the container You're right and your analysis is spot on. > I'm not > sure what PREDECESSOR should do: signal a condition or return NIL. I think a condition would make more sense... > I tried to write a LIFT testcase, but my LIFT doesn't seem to > understand the :TIMEOUT clause. > This will be fixed in the next update of LIFT. (yeah!) I hope to get an update of both LIFT and cl-containers out today. thanks again, -- Gary Warren King, metabang.com Cell: (413) 885 9127 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM From gwking at metabang.com Mon Sep 25 15:33:11 2006 From: gwking at metabang.com (Gary King) Date: Mon, 25 Sep 2006 11:33:11 -0400 Subject: [cl-containers-devel] new version - 0.9.1 Message-ID: Various updates and bug fixes... enjoy. Note that I now have a new public key (see http:// unclog.metabang.com/ for details). -- Gary Warren King, metabang.com Cell: (413) 885 9127 Fax: (206) 338-4052 gwkkwg on Skype * garethsan on AIM