From asf at boinkor.net  Thu Apr 16 10:02:58 2009
From: asf at boinkor.net (Andreas Fuchs)
Date: Thu, 16 Apr 2009 12:02:58 +0200
Subject: [cl-bench-devel] [patch] refactor files/arrays.lisp to make
	runs specifiable in tests.lisp
In-Reply-To: <b59bc8ff0904160258g220aead4id4e221b33a233e05@mail.gmail.com>
References: <b59bc8ff0904160258g220aead4id4e221b33a233e05@mail.gmail.com>
Message-ID: <b59bc8ff0904160302s3d8d4e58k3e621b646704028a@mail.gmail.com>

On Thu, Apr 16, 2009 at 11:58, Andreas Fuchs <asf at boinkor.net> wrote:
> Hi there,

Argh, silly me for sending stale patches. One benchmark specification
had its :setup clause messed up, the attached patch fixes this.

Cheers,
-- 
Andreas Fuchs, (http://|im:asf@|mailto:asf@)boinkor.net, antifuchs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pull-runs-from-array-benchmarks-fixed.patch
Type: application/octet-stream
Size: 10806 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/cl-bench-devel/attachments/20090416/ea34ea27/attachment.obj>

From asf at boinkor.net  Thu Apr 16 09:58:37 2009
From: asf at boinkor.net (Andreas Fuchs)
Date: Thu, 16 Apr 2009 11:58:37 +0200
Subject: [cl-bench-devel] [patch] refactor files/arrays.lisp to make runs
	specifiable in tests.lisp
Message-ID: <b59bc8ff0904160258g220aead4id4e221b33a233e05@mail.gmail.com>

Hi there,

arrays.lisp is the odd benchmark group out when it comes to specifying
the number of runs: It has optional RUNS arguments in the defuns in
files/arrays.lisp. That makes it a bit of a pain to keep the run
numbers in sync with run times on modern machines. Also, it means
these benchmarks keep their setup code inside the benchmark function:
not a good thing.

The attached patch aims to fix this by defining a
cl-bench.arrays::bench-<something>-setup function that initializes the
arrays bound in a LET form surrounding the actual benchmark defun. At
least in my limited setup, it caused a slight reduction of test run
length variances, and it makes things a lot easier to maintain.

Cheers,
-- 
Andreas Fuchs, (http://|im:asf@|mailto:asf@)boinkor.net, antifuchs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pull-runs-from-array-benchmarks.patch
Type: application/octet-stream
Size: 10813 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/cl-bench-devel/attachments/20090416/eeeb90f0/attachment.obj>