[cffi-devel] Reviewing cffi-libffi

[Liam Healy]

Luís,

Since the last email, I have created a function mem-aptr that returns the
pointer of an array of structures and therefore reproduces the behavior of
mem-aref with the deprecated bare struct reference.   I wrote documentation
for this function.  I've tested the new function, and I think that it does
the right thing.  I also renamed the branch to "libffi"; the fsbv branch is
now dead.  Can you review to see that it looks right?  Also, please add
some official tests that test this function.

My next step would be to merge master into libffi to integrate the changes
there since I branched off, but I'd hold off doing that until near the time
that we would do the reverse (merge libffi into master) in case there are
further changes in master.   Are there any issues you can foresee in doing
these merges?

Liam


On Sat, Feb 11, 2012 at 4:20 PM, Liam Healy <lhealy at common-lisp.net> wrote:

> Luis,
>
> I've managed to go through this list and make all the changes that I knew
> how to do and didn't require much research for me.  Here is a summary of
> what I have done, with the git commit to the fsbv branch:
>
> 9d1d5b5 Rename system to cffi-libffi, add restart to default
> *foreign-structures-by-value*
> 95052e5 Use hash table for libffi-type-pointer
> 4b5d7fb Moved slots-in-order after foreign-struct-type, clean up
> libffi-*.lisp
> 953fbaf Fix conditionalization syntax in cffi-fsbv.asd
> cc73a6f Add Windows grovel file
> 1ff74af Eliminate package cffi-fsbv, put :sizet in keyword package
>
> Do these changes address your concerns?  Can you test?
>
> Thanks,
>
> Liam
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/cffi-devel/attachments/20120311/5b466056/attachment.html>