From madnificent at gmail.com Wed May 5 14:46:38 2010 From: madnificent at gmail.com (madnificent) Date: Wed, 5 May 2010 16:46:38 +0200 Subject: [bknr-devel] Fwd: searching intervals, sorting and invalid-store-random-state signaled when opening a store In-Reply-To: References: Message-ID: Hello, I just confirmed the bugfix Paul-Virak Khuong for SBCL. I guess the commit will make it through the next release of SBCL, you can playtest it through clbuild. With respect to the indices, can a skiplist return a range of objects? Or would it be best to do that by mapping over the objects in the index? (eg: show the posts for a particular user if there'd be an index on post-date). If there currently isn't anything like this: Have you thought about this and found it useless or would it be a good thing to have? Have you thought about a syntax which you'd prefer for sorted results? thanks, the madnificent On Mon, Apr 26, 2010 at 11:13 AM, Hans H?bner wrote: > On Mon, Apr 26, 2010 at 08:07, ? wrote: >> Searching Intervals: >> Is there some sort of index or a common idiom to search for all objects in >> which a specified property's value lies within a certain interval? ?For >> instance: listing/mapping over all widgets which have been created between >> monday and wednesday. ?Or all exams of a particular pupil which were scored >> between 35 and 56. ?Or should I create filters based on the index-mapvalues >> and index-values? > > There is the skip-list-index which has been designed to deal with > ranges and sparse integer valued slots. ?The skip-list has a > skip-list-range-cursor class that can be used to iterate over value > ranges. ?It is not exposed by the store itself, though, so you'll need > to get the index instance from the class that you want to query and > then call the skip-list-range-index gf on that object. > >> Sorting: >> Does an index's index-reader (for instance a string-unique-index (but I'd >> like to know for others as well)) guarantee something with respect to the >> order in which the results are mapped/listed? ?If not: is there some idiom >> to receive a sorted list or should I create a custom index to limit the >> amount of sorting? > > The order is determined by the underlying index, i.e. hash tables do > not provide ordering, but array indices and skip lists do. > >> Condition Signaled: >> Whenever I restart my lisp image in slime and open a previously used store, >> I receive an invalid-store-random-state in SBCL 1.0.37. ?Two meaningful >> restarts are given, being initialize-store-random-state and >> ignore-store-random-state. ?Is there something obvious I'm doing wrong or is >> this a bug of some sort? > > This is a bug, and I think I briefly saw it a few months ago but did > not have the time to fix it. ?As far as I remember, SBCL's random > state can no longer be serialized/deserialized with read/write (see > data/txn.lisp). ?I'd welcome a patch. > > Thanks, > Hans > From hans.huebner at gmail.com Fri May 7 07:58:11 2010 From: hans.huebner at gmail.com (=?ISO-8859-1?Q?Hans_H=FCbner?=) Date: Fri, 7 May 2010 09:58:11 +0200 Subject: [bknr-devel] Fwd: searching intervals, sorting and invalid-store-random-state signaled when opening a store In-Reply-To: References: Message-ID: On Wed, May 5, 2010 at 16:46, madnificent wrote: > With respect to the indices, can a skiplist return a range of objects? > ?Or would it be best to do that by mapping over the objects in the > index? ?(eg: show the posts for a particular user if there'd be an > index on post-date). ?If there currently isn't anything like this: > Have you thought about this and found it useless or would it be a good > thing to have? ?Have you thought about a syntax which you'd prefer for > sorted results? I usually do not use indices for such applications, but rather collect the data into the right objects when it is created. In your application, every user object would contain a list of posts that the user made, propably sorted by reverse post date or similar. To read all posts made by a particular user in a certain time period, the post list would just be scanned. Given that the number of posts per user is relatively small, there is not much to be gained by an index. Indices make sense when you have a very large database that can't be meaningfully split into smaller pieces in advance. The ID slot of persistent objects is such a case. I also successfully used indices to organize access to 2D data that is access by geocoordinates. Note that often, you can achieve a better design when you abandon the idea of indices as being a service of the database and instead think about the data structures that you want to use to organize your data. With traditional, disk based databases, indices are complementary to storage and often form the architectural foundation for the database. With the bknr datastore, indices play a more specific role inside the storage layer and often offer no advantage when (ab-)used to build the application. Let me know if you still think that you want to use store indices. I may come up with an example how a skip list could be used, but it is not entirely straightforward. -Hans From fsmunoz at gmail.com Sun May 23 03:29:20 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Sun, 23 May 2010 04:29:20 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial Message-ID: Hi, I've recently came across bknr while searching for a persistence layer for a small toy program I'm making (which isn't even web based), and found it quite interesting and with a nicely laid-out documentation (well, for the datastore, indexing and XML bits, less so for the web component). While playing around trying to understand the several pieces (mainly the datastore) I got stuck in the XML tutorial (tutorial.lisp in xml-impex) at: (parse-xml-file "xml-impex/tutorial.xml" (list (find-class 'book))) To reach that point I had to change (asdf:oos 'asdf:load-op :bknr-impex) to (asdf:oos 'asdf:load-op :bknr.impex). I always get the following error: The value NIL is not of type CXML::DTD. [Condition of type TYPE-ERROR] I'm not entirely sure if this is a problem on my end, or if the tutorial is outdated. I'm using SBCL 1.0.35-3 in Fedora 12 FWIW, plus a recent svn tree. Any pointers are appreciated, and I'm of course more than happy to provide any further information if this is indeed something that shouldn't occur. Best regards, Frederico From hans.huebner at gmail.com Sun May 23 04:53:20 2010 From: hans.huebner at gmail.com (=?ISO-8859-1?Q?Hans_H=FCbner?=) Date: Sun, 23 May 2010 06:53:20 +0200 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi Frederico, the XML import/export functionality has long regressed because it is unused, and I can't easily resurrect it. I never used the import aspect of the XML impex facility and at some point switched to writing specialized exporters for those formats that I need (i.e. http://bknr.net/trac/browser/trunk/projects/bos/m2/export.lisp#L94). I'm sorry that the documentation and source code still gives the misleading impression that there is an XML import/export facility. I'm going to make a little update to indicate the state of this subsystem. Did you have specific requirements for the impex facility? -Hans On Sun, May 23, 2010 at 05:29, Frederico Mu?oz wrote: > Hi, > > I've recently came across bknr while searching for a persistence layer > for a small toy program I'm making (which isn't even web based), and > found it quite interesting and with a nicely laid-out documentation > (well, for the datastore, indexing and XML bits, less so for the web > component). > > While playing around trying to understand the several pieces (mainly > the datastore) I got stuck in the XML tutorial (tutorial.lisp in > xml-impex) at: > > (parse-xml-file "xml-impex/tutorial.xml" (list (find-class 'book))) > > To reach that point I had to change > > (asdf:oos 'asdf:load-op :bknr-impex) to (asdf:oos 'asdf:load-op :bknr.impex). > > I always get the following error: > > The value NIL is not of type CXML::DTD. > ? [Condition of type TYPE-ERROR] > > I'm not entirely sure if this is a problem on my end, or if the > tutorial is outdated. > > I'm using SBCL 1.0.35-3 in Fedora 12 FWIW, plus a recent svn tree. Any > pointers are appreciated, and I'm of course more than happy to provide > any further information if this is indeed something that shouldn't > occur. > > Best regards, > > Frederico > > _______________________________________________ > bknr-devel mailing list > bknr-devel at common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/bknr-devel > From fsmunoz at gmail.com Sun May 23 22:34:56 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Sun, 23 May 2010 23:34:56 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi Hans, First of all my thank you for your quick reply, it seems that we both are awake at odd hours ;) 2010/5/23 Hans H?bner : > Hi Frederico, > > the XML import/export functionality has long regressed because it is > unused, and I can't easily resurrect it. I see, I sort of suspected that that might be a possibility, hence my initial message. It's quite natural for some "code rot" to settle in in areas that aren't used. >?I never used the import > aspect of the XML impex facility and at some point switched to writing > specialized exporters for those formats that I need (i.e. > http://bknr.net/trac/browser/trunk/projects/bos/m2/export.lisp#L94). Right, I'm not familiar with cxml (well, I'm barely familiar with Lisp) but I understand the general idea. > I'm sorry that the documentation and source code still gives the > misleading impression that there is an XML import/export facility. > I'm going to make a little update to indicate the state of this > subsystem. No problem at all, documentation in general lags a bit when code changes frequently. > Did you have specific requirements for the impex facility? That's a good question actually... at this stage I do not have any specific requirements. Without burdening you with details which aren't of interest this is merely a "pet project", an idea that I had about a strategy game, and which I'm using as a way to actually use Lisp a bit more. As such I'm still in the early stages and do not have specific requirements, or at least they are so vague that they are bound to change drastically. I'm not a big fan of XML, although in recent times I've came to at least recognise that it is useful as a way to exchange data, and with templating adapting it to different output forms. With that in mind the XML impex in the bknr documentation appeared as something that could be useful, but I can also use something else (like specialised importers/exporters, as you said). I have a more general question though, which I hope you don't mind me asking: in general terms do you have plans to maintain the bknr datastore (I didn't yet investigate the web part of it, which I understand is done mainly by reading the code), or is it something that you see has having served its purpose? I'm only asking because it's quite natural for developers to reach a point where they change focus, even in terms of the language they use, let alone specific frameworks. I've actually learned quite a bit by reading the bknr documentation, and even listening to the audio of the 2008 Lisp conference that you gave, so in several ways bknr has already been quite useful to me, and I can only thank you in making it available. Since I'm on the very early stages of my project this is relatively important to me (relatively because this is not something that I do professionally, unlike you, and as such not even guaranteed to be finished). Best regards, Frederico From fsmunoz at gmail.com Sun May 23 23:53:34 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Mon, 24 May 2010 00:53:34 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi Hans, 2010/5/24 Hans H?bner : > Hi Frederico, > > the problem with maintaining the datastore is keeping up with compiler > changes. ?I do have some deployed applications (using SBCL), and I > plan to use it (with CCL) in the nearer future. ?Whenever I'm working > on something new or do a major update on my deployed applications, the > store will receive some love. ?I cannot make any predictions or > promises if and how this will happen, but I am not considering the > project to be closed. Perfect, that's all I needed to hear, and I'm glad you didn't take my question the wrong way. As long as you plan to continue using it than I'm a happy camper. Best regards, Frederico From hans.huebner at gmail.com Sun May 23 23:31:40 2010 From: hans.huebner at gmail.com (=?ISO-8859-1?Q?Hans_H=FCbner?=) Date: Mon, 24 May 2010 01:31:40 +0200 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi Frederico, the problem with maintaining the datastore is keeping up with compiler changes. I do have some deployed applications (using SBCL), and I plan to use it (with CCL) in the nearer future. Whenever I'm working on something new or do a major update on my deployed applications, the store will receive some love. I cannot make any predictions or promises if and how this will happen, but I am not considering the project to be closed. Best, Hans From fsmunoz at gmail.com Tue May 25 20:02:24 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Tue, 25 May 2010 21:02:24 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hello, 2010/5/23 Hans H?bner : > the XML import/export functionality has long regressed because it is > unused, and I can't easily resurrect it. ?I never used the import > aspect of the XML impex facility and at some point switched to writing > specialized exporters for those formats that I need (i.e. > http://bknr.net/trac/browser/trunk/projects/bos/m2/export.lisp#L94). For some odd reason I've been looking at the xml-impex code (well, one of the reasons is that the documentation made it look really cool, even if I'm not even sure if I'm actually going to use it :) ), and have it kind of working... I'm using the tutorial output as a guide, which makes it a bit easier. I've added some missing functions (children-to-initforms, etc), massaged some cxml parameters here and there (small API changes) and I've successfully imported objects, which is, well, cool. Now, since you don't use the facility I don't want to burden you with doubts concerning a subsystem that you've deprecated; although my Lisp skills are sub-par I'm more or less enjoying the code (even if it is a bit hairy here and there, especially since I don't even have experience with SAX). I have one very general doubt though that perhaps you could eventually (time permitting) address: I've been reading former revisions in order to understand the changes, and there was a quite large rework some time ago. Of particular importance is that it *seems* (and, again, the compounding of my poor grasp of Lisp, XML, SAX and programming in general could be at work here...) that the way to use it was actually going to change in terms of the exporter: whereas before write-to-xml was self-sufficient in terms of generating output (as in the tutorial), I've noticed that code re-factoring seems to indicate that with-xml-export/with-xml-export* would be the entry point for a user. What's leading me to this conclusion is the fact that the cxml sink is only created in those macros. I also note the presence of an *objects-written* hash-table (which is supposed to be updated, but isn't). I've got the exporter also working (well, mildly, it at least produces the expected output for the first part of the tutorial), but I was hoping you could shed some light on what was your plan with the changes above. I'm not asking for code, just a general idea of what was the goal you were going for. Knowing that I can work on implementing those changes, instead of somewhat reverting the code to fit the tutorial (which could be changed). Best regards, Frederico From hans.huebner at gmail.com Wed May 26 16:44:10 2010 From: hans.huebner at gmail.com (=?ISO-8859-1?Q?Hans_H=FCbner?=) Date: Wed, 26 May 2010 18:44:10 +0200 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi Frederico, first off, thank you for putting time into resurrecting the XML import/export facility. I'll happily review your patches and incorporate them into the main line once you think that they work well enough. 2010/5/25 Frederico Mu?oz : > II've been reading former revisions in order > to understand the changes, and there was a quite large rework some > time ago. Of particular importance is that it *seems* (and, again, the > compounding of my poor grasp of Lisp, XML, SAX and programming in > general could be at work here...) that the way to use it was actually > going to change in terms of the exporter: whereas before write-to-xml > was self-sufficient in terms of generating output (as in the > tutorial), I've noticed that code re-factoring seems to indicate that > with-xml-export/with-xml-export* would be the entry point for a user. > What's leading me to this conclusion is the fact that the cxml sink is > only created in those macros. I really can't remember what my plans were at the time, so if you can come up with an idea how the user interface should look like (or chose either of the two), I'd appreciate it. It may be that my wish to change the interface was related to memory usage with larger stores. Thanks! Hans From fsmunoz at gmail.com Wed May 26 17:06:07 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Wed, 26 May 2010 18:06:07 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi Hans, 2010/5/26 Hans H?bner : (...) > I really can't remember what my plans were at the time, so if you can > come up with an idea how the user interface should look like (or chose > either of the two), I'd appreciate it. ?It may be that my wish to > change the interface was related to memory usage with larger stores. OK, I'll try to come up with something sensible. I'll take a look at use-case scenarios (both inside and outside bknr) to get an idea on how people generally use this sort of facilities, and try to make something sensible with it (and ideally not very removed from what is in the tutorial, that I found quite easy to follow). I can't vouch for either a deadline of code quality, but I think that if I can get it at least working for the examples in the tutorial it will be better than the current state. I'll keep you posted when I have something real to show. Regards, Frederico From fsmunoz at gmail.com Fri May 28 15:02:40 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Fri, 28 May 2010 16:02:40 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hello, 2010/5/27 Frederico Mu?oz : (...) > I'll go back at it and hope to have something to show soon (well, for > relative values of soon). Well, I have pulled some changes to my github fork. The good news is that the tutorial now works. However, I'm sure that my changes could have been done is some better way - the code is not easy for me to follow. There are different approaches to how to do the exporting: I've maintained write-to-xml as the main one. It outputs to *standard-output*, or to any sink that is passed to it. I've made it a a macro (that is compatible with the usage seen in the tutorial) and renamed the original write-to-xml to build-xml (since it doesn't actuall write anything by itself). I haven't tested it deeply, but it mostly works. I'm now trying to understand the code better and see if there is any part in there that is a left-over of previous rewrites, etc. One of the things I will surely do is to document the functions - and also document the whole conversion process, since the way it works is sometimes hard to track. Regards, Frederico From fsmunoz at gmail.com Fri May 28 15:27:50 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Fri, 28 May 2010 16:27:50 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hello, 2010/5/28 Hans H?bner : > Hi Frederico, > > thank you for your work! ?I have one request, though: Can you > reconfigure your emacs so that it does not insert tabs into source > files? ?It seems that some changes you made resulted in some > indentation changes and now the code looks ugly and badly indented > when inspected with the github web ui (i.e. > http://github.com/fsmunoz/bknr-datastore/commit/9639adbfed1050daee08dab8db2a3838d5648732#L0R80) > > (setq-default indent-tabs-mode nil) in your .emacs should do fine. Argh, sorry about that. I usually have that in my init.el, but I didn't yet copy it to my new installation. Will do another commit fixing that. > I'll review your changes and let you know if I think that there is > something which I'd like to see changed. ?I'm going to pull them over > into my repository once you think that the stuff is usable enough for > you. Yes, comments are extremely helpful, even general ones (of course, as time permits). There are several different possible approaches, I chose one, but it could be that there are some better ways. Code-wise it goes without saying that the same applies. Regards, Frederico From hans.huebner at gmail.com Fri May 28 15:14:15 2010 From: hans.huebner at gmail.com (=?ISO-8859-1?Q?Hans_H=FCbner?=) Date: Fri, 28 May 2010 17:14:15 +0200 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi Frederico, thank you for your work! I have one request, though: Can you reconfigure your emacs so that it does not insert tabs into source files? It seems that some changes you made resulted in some indentation changes and now the code looks ugly and badly indented when inspected with the github web ui (i.e. http://github.com/fsmunoz/bknr-datastore/commit/9639adbfed1050daee08dab8db2a3838d5648732#L0R80) (setq-default indent-tabs-mode nil) in your .emacs should do fine. I'll review your changes and let you know if I think that there is something which I'd like to see changed. I'm going to pull them over into my repository once you think that the stuff is usable enough for you. Thanks again! Hans 2010/5/28 Frederico Mu?oz : > Hello, > > 2010/5/27 Frederico Mu?oz : > (...) >> I'll go back at it and hope to have something to show soon (well, for >> relative values of soon). > > Well, I have pulled some changes to my github fork. The good news is > that the tutorial now works. However, I'm sure that my changes could > have been done is some better way - the code is not easy for me to > follow. > > There are different approaches to how to do the exporting: I've > maintained write-to-xml as the main one. It outputs to > *standard-output*, or to any sink that is passed to it. I've made it a > a macro (that is compatible with the usage seen in the tutorial) and > renamed the original write-to-xml to build-xml (since it doesn't > actuall write anything by itself). > > I haven't tested it deeply, but it mostly works. I'm now trying to > understand the code better and see if there is any part in there that > is a left-over of previous rewrites, etc. One of the things I will > surely do is to document the functions - and also document the whole > conversion process, since the way it works is sometimes hard to track. > > Regards, > > Frederico > From fsmunoz at gmail.com Fri May 28 16:16:50 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Fri, 28 May 2010 17:16:50 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi, Just one small detail: I've run untabify in the files, and pushed a commit with the changes. I'm new to git, but should I use rebase so ou can see the changes more easily, or is this enough? Regards, Frederico From fsmunoz at gmail.com Fri May 28 17:22:34 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Fri, 28 May 2010 18:22:34 +0100 Subject: [bknr-devel] (no subject) In-Reply-To: <4bffefbf.0e67f10a.4c0c.7897@mx.google.com> References: <4bffefbf.0e67f10a.4c0c.7897@mx.google.com> Message-ID: Hello, > If you push, hans can do git diff on the two relevant revisions. Ok then, thanks for the hint, I guess it suffices then. PS: I've added the list to the Cc, your mail seemed to indicate that that was your intention but somewhere along the line it appears that some router didn't like the format of your message. From hans.huebner at gmail.com Fri May 28 18:02:50 2010 From: hans.huebner at gmail.com (=?ISO-8859-1?Q?Hans_H=FCbner?=) Date: Fri, 28 May 2010 20:02:50 +0200 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: 2010/5/28 Frederico Mu?oz : > Just one small detail: I've run untabify in the files, and pushed a > commit with the changes. I'm new to git, > but should I use rebase so ou can see the changes more easily, or is > this enough? I'd prefer if you could eventually rebase your commits and squash them into one before I pull them. That way, the log will be easier to follow. I'll review the changes as they are later tonight if you don't manage to rebase them right away. Cheers, Hans From fsmunoz at gmail.com Fri May 28 18:49:48 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Fri, 28 May 2010 19:49:48 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi, 2010/5/28 Hans H?bner : > I'd prefer if you could eventually rebase your commits and squash them > into one before I pull them. ?That way, the log will be easier to > follow. ?I'll review the changes as they are later tonight if you > don't manage to rebase them right away. I've tried to, but I'm afraid I probably didn't do it correctly. I reset my master by using upstream/master, forced the push to github, switch to my wip branch, did a git rebase master. The switched to my local master, merged the wip branch, and did a push. >From reading the docs I was expecting something more akin to a single commit, which isn't the case. I'm likely missing a step, or doing one to many. Regards, Frederico From hans.huebner at gmail.com Fri May 28 18:58:45 2010 From: hans.huebner at gmail.com (=?ISO-8859-1?Q?Hans_H=FCbner?=) Date: Fri, 28 May 2010 20:58:45 +0200 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: With your changes on your local master and the github master reset to the old master, do a "git rebase -i origin/master". Squash all your commits into one, save and push to github. That should do. Let us know if it does not. -Hans Am 28.05.2010 20:49 schrieb "Frederico Mu?oz" : Hi, 2010/5/28 Hans H?bner : > I'd prefer if you could eventually rebase your commits and squash them > into one before I pull th... I've tried to, but I'm afraid I probably didn't do it correctly. I reset my master by using upstream/master, forced the push to github, switch to my wip branch, did a git rebase master. The switched to my local master, merged the wip branch, and did a push. >From reading the docs I was expecting something more akin to a single commit, which isn't the case. I'm likely missing a step, or doing one to many. Regards, Frederico -------------- next part -------------- An HTML attachment was scrubbed... URL: From fsmunoz at gmail.com Fri May 28 20:34:57 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Fri, 28 May 2010 21:34:57 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi, Thank you for the assistance, as I said I'm new to git. 2010/5/28 Hans H?bner : > With your changes on your local master and the github master reset to the > old master, do a "git rebase -i origin/master". Squash all your commits into > one, save and push to github. That should do. Let us know if it does not. It worked, I only had to keep one of the changes as "pick", and the others as "squash". Rebased with master, then merged my wip branch with master, then pushed. I think it worked as expected, all changes are in one commit. Regards, Frederico From hans.huebner at gmail.com Sat May 29 05:37:38 2010 From: hans.huebner at gmail.com (=?ISO-8859-1?Q?Hans_H=FCbner?=) Date: Sat, 29 May 2010 07:37:38 +0200 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi Frederico, the rebase seems to have worked fine. I reviewed your changes and made a few very minor comments in github. If you can take care of them, I'll happily pull into my repository, thanks! Cheers, Hans 2010/5/28 Frederico Mu?oz : > Hi, > > Thank you for the assistance, as I said I'm new to git. > > 2010/5/28 Hans H?bner : >> With your changes on your local master and the github master reset to the >> old master, do a "git rebase -i origin/master". Squash all your commits into >> one, save and push to github. That should do. Let us know if it does not. > > It worked, I only had to keep one of the changes as "pick", and the > others as "squash". > Rebased with master, then merged my wip branch with master, then > pushed. I think it worked > as expected, all changes are in one commit. > > Regards, > > Frederico > From fsmunoz at gmail.com Sat May 29 13:12:15 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Sat, 29 May 2010 14:12:15 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi Hans, 2010/5/29 Hans H?bner : > Hi Frederico, > > the rebase seems to have worked fine. ?I reviewed your changes and > made a few very minor comments in github. ?If you can take care of > them, I'll happily pull into my repository, thanks! Fixed in the latest commit; while the modifications I made are in hindsight relatively minor at one point I had debug output sprinkled all over in order to understand what was going on (hence also the differences in indentation in places where there are no changes... I used the default emacs indentation, but if you have special standards I will happily add them to my init.el when working on the tree). Regards, Frederico From hans.huebner at gmail.com Sun May 30 06:23:54 2010 From: hans.huebner at gmail.com (=?ISO-8859-1?Q?Hans_H=FCbner?=) Date: Sun, 30 May 2010 08:23:54 +0200 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi Frederico, I pulled your changes into my repository, thanks again! -Hans 2010/5/29 Frederico Mu?oz : > Hi Hans, > > 2010/5/29 Hans H?bner : >> Hi Frederico, >> >> the rebase seems to have worked fine. ?I reviewed your changes and >> made a few very minor comments in github. ?If you can take care of >> them, I'll happily pull into my repository, thanks! > > Fixed in the latest commit; while the modifications I made are in > hindsight relatively minor at one point I > had debug output sprinkled all over in order to understand what was > going on (hence also the differences > in indentation in places where there are no changes... I used the > default emacs indentation, but if you have > special standards I will happily add them to my init.el when working > on the tree). > > Regards, > > Frederico > From fsmunoz at gmail.com Mon May 31 16:53:47 2010 From: fsmunoz at gmail.com (=?ISO-8859-1?Q?Frederico_Mu=F1oz?=) Date: Mon, 31 May 2010 17:53:47 +0100 Subject: [bknr-devel] Problems with XML import/export, can't follow the tutorial In-Reply-To: References: Message-ID: Hi Hans, 2010/5/30 Hans H?bner : > I pulled your changes into my repository, thanks again! Splendid, I'm happy that my trivial work has been useful! I'm going to further test the changes and come up with a small list of enhancements/doubts, I'll try to be as succinct as possible. At this stage I only have one of each, which I will put here just to exemplify: 1) As it is write-to-xml defaults to *standard-output*. It seems sensible to me to do so, and one can always provide a different stream. The tutorial, however, seems to indicate that write-to-xml should return the XML output as a return value... not sure if adapting the tutorial is the best course, or changing the way write-to-xml works by using a string stream and returning the output (I've tried, it works, but returns everything escaped, which is aesthetically doubtful) 2) As it is one can't use lists (including cons) as slot values. I've found this by having a "location" slot in my "army" class which is represented by a cons like (X . Y). This returns an error (since the test is made with consp, but the cdr isn't a list). For cons the "fix" is easy (e.g. use alexandria's proper-list-p), but when a slot value is really a list the output isn't as expected: a class which has '(1 2 3) has a slot value will produce: 1 2 3 instead of what would be expected: '(1 2 3) I'm trying to find a way to deal with this. Ultimately one can always say that list values shouldn't be used. Again, there is no pressure in terms of replying to this observations: I'll continue to tackle them as I see fit (right or wrong), and then provide something more concrete which can be reviewed. Regards, Frederico