[bknr-cvs] ksprotte changed trunk/bknr/datastore/src/data/object.lisp

[BKNR Commits]

Revision: 3817
Author: ksprotte
URL: http://bknr.net/trac/changeset/3817

(deftransaction CHANGE-SLOT-VALUES ...) had been split into
(defun CHANGE-SLOT-VALUES ...) and (defun TX-CHANGE-SLOT-VALUES ...) in
http://bknr.net/trac/changeset/3037 to produce a warning only when
CHANGE-SLOT-VALUES is called (it is deprecated), whereas
TX-CHANGE-SLOT-VALUES is properly used in (SETF SLOT-VALUE-USING-CLASS).

I dont understand the reason for deprecating change-slot-values AND
making it at the same time non-functional.  It is still used by BOS
e.g. in edit-sponsor, so I changed it to still produce a warning, but
be functional again.

U   trunk/bknr/datastore/src/data/object.lisp

Modified: trunk/bknr/datastore/src/data/object.lisp
===================================================================
--- trunk/bknr/datastore/src/data/object.lisp	2008-09-05 16:25:53 UTC (rev 3816)
+++ trunk/bknr/datastore/src/data/object.lisp	2008-09-05 18:10:54 UTC (rev 3817)
@@ -716,12 +716,11 @@
 (defun change-slot-values (object &rest slots-and-values)
   "This function is the deprecated way to set slots of persistent
    objects."
-  (declare (ignore slots-and-values))
   (warn "CHANGE-SLOT-VALUES is deprecated - use WITH-TRANSACTION and standard accessors!")
   (execute (make-instance 'transaction
                           :function-symbol 'tx-change-slot-values
                           :timestamp (get-universal-time)
-                          :args (list object))))
+                          :args (list* object slots-and-values))))
 
 (defmethod prepare-for-snapshot (object)
   nil)