[bknr-cvs] r1830 - trunk/bknr/src/web

bknr at bknr.net bknr at bknr.net
Tue Feb 14 05:47:48 UTC 2006


Author: hhubner
Date: 2006-02-13 23:47:48 -0600 (Mon, 13 Feb 2006)
New Revision: 1830

Modified:
   trunk/bknr/src/web/handlers.lisp
Log:
Tchadvar Roussanov:

In order to compile bknr/src/web/handlers.lisp with the latest cxml
and sbcl, I either have to apply the change from svn to with-element
macro in cxml/xml/unparse.lisp: [...]

or change the handlers.lisp this way:

In other words move the evaluation of
xml-object-list-handler-toplevel-element-name out of the macro
expansion. I think the two changes are equivalent but the second one
has the advantage not to require to maintain changes to the third
party library.

I asked David Lichteblau whether he could change cxml to support
computed element names in with-element.  Meanwhile, this change
restores portability to the current cxml release.


Modified: trunk/bknr/src/web/handlers.lisp
===================================================================
--- trunk/bknr/src/web/handlers.lisp	2006-02-11 09:19:59 UTC (rev 1829)
+++ trunk/bknr/src/web/handlers.lisp	2006-02-14 05:47:48 UTC (rev 1830)
@@ -446,9 +446,10 @@
 		:string-rod-fn #'cxml::utf8-string-to-rod))
 
 (defmethod handle-object ((handler xml-object-list-handler) object req)
-  (cxml:with-element (xml-object-list-handler-toplevel-element-name handler)
-    (dolist (object (object-list-handler-get-objects handler object req))
-      (object-list-handler-show-object-xml handler object req))))
+  (let ((element-name (xml-object-list-handler-toplevel-element-name handler)))
+    (cxml:with-element element-name
+      (dolist (object (object-list-handler-get-objects handler object req))
+	(object-list-handler-show-object-xml handler object req)))))
 
 (defclass blob-handler (object-handler)
   ())




More information about the Bknr-cvs mailing list