[Bese-devel] Re: Patches for Allegro

[Earl J. Wagner]

Good point, thanks. Here are the updated diffs:

diff -rN -u old-ucw_dev/examples/forms.lisp new-ucw_dev/examples/ 
forms.lisp
--- old-ucw_dev/examples/forms.lisp     2006-03-27 14:44:47.509594282  
-0600
+++ new-ucw_dev/examples/forms.lisp     2006-03-27 14:44:47.538589484  
-0600
@@ -132,7 +132,7 @@
      (push (make-instance (value (select-field f))) (fields f))))

  (defaction delete-field ((f dynamic-form) field)
-  (setf (fields f) (delete fields (fields f))))
+  (setf (fields f) (delete field (fields f))))

  (defmethod render ((form dynamic-form))
    (<:table
diff -rN -u old-ucw_dev/src/admin/admin.lisp new-ucw_dev/src/admin/ 
admin.lisp
--- old-ucw_dev/src/admin/admin.lisp    2006-03-27 14:44:47.511593951  
-0600
+++ new-ucw_dev/src/admin/admin.lisp    2006-03-27 14:44:47.539589319  
-0600
@@ -23,7 +23,7 @@
    (<:hr)
    (render (admin-app.body app))
    (<:hr)
-  (<:A :href "index.ucw" "Back to admin entry."))
+  (<:a :href "index.ucw" "Back to admin entry."))

  (defclass admin-login (login)
    ()
diff -rN -u old-ucw_dev/src/backend/aserve.lisp new-ucw_dev/src/ 
backend/aserve.lisp
--- old-ucw_dev/src/backend/aserve.lisp 2006-03-27 14:44:47.512593785  
-0600
+++ new-ucw_dev/src/backend/aserve.lisp 2006-03-27 14:44:47.540589153  
-0600
@@ -91,11 +91,11 @@

  (defmethod shutdown ((request aserve-request)))

-#+#.(cl:if (cl:find-package "PURI") `(and) `(or))
+#+#.(cl:if (cl:find-package '#:puri) `(and) `(or))
  (defmethod query-path ((request aserve-request))
    (puri:uri-path (net.aserve:request-uri (request request))))

-#+#.(cl:if (cl:find-package "NET.URI") `(and) `(or))
+#+#.(cl:if (cl:find-package '#:net.uri) `(and) `(or))
  (defmethod query-path ((request aserve-request))
    (net.uri:uri-path (net.aserve:request-uri (request request))))

diff -rN -u old-ucw_dev/src/components/form.lisp new-ucw_dev/src/ 
components/form.lisp
--- old-ucw_dev/src/components/form.lisp        2006-03-27  
14:44:47.514593455 -0600
+++ new-ucw_dev/src/components/form.lisp        2006-03-27  
14:44:47.543588657 -0600
@@ -280,12 +280,12 @@
  ;;;; prevent generating large amounts of throw away strings.

  (defvar +string-index-cache+
-  (map-into (make-array 50
-                        :element-type 'string
-                        :adjustable t)
-            (let ((i -1))
-              (lambda ()
-                (princ-to-string (incf i))))))
+  (let ((initial-size 50))
+       (make-array initial-size :initial-contents
+                               (loop for i upto (1- initial-size)
+                                         collect (princ-to-string i))
+                               :element-type 'string
+                               :adjustable t)))

  (defun integer-to-string (i)
    (cond





On Mar 24, 2006, at 3:22 AM, Luís Oliveira wrote:

> "Earl J. Wagner" <earljwagner at alum.mit.edu> writes:
>> --- old-ucw_dev/src/backend/aserve.lisp 2006-03-23  
>> 18:43:16.954043774 -0600
>> +++ new-ucw_dev/src/backend/aserve.lisp 2006-03-23  
>> 18:43:16.992037539 -0600
>> @@ -95,7 +95,7 @@
>>   (defmethod query-path ((request aserve-request))
>>     (puri:uri-path (net.aserve:request-uri (request request))))
>>
>> -#+#.(cl:if (cl:find-package "NET.URI") `(and) `(or))
>> +#+#.(cl:if (cl:find-package "net.uri") `(and) `(or))
>
> This would break other lisps. Probably better:
>
>   (cl:find-package '#:net.uri)
>
>>   (defmethod query-path ((request aserve-request))
>>     (net.uri:uri-path (net.aserve:request-uri (request request))))
>
> -- 
> Luís Oliveira
> luismbo (@) gmail (.) com
> Equipa Portuguesa do Translation Project
> http://www.iro.umontreal.ca/translation/registry.cgi?team=pt
>
> _______________________________________________
> bese-devel mailing list
> bese-devel at common-lisp.net
> http://common-lisp.net/cgi-bin/mailman/listinfo/bese-devel