[Bese-devel] Re: Two patches for the window component

henrik hjelte henrik at evahjelte.com
Fri Feb 17 14:59:24 UTC 2006


On fre, 2006-02-17 at 13:54 +0100, Marco Baringer wrote:
> Henrik Hjelte wrote:
> > The ucw_public_apply.cgi darcs script complains about some conflict
> > in ./src/components/window.lisp when I try to apply these two small
> > changes to the window component. Maybe they can added manually?
> > 
> > First is a bugfix that inline javascript should be rendered as-is rather
> > than as html.
> > 
> > Then is a small addition to the window component. By specificing some
> > javascript inline-code as first-inline-javascript you can be sure that
> > it is executed first of all. I needed this for the dojo toolkit, which
> > presumes some parameters are set before the dojo.js file is included.
> 
> so now we have inline-javascript, javascript and
> first-inline-javascript, isn't this a bit much? 
yes, it's ugly.

> how about if we removed
> all three slots and left only javascript but changed it to work like this:
> 
> The javascript slot would be a list (and will be rendered in order)
> where each element is a list of:
> 
> (:SRC url) - generate a <script src="URL"></script>
> (:JS string) - generate a <script>STRING</script>
> 
> this will allow any weird comination of file loading/script evaluating
> should the need arise.

Now that's pretty! Why didn't I think of that?

/Henrik






More information about the bese-devel mailing list