[Bese-devel] Re: New patches to ucw_dev: 20-Apr-2006

[Luca Capello]

Hello!

On Fri, 21 Apr 2006 06:30:04 +0200, Marco Baringer wrote:
> Mon Apr 17 23:54:01 EDT 2006  atkinw at rpi.edu
>   * check for CL-LAUNCH at load-time instead of at runtime

This breaks `sbcl --load etc/start.lisp`:
=====

luca at gismo:~/Hacking/cl-debian/repository/ucw-upstream$ \ 
 darcs changes --last 2
Thu Apr 20 11:26:05 CEST 2006  Marco Baringer <mb at bese.it>
  * drop darcs' conflict markers

Tue Apr 18 05:54:01 CEST 2006  atkinw at rpi.edu
  * check for CL-LAUNCH at load-time instead of at runtime

luca at gismo:~/Hacking/cl-debian/repository/ucw-upstream$ \
 sbcl --load etc/start.lisp
[...]
; compiling file
  "/home/luca/Hacking/cl-debian/repository/ucw-upstream/src/default.lisp"
  (written 20 APR 2006 06:07:03 PM):
; compiling (IN-PACKAGE :IT.BESE.UCW-USER)
; compiling (WHEN (NOT #) ...)
debugger invoked on a SIMPLE-ERROR in thread
#<THREAD "initial thread" {A7F0591}>:
  Error during processing of --eval option (LOAD #P"etc/start.lisp"):

  The CL-Launch package was not found.

Type HELP for debugger help, or (SB-EXT:QUIT) to exit from SBCL.

restarts (invokable by number or by possibly-abbreviated name):
  0: [RETRY   ] Retry performing #<ASDF:COMPILE-OP NIL {AE39361}> on
                #<ASDF:CL-SOURCE-FILE "default" {AC55B71}>.
  1: [ACCEPT  ] Continue, treating #<ASDF:COMPILE-OP NIL {AE39361}> on
                #<ASDF:CL-SOURCE-FILE "default" {AC55B71}> as having
  been
                successful.
  2: [CONTINUE] Ignore and continue with next --eval option.
  3: [ABORT   ] Skip rest of --eval options.
  4:            Skip to toplevel READ/EVAL/PRINT loop.
  5: [QUIT    ] Quit SBCL (calling #'QUIT, killing the process).

((LAMBDA (SB-IMPL::E)) #<SIMPLE-ERROR {A9AAE61}>)
0] 5

; compilation aborted after 0:00:02
;
; compilation unit aborted
;   caught 2 fatal ERROR conditions

luca at gismo:~/Hacking/cl-debian/repository/ucw-upstream$
=====

I think that the above patch was created before applying patch [1]: I
tried on a separate repo [2] and I got the same darcs' conflict.

Apart from breaking the above situation, the patch adds an unnecessary
CL-Launch dependency: unnecessary because as of [1] CL-Launch is not
needed anymore (at least in the Common Lisp code).  

I committed a patch which removes any CL-Launch check.

Thx, bye,
Gismo / Luca

[1] Wed Apr 12 17:45:07 CEST 2006  Luca Capello <luca at pca.it>
      * src/default.lisp: use `arnesi:getenv' instead of
        `cl-launch:getenv'

[2] $ darcs get --to-patch "define quit as key" \
      http://common-lisp.net/project/ucw/repos/ucw_dev
    $ [modify src/default.lisp accordingly]
    $ darcs pull
      [...]
      Wed Apr 12 17:45:07 CEST 2006  Luca Capello <luca at pca.it>
        * src/default.lisp: use `arnesi:getenv' instead of 
          `cl-launch:getenv'
      Shall I pull this patch? (1/35) [ynWvpxqadjk], or ? for help: y
      [...]
      We have conflicts in the following files:
      ./src/default.lisp
      Finished pulling and applying.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/bese-devel/attachments/20060421/853de2dd/attachment.sig>