<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8">
</head>
<body>
<div style="font-family:sans-serif"><div style="white-space:normal">
<p dir="auto">Thank you very much for these, Marius. I will look into fixing them directly. One question - do I need to check for ECL version number when requiring sockets in the test? I.e., to I need to test with <code style="background-color:#F7F7F7; border-radius:3px; margin:0; padding:0 0.4em" bgcolor="#F7F7F7">:rt</code> in older versions and <code style="background-color:#F7F7F7; border-radius:3px; margin:0; padding:0 0.4em" bgcolor="#F7F7F7">:sockets</code> in newer? Or will <code style="background-color:#F7F7F7; border-radius:3px; margin:0; padding:0 0.4em" bgcolor="#F7F7F7">:sockets</code> work in older versions of ECL, as well?</p>
<p dir="auto">Best,<br>
R</p>
<p dir="auto">On 30 Aug 2018, at 12:46, Marius Gerbershagen wrote:</p>
</div>
<div style="white-space:normal"><blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px"><p dir="auto">Harmless in the sense that ECL doesn't crash or throw me in the<br>
interactive debugger. Besides, the test failures seem to be easily<br>
fixed. The test-require.script test fails because it tries to require<br>
the :rt module which is deprecated on the develop branch and no longer<br>
build by default. A simple fix is to use the :sockets module instead:<br>
<br>
diff --git a/test/test-require.script b/test/test-require.script<br>
index e5f70857..1ef84e8c 100644<br>
--- a/test/test-require.script<br>
+++ b/test/test-require.script<br>
@@ -178,7 +178,7 @@<br>
#+allegro :sax<br>
#+clisp (first (remove "asdf" *dynmod-list* :test 'equal))<br>
#+(or clozure cmucl) :defsystem<br>
- #+ecl :rt ;; loads faster than :ecl-quicklisp<br>
+ #+ecl :sockets<br>
#+lispworks "comm"<br>
#+mkcl :walker<br>
#+sbcl :sb-md5<br>
<br>
The test-program.script test seems to fail to include uiop because of an<br>
error in the linkable-system function. Tracing it shows that the<br>
function returns nil for the uiop system object,<br>
1> (ASDF/BUNDLE::LINKABLE-SYSTEM #<system "uiop">)<br>
<1 (ASDF/BUNDLE::LINKABLE-SYSTEM NIL)<br>
which seems to be caused by a missing call to coerce-name:<br>
<br>
diff --git a/bundle.lisp b/bundle.lisp<br>
index 2ff56f93..42034c9f 100644<br>
--- a/bundle.lisp<br>
+++ b/bundle.lisp<br>
@@ -529,7 +529,7 @@ which is probably not what you want; you probably<br>
need to tweak your output tran<br>
;; If an ASDF upgrade is available from source, but not a UIOP<br>
upgrade to that,<br>
;; then use the asdf/driver system instead of<br>
;; the UIOP that was disabled by check-not-old-asdf-system.<br>
- (if-let (s (and (equal x "uiop") (output-files 'lib-op "asdf")<br>
(find-system "asdf/driver")))<br>
+ (if-let (s (and (equal (coerce-name x) "uiop") (output-files<br>
'lib-op "asdf") (find-system "asdf/driver")))<br>
(and (output-files 'lib-op s) s))<br>
;; If there was no source upgrade, look for modules provided by<br>
the implementation.<br>
(if-let (p (system-module-pathname (coerce-name x)))<br>
<br>
<br>
Am 29.08.2018 um 01:22 schrieb Faré:</p>
<blockquote style="border-left:2px solid #777; color:#999; margin:0 0 5px; padding-left:5px; border-left-color:#999"><blockquote style="border-left:2px solid #777; color:#BBB; margin:0 0 5px; padding-left:5px; border-left-color:#BBB"><p dir="auto">I can't reproduce this, for me the tests run fine without being thrown<br>
in the debugger. I only get two harmlessly looking test failures<br>
(test-program.script and test-require.script).<br>
</p>
</blockquote><p dir="auto">No test failure is harmless. The test-program.script failure is what<br>
Robert saw, that I can reproduce. I didn't reproduce a failure with<br>
test-require. I had more problems with ECL from the develop branch,<br>
but maybe it was a bad idea to use the develop branch.<br>
<br>
—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• <a href="http://fare.tunes.org" style="color:#999">http://fare.tunes.org</a><br>
There are two kinds of people, those who do the work<br>
and those who take the credit. Try to be in the first group;<br>
there is less competition there<br>
— Indira Gandhi.<br>
</p>
</blockquote></blockquote></div>
<div style="white-space:normal">
</div>
</div>
</body>
</html>