asdf defsystem worked in 3.2.1 but not 3.3.0

[Faré]

I'm not sure it is allowed to use defsystem in a .lisp file — maybe
add :pathname nil so at least it doesn't try to associate the
current-lisp-file-pathname's to it? Or else put it in its own .asd
file?

—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org
"I wish there was a knob on the TV to turn up the intelligence.
There's a knob called `brightness', but it doesn't work."
                — Gallagher


On Sun, Oct 8, 2017 at 12:08 AM, Raymond Toy <toy.raymond at gmail.com> wrote:
> That's the entire defsystem.  But it's inside the file
> https://gitlab.common-lisp.net/cmucl/cmucl/blob/master/tests/pcl.lisp
>
> The entire error message (sorry for not including it earlier):
>
> Error while trying to load definition for system pcl-test from pathname
> /Volumes/share2/src/clnet/cmucl/snapshot-2017-10/tests/pcl.lisp: Circular
> dependency: ((#<ASDF/FIND-SYSTEM:DEFINE-OP> . #<ASDF/SYSTEM:SYSTEM
> "pcl-test">) (#<ASDF/LISP-ACTION:LOAD-OP> . #<ASDF/SYSTEM:SYSTEM
> "pcl-test">) (#<ASDF/LISP-ACTION:LOAD-OP> .
> #<ASDF/LISP-ACTION:CL-SOURCE-FILE "pcl-test" "pkg">)
> (#<ASDF/LISP-ACTION:PREPARE-OP> . #<ASDF/LISP-ACTION:CL-SOURCE-FILE
> "pcl-test" "pkg">) (#<ASDF/LISP-ACTION:PREPARE-OP> . #<ASDF/SYSTEM:SYSTEM
> "pcl-test">))
> Restarts:
>   0: [CONTINUE                     ] Return NIL from load of
> #P"/Volumes/share2/src/clnet/cmucl/snapshot-2017-10/tests/pcl.lisp".
>   1: [RETRY                        ] Retry #<DEFINE-OP> on #<SYSTEM
> "pcl-test">.
>   2: [ACCEPT                       ] Continue, treating #<DEFINE-OP> on
> #<SYSTEM "pcl-test"> as having been successful.
>   3:                                 Retry ASDF operation.
>   4: [CLEAR-CONFIGURATION-AND-RETRY] Retry ASDF operation after resetting
> the configuration.
>   5:                                 Retry ASDF operation.
>   6:                                 Retry ASDF operation after resetting
> the configuration.
>   7:                                 Return NIL from load of
> #P"/Volumes/share2/src/clnet/cmucl/snapshot-2017-10/tests/pcl.lisp".
>   8: [ABORT                        ] Skip remaining initializations.
>
> The file gets loaded from tests/run-tests.lisp
>
> I guess maybe that defsystem should be in its own file that pcl.lisp loads?
> I have a vague memory that you helped fix some similar issues with some asdf
> defsystems that I had, that were working fine but stopped working after some
> upgrade, maybe to 3.2.x.
>
>
> On Sat, Oct 7, 2017 at 8:55 PM, Faré <fahree at gmail.com> wrote:
>>
>> Maybe the circularity is at a wider level. What is the complete error
>> message? The complete set of .asd files? Are you using
>> defsystem-depends-on anywhere? Or manually loading .asd's from other
>> .asd's? How can I reproduce?
>>
>> —♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics•
>> http://fare.tunes.org
>> Passive hope is wishful thinking, a poison of the mind.
>> Active hope is creative passion, the mover of the universe.
>>
>>
>> On Sat, Oct 7, 2017 at 11:44 PM, Raymond Toy <toy.raymond at gmail.com>
>> wrote:
>> > The following defsystem worked in asdf 3.2.1 but no longer works in
>> > 3.3.0.
>> > The error message doesn't really help in figuring out what's circular.
>> > And
>> > I just can't see what's circular.
>> >
>> > The system:
>> >
>> > (asdf:defsystem :pcl-test
>> >   :pathname "pcl/"
>> >   :components
>> >   ((:file "pkg")
>> >    #+gerds-pcl
>> >    (:file "ctor"
>> >     :depends-on ("pkg"))
>> >    (:file "defclass"
>> >     :depends-on ("pkg"))
>> >    (:file "make-instance"
>> >     :depends-on ("pkg" #+gerds-pcl "ctor"))
>> >    (:file "reinitialize-instance"
>> >     :depends-on ("pkg" "make-instance"))
>> >    (:file "slot-value"
>> >     :depends-on ("pkg" "make-instance"))
>> >    (:file "slot-boundp"
>> >     :depends-on ("pkg" "make-instance"))
>> >    (:file "slot-missing"
>> >     :depends-on ("pkg" "make-instance"))
>> >    (:file "slot-accessors"
>> >     :depends-on ("pkg" "make-instance"))
>> >    (:file "slot-type"
>> >     :depends-on ("pkg" "slot-value"))
>> >    (:file "inline-access"
>> >     :depends-on ("pkg" "slot-type"))
>> >    (:file "method-combination"
>> >     :depends-on ("pkg"))
>> >    (:file "pv"
>> >     :depends-on ("pkg"))
>> >    (:file "defgeneric"
>> >     :depends-on ("pkg"))
>> >    (:file "defmethod"
>> >     :depends-on ("pkg"))
>> >    (:file "find-method"
>> >     :depends-on ("pkg"))
>> >    (:file "methods"
>> >     :depends-on ("pkg"))))
>> >
>> > --
>> > Ray
>
>
>
>
> --
> Ray