[asdf-devel] Performance hit in TRUENAMIZE

[Faré]

Committed as 2.112.

[ François-René ÐVB Rideau | Reflection&Cybernethics | http://fare.tunes.org ]
An anarchist is a man who is careful to always use pedestrian crossings,
because he utterly detests talking with policemen. — Georges Brassens




On 25 July 2010 09:04, Juan Jose Garcia-Ripoll
<juanjose.garciaripoll at googlemail.com> wrote:
> On Sun, Jul 25, 2010 at 12:48 AM, Faré <fahree at gmail.com> wrote:
>>
>> I don't see what probe-file does that's different from (ignore-errors
>> (truename ...)),
>
> I explained it in the previous email. Determining whether a file exists has
> a very very small cost, just a call to fstat() or whatever equivalent
> function the Common Lisp provides. Say this has a cost 1. This is followed
> by a call to TRUENAME which has a cost N, proportional to the length of
> components in the directory part of the pathname, but this cost only applies
> when the file exists. This is relevant for ASDF because 80% of the calls to
> TRUENAME may happen with non-existent paths.
>
>> Can you test/review the following patch based on yours? I intend to
>> make it into ASDF 2.112.
>
> Seems to work just fine.
>
> Juanjo
>
> --
> Instituto de Física Fundamental, CSIC
> c/ Serrano, 113b, Madrid 28006 (Spain)
> http://juanjose.garciaripoll.googlepages.com
>