[asdf-devel] [PATCH 2/2] More carefully look for compiled asdf.lisp.

Robert Goldman rpgoldman at sift.info
Thu Feb 4 17:08:13 UTC 2010


On 2/3/10 Feb 3 -10:34 PM, Faré wrote:
> I applied your two other patches, but this one won't apply, probably
> because of redundant whitespace changes.
> 
> Please merge it with the latest head on my repo.

I'm afraid that is far beyond my git fu.

However, I have an alternative soution:

In the asdf/test directory

perl -pi.bak -e 's|"../asdf"|\(compile-file-pathname "../asdf"\)|;' *.script

That should all be one line; not sure what the mailers will do with that.

As for the whitespace changes, I suspect that has to do with my emacs killing trailing whitespace.

"No trailing whitespace" might be a good entry into our "ASDF whitespace policy," 
since it contributes to bogus merge conflicts.

But if we're going to do this, we should stop, release, then release again with all trailing whitespace removed, so that everybody can get on the same "whitespace page"....

cheers,
R

> 
> [ François-René ÐVB Rideau | Reflection&Cybernethics | http://fare.tunes.org ]
> Amateur bureaucrats are often even worse than professional bureaucrats.
>         — John McCarthy
> 
> On 3 February 2010 23:04,  <rpgoldman at sift.info> wrote:
>> From: Robert P. Goldman <rpgoldman at real-time.com>
>>
>> Found that the current load recipe (load "../asdf") in the test
>> scripts was brittle, because the presence of asdf.fasl was obscured
>> if there was an "asdf/" directory in ..  Unfortunately, the result
>> of makeinfo --html asdf.texinfo created just such a directory!
>> fe[nl]ix kindly provided a pointer to compile-file-pathname that
>> solved the problem.
>> ---
>>  test/test-force.script                     |    6 +++---
>>  test/test-module-pathnames.script          |   14 +++++++-------
>>  test/test-nested-components.script         |   10 +++++-----
>>  test/test-package.script                   |    2 +-
>>  test/test-retry-loading-component-1.script |    6 +++---
>>  test/test-static-and-serial.script         |    8 ++++----
>>  test/test-touch-system-1.script            |    4 ++--
>>  test/test-touch-system-2.script            |    4 ++--
>>  test/test-try-recompiling-1.script         |    8 ++++----
>>  test/test-utilities.script                 |    2 +-
>>  test/test-version.script                   |    4 ++--
>>  test/test1.script                          |    8 ++++----
>>  test/test2.script                          |   10 +++++-----
>>  test/test3.script                          |    8 ++++----
>>  test/test4.script                          |    4 ++--
>>  test/test8.script                          |    6 +++---
>>  test/test9.script                          |    8 ++++----
>>  test/wild-module.script                    |    6 +++---
>>  18 files changed, 59 insertions(+), 59 deletions(-)





More information about the asdf-devel mailing list